1. 31 Jan, 2024 1 commit
    • Dan Field's avatar
      Refactor ShaderTarget to not explicitly mention impeller or Skia (#141460) · c417c462
      Dan Field authored
      Refactors `ShaderTarget` to make it opaque as to whether it's using Impeller or SkSL and instead has it focus on the target platform it's generating for.
      
      ImpellerC includes SkSL right now whether you ask for it or not. 
      
      The tester target also might need SkSL or Vulkan depending on whether `--enable-impeller` is passed.
      c417c462
  2. 25 Jan, 2024 1 commit
    • Andrew Kolos's avatar
      provide command to `FakeCommand::onRun` (#142206) · 295a9a20
      Andrew Kolos authored
      Part of work on [#101077](https://github.com/flutter/flutter/pull/141194). This is done as a separate PR to avoid a massive diff.
      
      ## Context
      1. The `FakeCommand` class accepts a list of patterns that's used to match a command given to its `FakeProcessManager`. Since `FakeCommand` can match a list of patterns, not just specifically strings, it can be used to match commands where the exact value of some arguments can't (easily) known ahead of time. For example, a part of the tool may invoke a command with an argument that is the path of a temporarily file that has a randomly-generated basename.
      2. The `FakeCommand` class provides on `onRun` parameter, which is a callback that is run when the `FakeProcessManager` runs a command that matches the `FakeCommand` in question.
      
      ## Issue
      In the event that a `FakeCommand` is constructed using patterns, the test code can't know the exact values used for arguments in the command. This PR proposes changing the type of `onRun` from `VoidCallback?` to `void Function(List<String>)?`. When run, the value `List<String>` parameter will be the full command that the `FakeCommand` matched.
      
      Example:
      ```dart
      FakeCommand(
        command: <Pattern>[
          artifacts.getArtifactPath(Artifact.engineDartBinary),
          'run',
          'vector_graphics_compiler',
          RegExp(r'--input=/.*\.temp'),
          RegExp(r'--output=/.*\.temp'),
        ],
        onRun: (List<String> command) {
          final outputPath = (() { 
            // code to parse `--output` from `command`
          })();
          testFileSystem.file(outputPath).createSync(recursive: true);
        },
      )
      ```
      295a9a20
  3. 03 Jan, 2024 2 commits
  4. 02 Jan, 2024 2 commits
  5. 22 Nov, 2023 1 commit
  6. 14 Apr, 2023 1 commit
  7. 28 Mar, 2023 1 commit
  8. 27 Jan, 2023 1 commit
  9. 12 Dec, 2022 1 commit
  10. 29 Nov, 2022 1 commit
  11. 15 Nov, 2022 1 commit
  12. 10 Nov, 2022 1 commit
  13. 02 Nov, 2022 1 commit
  14. 04 Oct, 2022 1 commit
  15. 05 Sep, 2022 1 commit
  16. 30 Jul, 2022 1 commit
  17. 29 Jul, 2022 1 commit
  18. 18 Jun, 2022 1 commit
  19. 27 Apr, 2022 1 commit
  20. 15 Apr, 2022 1 commit
  21. 12 Nov, 2021 1 commit
  22. 24 Jun, 2021 1 commit
  23. 23 Jun, 2021 1 commit
  24. 16 Jun, 2021 1 commit
  25. 12 May, 2021 1 commit
  26. 08 May, 2021 1 commit
  27. 06 May, 2021 1 commit
  28. 01 May, 2021 1 commit
  29. 28 Apr, 2021 1 commit
  30. 15 Apr, 2021 1 commit
  31. 09 Mar, 2021 1 commit
  32. 05 Mar, 2021 1 commit
  33. 01 Mar, 2021 1 commit
  34. 26 Feb, 2021 1 commit
  35. 25 Feb, 2021 1 commit
  36. 18 Feb, 2021 1 commit
  37. 27 Jan, 2021 1 commit
  38. 23 Dec, 2020 1 commit