Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
c1ceda41
Unverified
Commit
c1ceda41
authored
Nov 10, 2022
by
Jenn Magder
Committed by
GitHub
Nov 10, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Include stdout in codesign failure output (#115115)
parent
1f891a0f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
23 additions
and
9 deletions
+23
-9
ios.dart
packages/flutter_tools/lib/src/build_system/targets/ios.dart
+11
-1
ios_test.dart
...ols/test/general.shard/build_system/targets/ios_test.dart
+12
-8
No files found.
packages/flutter_tools/lib/src/build_system/targets/ios.dart
View file @
c1ceda41
...
...
@@ -711,6 +711,16 @@ void _signFramework(Environment environment, String binaryPath, BuildMode buildM
binaryPath
,
]);
if
(
result
.
exitCode
!=
0
)
{
throw
Exception
(
'Failed to codesign
$binaryPath
with identity
$codesignIdentity
.
\n
${result.stderr}
'
);
final
String
stdout
=
(
result
.
stdout
as
String
).
trim
();
final
String
stderr
=
(
result
.
stderr
as
String
).
trim
();
final
StringBuffer
output
=
StringBuffer
();
output
.
writeln
(
'Failed to codesign
$binaryPath
with identity
$codesignIdentity
.'
);
if
(
stdout
.
isNotEmpty
)
{
output
.
writeln
(
stdout
);
}
if
(
stderr
.
isNotEmpty
)
{
output
.
writeln
(
stderr
);
}
throw
Exception
(
output
.
toString
());
}
}
packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart
View file @
c1ceda41
...
...
@@ -836,13 +836,17 @@ void main() {
lipoCommandNonFatResult
,
lipoVerifyArm64Command
,
FakeCommand
(
command:
<
String
>[
'codesign'
,
'--force'
,
'--sign'
,
'ABC123'
,
'--timestamp=none'
,
binary
.
path
,
],
exitCode:
1
,
stderr:
'codesign error'
),
'codesign'
,
'--force'
,
'--sign'
,
'ABC123'
,
'--timestamp=none'
,
binary
.
path
,
],
exitCode:
1
,
stderr:
'codesign error'
,
stdout:
'codesign info'
,
),
]);
await
expectLater
(
...
...
@@ -850,7 +854,7 @@ void main() {
throwsA
(
isException
.
having
(
(
Exception
exception
)
=>
exception
.
toString
(),
'description'
,
contains
(
'Failed to codesign output/Flutter.framework/Flutter with identity ABC123.
\n
codesign error'
),
contains
(
'Failed to codesign output/Flutter.framework/Flutter with identity ABC123.
\n
codesign
info
\n
codesign
error'
),
)),
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment