1. 26 Jun, 2015 1 commit
    • Hixie's avatar
      Add asserts to catch potential misuses of the rendering framework. · aef18a90
      Hixie authored
      New asserts:
      - verify that after layout, the size fits the constraints
      - verify that after layout, the size isn't infinite
      - verify that you don't set the size in performLayout() if you have
        sizedByParent set
      - verify that nobody reads your size during layout except you, or your
        parent if they said parentUsesSize:true
      
      Fixes some bugs found by those asserts:
      - RenderBlock, RenderStack, and RenderScaffold were not always setting
        parentUsesSize correctly
      - RenderScaffold was setting its slot entries to null rather than
        removing them when the slot went away, which led to null derefs in
        certain circumstances
      
      Also, rename a local variable in RenderStack.performLayout() because
      it was shadowing a variable on the object itself, which was really
      confusing when I first tried to debug this function...
      
      R=abarth@chromium.org
      
      Review URL: https://codereview.chromium.org/1213473003.
      aef18a90
  2. 25 Jun, 2015 4 commits
  3. 24 Jun, 2015 4 commits
  4. 23 Jun, 2015 8 commits
  5. 22 Jun, 2015 4 commits
  6. 19 Jun, 2015 4 commits
  7. 18 Jun, 2015 12 commits
  8. 17 Jun, 2015 3 commits