- 26 Jun, 2015 1 commit
-
-
Hixie authored
New asserts: - verify that after layout, the size fits the constraints - verify that after layout, the size isn't infinite - verify that you don't set the size in performLayout() if you have sizedByParent set - verify that nobody reads your size during layout except you, or your parent if they said parentUsesSize:true Fixes some bugs found by those asserts: - RenderBlock, RenderStack, and RenderScaffold were not always setting parentUsesSize correctly - RenderScaffold was setting its slot entries to null rather than removing them when the slot went away, which led to null derefs in certain circumstances Also, rename a local variable in RenderStack.performLayout() because it was shadowing a variable on the object itself, which was really confusing when I first tried to debug this function... R=abarth@chromium.org Review URL: https://codereview.chromium.org/1213473003.
-
- 25 Jun, 2015 4 commits
-
-
Hans Muller authored
There's is no support for animating the selected tab indicator, there isn't a TabNavigator container yet, overflow layout (tabs don't fit) isn't supported yet, etc. R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1205953002.
-
Viktor Lidholt authored
Adds documentation to Texture and SpriteSheet R=abarth@chromium.org Review URL: https://codereview.chromium.org/1212073002.
-
Carlos Pizano authored
Win was not being detected. BUG=none R=abarth@chromium.org Review URL: https://codereview.chromium.org/1209823002.
-
Hixie authored
This also fixes the C++ side to give the right baseline information. Previously it was giving the baseline distance for the font, but not for the actual laid-out text. I considered also providing a "defaultBaseline" accessor that returns the distance for the actual dominant baseline, but it turns out right now we never decide the baseline is ideographic. We always use the alphabetic baseline. We should probably fix that... R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1200233002.
-
- 24 Jun, 2015 4 commits
-
-
Hixie authored
Also, some minor cleanup in TextStyle to make it more readable. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1203253002.
-
Hixie authored
TBR=iansf Review URL: https://codereview.chromium.org/1201383005.
-
Hixie authored
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1208483002.
-
Ian Fischer authored
Decouple Canvas from DisplayList and map Picture and PictureRecorder more directly to their Skia counterparts. Also changes the framework dart code to use the refactored APIs and fixes the various examples and tests. R=abarth@chromium.org, ianh@chromium.org Review URL: https://codereview.chromium.org/1190123003.
-
- 23 Jun, 2015 8 commits
-
-
Viktor Lidholt authored
Adds drawImageRect to Canvas bindings R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1204783003.
-
Eric Seidel authored
I'm not sure I made it look better. But it uses Widgets instead of rolling its own Flex, etc. R=ianh@google.com, cpu@chromium.org Review URL: https://codereview.chromium.org/1201293003.
-
Collin Jackson authored
R=ianh@google.com, abarth, hixie Review URL: https://codereview.chromium.org/1201273002.
-
Carlos Pizano authored
A very basic minesweeper clone. Currently only tested in linux. BUG=none R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1196213012.
-
Eric Seidel authored
Also updated the version range on stocks2. https://github.com/domokit/mojo/issues/262 R=ianh@google.com Review URL: https://codereview.chromium.org/1195933004.
-
Hixie authored
Make the checkbox in settings control the radio buttons in the drawer, to demonstrate how to link state in different places in an app. R=jackson@google.com Review URL: https://codereview.chromium.org/1197333002.
-
Hixie authored
This returns us to a more stocks1-like arrow style. Also it uses math rather than transforms to rotate the arrow, since transforms are expensive. It also removes the save/restore calls, which are _really_ expensive. Also some minor style fixes. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1203443007.
-
Collin Jackson authored
R=ianh@google.com, hixie Review URL: https://codereview.chromium.org/1204523002.
-
- 22 Jun, 2015 4 commits
-
-
Hixie authored
Short-circuit the relayoutSubtreeRoot when the child couldn't change dimensions anyway because the parent constrained it. The relayout subtree root concept is intended to handle the case where a node, when it lays itself out for a second time, changes its opinion about what dimensions it should be. In such a situation, the parent, if it based its own opinion about what size _it_ should be on the child's dimensions, would also need to lay itself out again. Thus, when this scenario is possible, the child remembers the parent, and when it would be told to relayout, we actually start the layout with the parent. In practice, this chains, and we end up with nodes that point to ancestors ten or more steps up the tree such that when the inner most child re-lays-out, the whole app ends up relaying out. This patch tries to short-circuit this for the case where the constraints being applied to the child are such that actually, the child has no choice about its dimensions. In that case, the parent can't change dimensions when the child re-lays-out. This makes a huge difference on the stocks demo app. Without this, on the third rendered frame, there are 72 relayoutSubtreeRoot links, the deepest chain is 8 deep, and 9 of the chains are only 1 level deep. With it, there are 63 relayoutSubtreeRoot links, the deepest chain is only 4 deep, and 38 of the chains are only 1 level deep. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1196553004.
-
Eric Seidel authored
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1204483002.
-
Collin Jackson authored
R=abarth@chromium.org, abarth, hixie Review URL: https://codereview.chromium.org/1194743003.
-
Viktor Lidholt authored
R=ianh@google.com Review URL: https://codereview.chromium.org/1201983004.
-
- 19 Jun, 2015 4 commits
-
-
Hixie authored
Turn on wavy underlines. The waves aren't very pretty yet (they are too short somehow), I'll fix that in a subsequent CL. I abstracted out the wavy underline code so that it doesn't duplicate the code for horizontal and vertical lines. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1201503003.
-
Viktor Lidholt authored
Renames hitTest to isPointInside Refactor sorting of children in nodes Fixes zPosition in sprites and hides internal methods Adds scaleX / scaleY properties R=abarth@chromium.org Review URL: https://codereview.chromium.org/1190393004.
-
Hans Muller authored
Currently only the decoration property is actually translated to a CSS style. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174213005.
-
Viktor Lidholt authored
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1197493002.
-
- 18 Jun, 2015 12 commits
-
-
Collin Jackson authored
TBR=abarth Review URL: https://codereview.chromium.org/1189113004.
-
Collin Jackson authored
Currently you lose your scroll and drawer state when coming back from the settings pane. I think we should solve this by having the Navigator maintain a Stack and keeping the StockHome alive underneath it. But this is good enough for a first iteration. R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1191153002.
-
Viktor Lidholt authored
Enabling/disabling of handling multiple pointers Adds basic touch handling R=abarth@chromium.org Review URL: https://codereview.chromium.org/1179413009.
-
Hans Muller authored
tree of InlineStyle and InlineText elements. StyledText builds an Inline that renders the tree. For example this StyledText object: new StyledText(["FOO", [boldLargerStyle, [greenStyle "BAR"], "BAZ"] BORF]); Renders the same way the following HTML would, assuming that TextStyles boldLargerStyle and greenStyle were defined. <style> div { display: inline; } </style> <p> <div> FOO <div style="font-weight:bold; font-size:larger"> <div style="color:green"> BAR </div> BAZ </div> BORF </div> </p> R=abarth@chromium.org Review URL: https://codereview.chromium.org/1194693002.
-
Hixie authored
Flesh out a README.md file for the SDK. Make the stocks app test wait for the app to be mounted, to catch some more errors, like typos in the mount callback. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1182053012.
-
Matt Perry authored
I use it a lot to test and demo the painting API. R=ianh@google.com Review URL: https://codereview.chromium.org/1188823008.
-
Matt Perry authored
Add a test for RenderDecoratedBox sets up the Paint object correctly. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1185423003.
-
Ian Fischer authored
R=ianh@google.com, abarth@chromium.org Review URL: https://codereview.chromium.org/1182993003.
-
Adam Barth authored
We can't have two copies of |embedder.dart| or |shell.dart| because they take ownership of some underlying Mojo handles. Instead of duplicating the code, this CL makes the old locations just export all the symbols from the new location. I've also done the same with fetch.dart to avoid code duplication. Finally, I've removed image_cache.dart in the old location because the only clients already live in the new world and ought to use the new location. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1179923004.
-
Hixie authored
Some files are moved by this: Copy framework/node.dart into types/ - preparing for framework/'s decomissioning. Move app/scheduler.dart into sky/scheduler.dart - "app" doesn't really make sense. As part of the SkyBinding cleanup, I made the hit-testing less RenderBox-specific, by having the HitTestEntry.target member be a HitTestTarget, which is an interface with the handleEvent() function, which is then implemented by RenderBox. In theory, someone could now extend hit testing from the RenderBox world into their own tree of nodes, and take part in all the same dispatch logic automatically. This involved moving all the hit testing type definitions into a new sky/hittest.dart file. Renamed SkyBinding._app to SkyBinding._instance for clarity. Moved code around in SkyBinding so that related things are together. Made WidgetSkyBinding use the existing SkyBinding.instance singleton logic rather than having its own copy. I also added some stub README.md files that describe dependencies. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1187393002.
-
Hixie authored
Move app/view.dart to rendering/sky_binding.dart since it's part of the RenderObject API, really (it knows about RenderView intimately). The tests pass. I didn't check every last example. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1183913006.
-
Adam Barth authored
Also, trim the redundant |Mode| suffix from the TransferMode names. R=ianh@google.com Review URL: https://codereview.chromium.org/1188003006.
-
- 17 Jun, 2015 3 commits
-
-
Adam Barth authored
Buttons and menu items use onPressed. Also, don't pass along the sky.Event because that's a lower-level concept. I've also reordered parameter lists to put the |child| argument last in a number of places. Also, fixed a bug where FloatingActionButton was missing syncFields. R=ianh@google.com Review URL: https://codereview.chromium.org/1188993003.
-
Hans Muller authored
Defined constants for all 9 CSS font-weight values with conventional names from the "Common weight name mapping" section of https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight. The FontWeight enum now just enumerates the actual CSS weight values. I've moved the TextStyle class into its own file. R=ianh@google.com Review URL: https://codereview.chromium.org/1173323004.
-
Hixie authored
This also moves the test for stocks into a new tests/examples/ directory, where we can put tests that test the examples. TBR=abarth Review URL: https://codereview.chromium.org/1182223004.
-