1. 29 Jun, 2018 1 commit
  2. 28 Jun, 2018 1 commit
  3. 27 Jun, 2018 1 commit
  4. 20 Jun, 2018 1 commit
  5. 19 Jun, 2018 1 commit
  6. 15 Jun, 2018 3 commits
  7. 14 Jun, 2018 1 commit
  8. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  9. 11 Jun, 2018 1 commit
    • Greg Spencer's avatar
      Update typedef syntax to use Function notation and turn on lint for old notation. (#18362) · 6c56bb24
      Greg Spencer authored
      Now that Dart 1 is turned off, reapplying my change to turn on the prefer_generic_function_type_aliases analysis option, and fix all the typedefs to Dart 2 preferred syntax.
      
      Also eliminated the unused analysis_options_repo.yaml file and turned on public_member_api_docs in analysys_options.yaml.
      
      No logic changes, just changing the typedef syntax for all typedefs, and updating analysis options.
      6c56bb24
  10. 09 Jun, 2018 2 commits
  11. 08 Jun, 2018 3 commits
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05
    • Chris Bracken's avatar
      Revert "It's time to #deleteDart1 (#18293)" (#18313) · 9495df4b
      Chris Bracken authored
      Several benchmarks started failing during kernel compile:
      1. Timeouts:
         * commands_test
         * hot_mode_dev_cycle__benchmark
         * run_machine_concurrent_hot_reload
         * service_extensions_test
      
      2. Kernel compiler crash:
         * hot_mode_dev_cycle_linux__benchmark
         * routing_test
      
      3. Unexpected termination:
         * hot_mode_dev_cycle_win__benchmark
      
      This reverts commit ed63e708.
      9495df4b
    • Chris Bracken's avatar
      It's time to #deleteDart1 (#18293) · ed63e708
      Chris Bracken authored
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      ed63e708
  12. 05 Jun, 2018 2 commits
  13. 04 Jun, 2018 2 commits
  14. 30 May, 2018 2 commits
  15. 14 May, 2018 1 commit
  16. 11 May, 2018 1 commit
    • Chris Bracken's avatar
      Update a TODO with issue number (#17494) · f685568d
      Chris Bracken authored
      Further digging revealed that the reason --no-sim-use-hardfp was
      required to be specified explicitly was that Android engine gen_snapshot
      binaries are built on Windows with target_os=win.
      f685568d
  17. 10 May, 2018 1 commit
    • Chris Bracken's avatar
      Explicitly specify softfp ABI for armv7 builds (#17453) · 28e644e8
      Chris Bracken authored
      This reverts #17147, which was safe under the assumption that
      getArtifactPath() returns a platform-specific gen_snapshot instance
      (which have the correct default set for this flag) -- it turns out that
      though we pass the platform to getArtifactPath(), we always return the
      host gen_snapshot for Android.
      
      A followup patch will update getArtifactPath and revert this patch.
      28e644e8
  18. 09 May, 2018 3 commits
    • Chris Bracken's avatar
      Correct profile-mode AOT snapshot flags (#17435) · 1c27a458
      Chris Bracken authored
      Previously, in non-release (i.e. profile) AOT builds, we were setting
      --no-checked and --conditional_directives flags. --no-checked is the
      default, and we don't make use of conditional directives in Flutter.
      1c27a458
    • Chris Bracken's avatar
      Add pathFilter to Fingerprinter (#17412) · e4f55332
      Chris Bracken authored
      Allows users of Fingerprinter to filter the set of paths collected from
      the explicitly-specified paths and those collected from depfiles.
      
      In some cases, depfiles are emitted with files that are not present on
      the local disk (e.g. the frontend compiler currently emits buildbot
      paths for the dart core libraries and dart:ui). These files will not
      materially affect whether we need to re-run a build action for which
      they are inputs, since they're not present in the filesystem and
      therefore cannot change.
      e4f55332
    • Chris Bracken's avatar
      Replace --prefer-shared-library with --build-shared-library (#17394) · 8b8d368d
      Chris Bracken authored
      This replaces the --prefer-shared-library flag, which falls back to
      regular (non-shared-lib) compile if the NDK is not found, with the
      --build-shared-library flag, which exits with an error message if the
      NDK is not found.
      
      This simplifies the set of allowed code paths through AOT compile,
      resulting in better testability and easier-to-follow logic. It also
      results in more predictable behaviour for continuous integration and
      other scenarios.
      8b8d368d
  19. 08 May, 2018 1 commit
  20. 07 May, 2018 1 commit
    • Chris Bracken's avatar
      Support multi-arch iOS binaries (#17312) · 849676fc
      Chris Bracken authored
      This change adds support for armv7, arm64, and universal iOS apps.
      
      This change eliminates iOS target architecture hardcoding (previously
      arm64 only) and uses the target architecture(s) specified in Xcode's
      ARCHS setting ('Architectures' in Xcode Build Settings).
      
      For universal binaries, set ARCHS to its default value, $(ARCHS_STANDARD).
      
      Note that after changing the architecture in Xcode, developers should
      run 'pod install' from the ios subdirectory of their project. A separate
      change (that will land before this one) will add support for
      automatically detecting project file and Podfile changes and re-running
      pod install if necessary.
      
      This change also adds an --ios-arch option to flutter build aot. In iOS
      AOT builds (in profile and release mode), this dictates which
      architectures are built into App.framework. This flag should generally
      be unnecessary to set manually since flutter build aot is typically only
      invoked internally by flutter itself.
      849676fc
  21. 04 May, 2018 3 commits
    • Todd Volkert's avatar
      Use deprecated io constants (#17278) · d820e5f3
      Todd Volkert authored
      The new values are not ready for use yet inside Google
      d820e5f3
    • Yegor's avatar
      Roll engine to e976be13c51448f89107d082ec81e2b6731671fa (#17266) · b2c98f9a
      Yegor authored
      * Roll engine to e976be13c51448f89107d082ec81e2b6731671fa
      
      * move away from deprecated constants
      b2c98f9a
    • Chris Bracken's avatar
      Add Fingerprinter class (#17255) · 66c7b6a9
      Chris Bracken authored
      Adds a Fingerprinter utility class that can be used to compute unique
      fingerprints for a set of input paths and build options, compare to the
      output of a previous run, and skip the build action if no inputs or
      options have changed. The existing Fingerprint class still does all the
      heavy lifting. Fingerprinter adds common operations such as
      reading/writing/comparing fingerprints and parsing depfiles.
      
      This migrates existing uses of Fingerprint over to Fingerprinter.
      
      This also adds better fingerprinting to AOT snapshotting, which
      previously failed to include several options in its fingerprint
      (--preview-dart-2, --prefer-shared-library).
      66c7b6a9
  22. 02 May, 2018 1 commit
  23. 01 May, 2018 6 commits
    • Chris Bracken's avatar
    • Chris Bracken's avatar
      Eliminate unnecessary params in assembly AOT (#17164) · c77ceb01
      Chris Bracken authored
      Previously, we were incorrectly passing --vm_snapshot_data and
      --isolate_snapshot_data options to gen_snapshot in assembly AOT builds.
      These only make sense in AOT blob snapshot mode (alongside
      --vm_snapshot_instructions and --isolate_snapshot_instructions).
      c77ceb01
    • Chris Bracken's avatar
      Split Snapshotter into AOT and Script classes (#17159) · 42ed0152
      Chris Bracken authored
      There's very little code-sharing between the two, and what little there
      is is concentrated in the GenSnapshotClass and the fingerprint
      reading/writing utility methods.
      42ed0152
    • Chris Bracken's avatar
      Simplify split between assembly/blob AOT compile (#17157) · 064d2f42
      Chris Bracken authored
      This de-duplicates assembly AOT configuration between Android and iOS,
      and makes it easier to adjust parameters for 32-bit iOS (which, like
      32-bit Android, requires --no-integer-division) in an upcoming patch.
      064d2f42
    • Chris Bracken's avatar
      Eliminate hardcoding of no-sim-use-hardfp (#17147) · 23adf008
      Chris Bracken authored
      This is now derived automatically from the target platform by
      gen_snapshot.
      23adf008
    • Chris Bracken's avatar
      Simplify iOS debug build (#17145) · 68a1e2f7
      Chris Bracken authored
      iOS debug builds always run in interpreted mode whether on device or on
      simulator. In both cases, we can skip snapshotting and link against an
      empty App.framework. Previously, we did this for iOS simulator builds.
      This does the same for device builds.
      
      Previously, debug iOS builds used gen_snapshot to generate a core
      snapshot, then used 'xxd' to generate C files containing the snapshot
      data in buffers named kDartVmSnapshotData and kDartIsolateSnapshotData,
      which are then compiled/linked into App.framework. This is unnecessary
      since the VM compiled into Flutter.framework already contains this data.
      68a1e2f7