Unverified Commit 1c27a458 authored by Chris Bracken's avatar Chris Bracken Committed by GitHub

Correct profile-mode AOT snapshot flags (#17435)

Previously, in non-release (i.e. profile) AOT builds, we were setting
--no-checked and --conditional_directives flags. --no-checked is the
default, and we don't make use of conditional directives in Flutter.
parent e4f55332
...@@ -194,12 +194,6 @@ class AOTSnapshotter { ...@@ -194,12 +194,6 @@ class AOTSnapshotter {
'--strong', '--strong',
]); ]);
} }
if (buildMode != BuildMode.release) {
genSnapshotArgs.addAll(<String>[
'--no-checked',
'--conditional_directives',
]);
}
if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) { if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) {
printTrace('Extra gen_snapshot options: $extraGenSnapshotOptions'); printTrace('Extra gen_snapshot options: $extraGenSnapshotOptions');
genSnapshotArgs.addAll(extraGenSnapshotOptions); genSnapshotArgs.addAll(extraGenSnapshotOptions);
......
...@@ -396,8 +396,6 @@ void main() { ...@@ -396,8 +396,6 @@ void main() {
'--dependencies=${fs.path.join(outputPath, 'snapshot.d')}', '--dependencies=${fs.path.join(outputPath, 'snapshot.d')}',
'--reify-generic-functions', '--reify-generic-functions',
'--strong', '--strong',
'--no-checked',
'--conditional_directives',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'main.dill', 'main.dill',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment