- 10 Jun, 2020 2 commits
-
-
Jonah Williams authored
The tool was setting the output preferences in a sub-context. Originally these were not injected before the arg parsers were created, though that was fixed by the lazy command creation. Once local engine is removed, the inner flutter_command Zone can be removed.
-
Jonah Williams authored
Remove global Platfrom from proxy validator. move tests to new file, and update asserts to cover message contents.
-
- 09 Jun, 2020 10 commits
-
-
Jonah Williams authored
[flutter_tools] create NotifyingLogger at the top level when running flutter run --machine or flutter attach --machine (#59087) Removes dependency on injecting additional logger with zones
-
Jonah Williams authored
Support Microsoft Edge as a device for flutter run when web is enabled. Currently this only works on Windows, and does not include a validator for edge. Fixes #55322
-
Jonah Williams authored
This prevents using a cached kernel file with different defines, since --initialize-from-dill does not handle this correctly. Fixes #58976
-
Christopher Fujino authored
-
Helin Shiah authored
-
Jonah Williams authored
Adds support for --bundle-sksl-path to windows, linux, macOS, and iOS. Fixes #53115
-
Jonah Williams authored
flutter analyze was unconditionally using the cached dart-sdk for analysis, and was not running with the built SDK during local engine. This broke when trying to update the analyzer for null safety, since it required us to wait for the dart change to roll into the framework first.
-
Jonah Williams authored
This reverts commit 9ed3e5be.
-
Jonah Williams authored
flutter analyze was unconditionally using the cached dart-sdk for analysis, and was not running with the built SDK during local engine. This broke when trying to update the analyzer for null safety, since it required us to wait for the dart change to roll into the framework first.
-
Jenn Magder authored
-
- 08 Jun, 2020 9 commits
-
-
Jenn Magder authored
This reverts commit 43e28084.
-
Jenn Magder authored
-
Jonah Williams authored
update flutter_service_worker.js to NOTICES
-
Jonah Williams authored
This reverts commit f0174b17.
-
Jonah Williams authored
-
Jenn Magder authored
-
Helin Shiah authored
* Revert "Revert "Send text error in JSON and print in tools (#58284)" (#58872)" This reverts commit c2d5e18c. * Put streamListen in try/catch if extension events already listened for
-
Jonah Williams authored
instead of restricting profile/release mode based on whether the tool thinks the device is an emulator, restrict based on the device target architecture and the requested build mode. Notably, this enables release mode on x86_64 Android emulators, but not x86 emulators since we do not support that as an AOT target. This does not add release mode support for simulators, since this requires us to build and upload artifacts for simulator/x86_64
-
Jonah Williams authored
Instead of targets/dart.dart -> targets/common.dart
-
- 06 Jun, 2020 3 commits
-
-
Jonah Williams authored
-
Jonah Williams authored
This reverts commit cce6b3c5.
-
Helin Shiah authored
* Send text error in JSON and print in tools * Add test for error text * Fix analysis issues * Move streamListen to try/catch and use global.printStatus * Extract print error fn and listen for events in web runner * Add extension listen request to test * Update packages/flutter_tools/lib/src/resident_runner.dart Co-authored-by:
Jonah Williams <jonahwilliams@google.com> * Rename error parsing method * Allow crash if listen for extension stream fails * Add test for error and non-error extension events * Fix formatting for TextTreeRenderer * Use shorter message for second exceptions * Specify types for map * Add empty JSON for resident_web_runner test * Move stream listen to vmservice and add vmservice test * Fix stream type * Move structured error log definition to vmservice * Use correct test matcher isNot Co-authored-by:
Jonah Williams <jonahwilliams@google.com>
-
- 05 Jun, 2020 4 commits
-
-
Jonah Williams authored
So that we have a release where both are available without a deprecation warning.
-
Jonah Williams authored
Allow dumping sksl files on driver exit when a file path is provided to drive's --write-sksl-on-exit
-
Jonah Williams authored
-
stuartmorgan authored
Current versions of the Windows desktop build files don't require a specific Windows 10 SDK version, but doctor still checks for one since vswhere doesn't allow for flexible queries. This has been a common source of issues for people setting up on Windows for the first time, because the current VS installer by default only includes a newer version of the SDK than what doctor is looking for. This removes the vswhere SDK check, and instead uses a manual check for SDKs. Since this uses undocumented (although fairly widely used, so relatively unlikely to change) registry information, the check is non-fatal, so that builds can progress even if the SDK isn't found by doctor; in practice, it's very unlikely that someone would install the C++ Windows development workload but remove the selected-by-default SDK from the install. Now that all requirements are default, the instructions when missing VS have been simplified so that they no longer list individual components, and instead just say to include default items. Fixes #50487
-
- 04 Jun, 2020 10 commits
-
-
Jonah Williams authored
Make it possible for all FlutterCommands to be global free, by moving instantiation to inside the Zone context. Additionally, provide VerboseLogger and NotifyLogger (daemon) at the top level and remove from command-specific overrides. This allows removing a work around where web devices needed to look up directly from the context in non-test code. Technically the output preferences are still zone injected, but these will be moved soon as they were not being used correctly by the top level command (the injection comes after ArgParser reads the overflow values, causing numerous wrap issues)
-
Jonah Williams authored
This reverts commit bbe18f75.
-
Jonah Williams authored
Work towards removal of package:archive and ideally more stable unzipping of artifacts. These commands are available in Powershell 5+, which we already require for windows.
-
Jonah Williams authored
use -f to overwrite local tags on master branch
-
Jonah Williams authored
-
Jonah Williams authored
* [flutter_tools] only copy cached dill after startup * shared code * cleanup artifact directory * do not copy if dillOutputPath is given
-
Jenn Magder authored
-
Jonah Williams authored
Also combines experiments into extraGenSnapshot/ExtraFrontEndOptions. Allows providing --no-sound-null-safety to allow out of order migration and running.
-
Jenn Magder authored
-
Jenn Magder authored
-
- 03 Jun, 2020 2 commits
-
-
JustWe authored
-
Jonah Williams authored
The linked error has been fixed, removed work around. Updates the test cases to only test for exit instead of error message #33050
-