Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
d0abf7f9
Unverified
Commit
d0abf7f9
authored
Jun 05, 2020
by
Jonah Williams
Committed by
GitHub
Jun 05, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] don't use verbose when in doctor or help command (#58798)
parent
2adf0183
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
25 additions
and
11 deletions
+25
-11
executable.dart
packages/flutter_tools/lib/executable.dart
+1
-1
command_output_test.dart
...ter_tools/test/integration.shard/command_output_test.dart
+24
-10
No files found.
packages/flutter_tools/lib/executable.dart
View file @
d0abf7f9
...
...
@@ -126,7 +126,7 @@ Future<void> main(List<String> args) async {
TemplateRenderer:
()
=>
const
MustacheTemplateRenderer
(),
if
(
daemon
)
Logger:
()
=>
NotifyingLogger
(
verbose:
verbose
)
else
if
(
verbose
)
else
if
(
verbose
&&
!
muteCommandLogging
)
Logger:
()
=>
VerboseLogger
(
StdoutLogger
(
timeoutConfiguration:
timeoutConfiguration
,
stdio:
globals
.
stdio
,
...
...
packages/flutter_tools/test/integration.shard/command_output_test.dart
View file @
d0abf7f9
...
...
@@ -9,16 +9,30 @@ import 'package:process/process.dart';
import
'../src/common.dart'
;
void
main
(
)
{
test
(
'All development tools are hidden'
,
()
async
{
final
String
flutterBin
=
globals
.
fs
.
path
.
join
(
getFlutterRoot
(),
'bin'
,
'flutter'
);
final
ProcessResult
result
=
await
const
LocalProcessManager
().
run
(<
String
>[
flutterBin
,
'-h'
,
'-v'
,
]);
test
(
'All development tools are hidden
and help text is not verbose
'
,
()
async
{
final
String
flutterBin
=
globals
.
fs
.
path
.
join
(
getFlutterRoot
(),
'bin'
,
'flutter'
);
final
ProcessResult
result
=
await
const
LocalProcessManager
().
run
(<
String
>[
flutterBin
,
'-h'
,
'-v'
,
]);
expect
(
result
.
stdout
,
isNot
(
contains
(
'ide-config'
)));
expect
(
result
.
stdout
,
isNot
(
contains
(
'update-packages'
)));
expect
(
result
.
stdout
,
isNot
(
contains
(
'inject-plugins'
)));
expect
(
result
.
stdout
,
isNot
(
contains
(
'ide-config'
)));
expect
(
result
.
stdout
,
isNot
(
contains
(
'update-packages'
)));
expect
(
result
.
stdout
,
isNot
(
contains
(
'inject-plugins'
)));
// Only printed by verbose tool.
expect
(
result
.
stdout
,
isNot
(
contains
(
'exiting with code 0'
)));
});
test
(
'flutter doctor is not verbose'
,
()
async
{
final
String
flutterBin
=
globals
.
fs
.
path
.
join
(
getFlutterRoot
(),
'bin'
,
'flutter'
);
final
ProcessResult
result
=
await
const
LocalProcessManager
().
run
(<
String
>[
flutterBin
,
'doctor'
,
'-v'
,
]);
// Only printed by verbose tool.
expect
(
result
.
stdout
,
isNot
(
contains
(
'exiting with code 0'
)));
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment