Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
64538f4d
Unverified
Commit
64538f4d
authored
Jun 06, 2020
by
Jonah Williams
Committed by
GitHub
Jun 06, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] disable dartdev when calling snapshots directly (#58830)
parent
9dad2d98
Changes
12
Hide whitespace changes
Inline
Side-by-side
Showing
12 changed files
with
21 additions
and
0 deletions
+21
-0
build_runner.dart
...ages/flutter_tools/lib/src/build_runner/build_runner.dart
+1
-0
web_compilation_delegate.dart
..._tools/lib/src/build_runner/web_compilation_delegate.dart
+1
-0
localizations.dart
...ter_tools/lib/src/build_system/targets/localizations.dart
+1
-0
web.dart
packages/flutter_tools/lib/src/build_system/targets/web.dart
+2
-0
compile.dart
packages/flutter_tools/lib/src/compile.dart
+2
-0
analysis.dart
packages/flutter_tools/lib/src/dart/analysis.dart
+1
-0
fuchsia_kernel_compiler.dart
...lutter_tools/lib/src/fuchsia/fuchsia_kernel_compiler.dart
+1
-0
analyze_continuously_test.dart
...st/commands.shard/hermetic/analyze_continuously_test.dart
+1
-0
dart_test.dart
...ls/test/general.shard/build_system/targets/dart_test.dart
+7
-0
localizations_test.dart
...eneral.shard/build_system/targets/localizations_test.dart
+1
-0
web_test.dart
...ols/test/general.shard/build_system/targets/web_test.dart
+1
-0
resident_runner_test.dart
...lutter_tools/test/general.shard/resident_runner_test.dart
+2
-0
No files found.
packages/flutter_tools/lib/src/build_runner/build_runner.dart
View file @
64538f4d
...
...
@@ -119,6 +119,7 @@ class BuildRunner extends CodeGenerator {
final
File
buildScript
=
globals
.
fs
.
file
(
generateResult
.
stdout
.
trim
());
final
ProcessResult
result
=
await
globals
.
processManager
.
run
(<
String
>[
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
'--snapshot=
${buildSnapshot.path}
'
,
'--snapshot-kind=app-jit'
,
'--packages=
${globals.fs.path.join(generatedDirectory.path, '.packages')}
'
,
...
...
packages/flutter_tools/lib/src/build_runner/web_compilation_delegate.dart
View file @
64538f4d
...
...
@@ -220,6 +220,7 @@ class BuildDaemonCreator {
// STDIO.
final
List
<
String
>
args
=
<
String
>[
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
'--packages=
$buildScriptPackages
'
,
buildScript
,
'daemon'
,
...
...
packages/flutter_tools/lib/src/build_system/targets/localizations.dart
View file @
64538f4d
...
...
@@ -38,6 +38,7 @@ Future<void> generateLocalizations({
);
final
ProcessResult
result
=
await
processManager
.
run
(<
String
>[
dartBinaryPath
,
'--disable-dart-dev'
,
genL10nPath
,
'--gen-inputs-and-outputs-list=
${dependenciesDir.path}
'
,
if
(
options
.
arbDirectory
!=
null
)
...
...
packages/flutter_tools/lib/src/build_system/targets/web.dart
View file @
64538f4d
...
...
@@ -166,6 +166,7 @@ class Dart2JSTarget extends Target {
// parse the kernel file for web builds.
final
ProcessResult
kernelResult
=
await
globals
.
processManager
.
run
(<
String
>[
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
dart2jsSnapshot
),
'--libraries-spec=
$specPath
'
,
...?
extraFrontEndOptions
,
...
...
@@ -186,6 +187,7 @@ class Dart2JSTarget extends Target {
}
final
ProcessResult
javaScriptResult
=
await
globals
.
processManager
.
run
(<
String
>[
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
dart2jsSnapshot
),
'--libraries-spec=
$specPath
'
,
...?
extraFrontEndOptions
,
...
...
packages/flutter_tools/lib/src/compile.dart
View file @
64538f4d
...
...
@@ -226,6 +226,7 @@ class KernelCompiler {
}
final
List
<
String
>
command
=
<
String
>[
engineDartPath
,
'--disable-dart-dev'
,
frontendServer
,
'--sdk-root'
,
sdkRoot
,
...
...
@@ -627,6 +628,7 @@ class DefaultResidentCompiler implements ResidentCompiler {
);
final
List
<
String
>
command
=
<
String
>[
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
frontendServer
,
'--sdk-root'
,
sdkRoot
,
...
...
packages/flutter_tools/lib/src/dart/analysis.dart
View file @
64538f4d
...
...
@@ -60,6 +60,7 @@ class AnalysisServer {
);
final
List
<
String
>
command
=
<
String
>[
_fileSystem
.
path
.
join
(
sdkPath
,
'bin'
,
'dart'
),
'--disable-dart-dev'
,
snapshot
,
for
(
String
experiment
in
_experiments
)
...<
String
>[
...
...
packages/flutter_tools/lib/src/fuchsia/fuchsia_kernel_compiler.dart
View file @
64538f4d
...
...
@@ -65,6 +65,7 @@ class FuchsiaKernelCompiler {
final
List
<
String
>
command
=
<
String
>[
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
kernelCompiler
,
...
flags
,
];
...
...
packages/flutter_tools/test/commands.shard/hermetic/analyze_continuously_test.dart
View file @
64538f4d
...
...
@@ -159,6 +159,7 @@ void main() {
final
FakeCommand
fakeCommand
=
FakeCommand
(
command:
const
<
String
>[
'dart-sdk/bin/dart'
,
'--disable-dart-dev'
,
'dart-sdk/bin/snapshots/analysis_server.dart.snapshot'
,
'--enable-experiment'
,
'non-nullable'
,
...
...
packages/flutter_tools/test/general.shard/build_system/targets/dart_test.dart
View file @
64538f4d
...
...
@@ -86,6 +86,7 @@ void main() {
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
FakeCommand
(
command:
<
String
>[
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
artifacts
.
getArtifactPath
(
Artifact
.
frontendServerSnapshotForEngineDartSdk
),
'--sdk-root'
,
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
)
+
'/'
,
...
...
@@ -115,6 +116,7 @@ void main() {
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
FakeCommand
(
command:
<
String
>[
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
artifacts
.
getArtifactPath
(
Artifact
.
frontendServerSnapshotForEngineDartSdk
),
'--sdk-root'
,
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
)
+
'/'
,
...
...
@@ -144,6 +146,7 @@ void main() {
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
FakeCommand
(
command:
<
String
>[
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
artifacts
.
getArtifactPath
(
Artifact
.
frontendServerSnapshotForEngineDartSdk
),
'--sdk-root'
,
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
)
+
'/'
,
...
...
@@ -174,6 +177,7 @@ void main() {
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
FakeCommand
(
command:
<
String
>[
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
artifacts
.
getArtifactPath
(
Artifact
.
frontendServerSnapshotForEngineDartSdk
),
'--sdk-root'
,
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
)
+
'/'
,
...
...
@@ -206,6 +210,7 @@ void main() {
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
FakeCommand
(
command:
<
String
>[
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
artifacts
.
getArtifactPath
(
Artifact
.
frontendServerSnapshotForEngineDartSdk
),
'--sdk-root'
,
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
)
+
'/'
,
...
...
@@ -236,6 +241,7 @@ void main() {
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
FakeCommand
(
command:
<
String
>[
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
artifacts
.
getArtifactPath
(
Artifact
.
frontendServerSnapshotForEngineDartSdk
),
'--sdk-root'
,
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
)
+
'/'
,
...
...
@@ -278,6 +284,7 @@ void main() {
processManager
=
FakeProcessManager
.
list
(<
FakeCommand
>[
FakeCommand
(
command:
<
String
>[
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
artifacts
.
getArtifactPath
(
Artifact
.
frontendServerSnapshotForEngineDartSdk
),
'--sdk-root'
,
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
)
+
'/'
,
...
...
packages/flutter_tools/test/general.shard/build_system/targets/localizations_test.dart
View file @
64538f4d
...
...
@@ -21,6 +21,7 @@ void main() {
const
FakeCommand
(
command:
<
String
>[
'dart'
,
'--disable-dart-dev'
,
'dev/tools/localization/bin/gen_l10n.dart'
,
'--gen-inputs-and-outputs-list=/'
,
'--arb-dir=arb'
,
...
...
packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart
View file @
64538f4d
...
...
@@ -23,6 +23,7 @@ import '../../../src/testbed.dart';
const
List
<
String
>
kDart2jsLinuxArgs
=
<
String
>[
'bin/cache/dart-sdk/bin/dart'
,
'--disable-dart-dev'
,
'bin/cache/dart-sdk/bin/snapshots/dart2js.dart.snapshot'
,
'--libraries-spec=bin/cache/flutter_web_sdk/libraries.json'
,
];
...
...
packages/flutter_tools/test/general.shard/resident_runner_test.dart
View file @
64538f4d
...
...
@@ -623,6 +623,7 @@ void main() {
processManager
.
addCommand
(
FakeCommand
(
command:
<
String
>[
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
globals
.
fs
.
path
.
join
(
Cache
.
flutterRoot
,
'dev'
,
'tools'
,
'localization'
,
'bin'
,
'gen_l10n.dart'
),
'--gen-inputs-and-outputs-list=
${dependencies.absolute.path}
'
,
],
...
...
@@ -651,6 +652,7 @@ void main() {
processManager
.
addCommand
(
FakeCommand
(
command:
<
String
>[
globals
.
artifacts
.
getArtifactPath
(
Artifact
.
engineDartBinary
),
'--disable-dart-dev'
,
globals
.
fs
.
path
.
join
(
Cache
.
flutterRoot
,
'dev'
,
'tools'
,
'localization'
,
'bin'
,
'gen_l10n.dart'
),
'--gen-inputs-and-outputs-list=
${dependencies.absolute.path}
'
,
],
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment