1. 20 May, 2016 2 commits
  2. 19 May, 2016 1 commit
    • Adam Barth's avatar
      Tabs and scrolling has odd card text (#4019) · 8283d05e
      Adam Barth authored
      Looks like our intent here was to show the tab label rather than
      "Instance of '_Page'".
      
      Also, fix an issue where the scrollableKey wasn't being forwarded to the
      actual scrollable.
      
      Fixes #3090
      8283d05e
  3. 17 May, 2016 2 commits
  4. 16 May, 2016 3 commits
    • Ian Hickson's avatar
      Make it possible to run tests live on a device (#3936) · 32527017
      Ian Hickson authored
      This makes it possible to substitute 'flutter run' for 'flutter test'
      and actually watch a test run on a device.
      
      For any test that depends on flutter_test:
      
      1. Remove any import of 'package:test/test.dart'.
      
      2. Replace `testWidgets('...', (WidgetTester tester) {`
            with `testWidgets('...', (WidgetTester tester) async {`
      
      3. Add an "await" in front of calls to any of the following:
          * tap()
          * tapAt()
          * fling()
          * flingFrom()
          * scroll()
          * scrollAt()
          * pump()
          * pumpWidget()
      
      4. Replace any calls to `tester.flushMicrotasks()` with calls to
         `await tester.idle()`.
      
      There's a guarding API that you can use, if you have particularly
      complicated tests, to get better error messages. Search for
      TestAsyncUtils.
      32527017
    • Ian Hickson's avatar
      Revert "Rename DefaultTextStyle constructor to explicit (#3920)" (#3930) · c5ff156f
      Ian Hickson authored
      This reverts commit 55f9145e.
      
      Turns out that this commit breaks apps that use the material library,
      because of the _errorTextStyle DefaultTextStyle which has inherit:true.
      Just setting it to false doesn't work, unfortunately, because then you
      hit some sort of issue with merging that text style with others that
      have inherit:true.
      c5ff156f
    • Adam Barth's avatar
      Rename DefaultTextStyle constructor to explicit (#3920) · 55f9145e
      Adam Barth authored
      To make it clear that this constructor requires an explicit style. Also
      throw a descriptive error recommending the inherit constructor for
      styles with the inherit bit set.
      
      Fixes #3842
      55f9145e
  5. 13 May, 2016 3 commits
  6. 12 May, 2016 4 commits
  7. 11 May, 2016 1 commit
  8. 10 May, 2016 3 commits
  9. 09 May, 2016 3 commits
  10. 07 May, 2016 1 commit
    • Adam Barth's avatar
      Move TextAlign out of TextStyle (#3789) · ee903af0
      Adam Barth authored
      TextAlign applies to a whole paragraph instead of applying to an individual
      text span. This patch moves the property out of TextStyle and into a separate
      property on Text and RichText.
      ee903af0
  11. 06 May, 2016 1 commit
  12. 05 May, 2016 1 commit
    • krisgiesing's avatar
      Move global analysis options file to the repo root (#3750) · 01978d98
      krisgiesing authored
      * Move global analysis options file to the repo root
      
      Also restore the analysis options file for stocks example, since
      the global options trigger warnings on generated intl files.
      
      * Remove obsolete analysis options file for Material Gallery example
      01978d98
  13. 04 May, 2016 5 commits
  14. 29 Apr, 2016 3 commits
    • Adam Barth's avatar
      Fix the padding and space for FlatButton and RaisedButton (#3650) · b2fa6c25
      Adam Barth authored
      Instead of incorporating the margin into the button, introduce a ButtonBar
      widget that supplies the proper spacing between the buttons. Also, make these
      buttons more configurable via ButtonTheme so that dialogs can change the
      minWidth and padding of the buttons as required by the spec.
      
      Fixes #1843
      Fixes #3184
      b2fa6c25
    • Ian Hickson's avatar
      Refactor the test framework (#3622) · 91dd9699
      Ian Hickson authored
      * Refactor widget test framework
      
      Instead of:
      
      ```dart
        test("Card Collection smoke test", () {
          testWidgets((WidgetTester tester) {
      ```
      
      ...you now say:
      
      ```dart
        testWidgets("Card Collection smoke test", (WidgetTester tester) {
      ```
      
      Instead of:
      
      ```dart
        expect(tester, hasWidget(find.text('hello')));
      ```
      
      ...you now say:
      
      ```dart
        expect(find.text('hello'), findsOneWidget);
      ```
      
      Instead of the previous API (exists, widgets, widget, stateOf,
      elementOf, etc), you now have the following comprehensive API. All these
      are functions that take a Finder, except the all* properties.
      
      * `any()` - true if anything matches, c.f. `Iterable.any`
      * `allWidgets` - all the widgets in the tree
      * `widget()` - the one and only widget that matches the finder
      * `firstWidget()` - the first widget that matches the finder
      * `allElements` - all the elements in the tree
      * `element()` - the one and only element that matches the finder
      * `firstElement()` - the first element that matches the finder
      * `allStates` - all the `State`s in the tree
      * `state()` - the one and only state that matches the finder
      * `firstState()` - the first state that matches the finder
      * `allRenderObjects` - all the render objects in the tree
      * `renderObject()` - the one and only render object that matches the finder
      * `firstRenderObject()` - the first render object that matches the finder
      
      There's also `layers' which returns the list of current layers.
      
      `tap`, `fling`, getCenter, getSize, etc, take Finders, like the APIs
      above, and expect there to only be one matching widget.
      
      The finders are:
      
       * `find.text(String text)`
       * `find.widgetWithText(Type widgetType, String text)`
       * `find.byKey(Key key)`
       * `find.byType(Type type)`
       * `find.byElementType(Type type)`
       * `find.byConfig(Widget config)`
       * `find.byWidgetPredicate(WidgetPredicate predicate)`
       * `find.byElementPredicate(ElementPredicate predicate)`
      
      The matchers (for `expect`) are:
      
       * `findsNothing`
       * `findsWidgets`
       * `findsOneWidget`
       * `findsNWidgets(n)`
       * `isOnStage`
       * `isOffStage`
       * `isInCard`
       * `isNotInCard`
      
      Benchmarks now use benchmarkWidgets instead of testWidgets.
      
      Also, for those of you using mockers, `serviceMocker` now automatically
      handles the binding initialization.
      
      This patch also:
      
      * changes how tests are run so that we can more easily swap the logic
        out for a "real" mode instead of FakeAsync.
      
      * introduces CachingIterable.
      
      * changes how flutter_driver interacts with the widget tree to use the
        aforementioned new API rather than ElementTreeTester, which is gone.
      
      * removes ElementTreeTester.
      
      * changes the semantics of a test for scrollables because we couldn't
        convince ourselves that the old semantics made sense; it only worked
        before because flushing the microtasks after every event was broken.
      
      * fixes the flushing of microtasks after every event.
      
      * Reindent the tests
      
      * Fix review comments
      91dd9699
    • Adam Barth's avatar
      Update engine (#3637) · 5497ba18
      Adam Barth authored
      Turns out there were more clients of the old paragraph API than I expected.
      This patch migrates them to the new API.
      5497ba18
  15. 28 Apr, 2016 2 commits
  16. 27 Apr, 2016 3 commits
  17. 22 Apr, 2016 2 commits