Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
256adfcd
Commit
256adfcd
authored
Apr 27, 2016
by
Ian Hickson
Committed by
Adam Barth
Apr 27, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix leaking animation in floating action button. (#3575)
parent
0f1dbe09
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
17 additions
and
8 deletions
+17
-8
locale_test.dart
examples/stocks/test/locale_test.dart
+0
-4
floating_action_button.dart
...ages/flutter/lib/src/material/floating_action_button.dart
+6
-0
binding.dart
packages/flutter/lib/src/scheduler/binding.dart
+11
-4
No files found.
examples/stocks/test/locale_test.dart
View file @
256adfcd
...
...
@@ -20,10 +20,6 @@ void main() {
tester
.
setLocale
(
"es"
,
"US"
);
tester
.
pump
();
expect
(
tester
,
hasWidget
(
find
.
text
(
'MERCADO'
)));
// TODO(abarth): We're leaking an animation. We should track down the leak
// and plug it rather than waiting for the animation to end here.
tester
.
pump
(
const
Duration
(
seconds:
1
));
});
});
}
packages/flutter/lib/src/material/floating_action_button.dart
View file @
256adfcd
...
...
@@ -109,6 +109,12 @@ class _FloatingActionButtonState extends State<FloatingActionButton> {
));
}
@override
void
dispose
()
{
_childSegueController
.
dispose
();
super
.
dispose
();
}
@override
void
didUpdateConfig
(
FloatingActionButton
oldConfig
)
{
super
.
didUpdateConfig
(
oldConfig
);
...
...
packages/flutter/lib/src/scheduler/binding.dart
View file @
256adfcd
...
...
@@ -250,10 +250,17 @@ abstract class SchedulerBinding extends BindingBase {
exception:
reason
,
library
:
'scheduler library'
,
informationCollector:
(
StringBuffer
information
)
{
information
.
writeln
(
'There
${ transientCallbackCount == 1 ? "was one transient callback" : "were $transientCallbackCount transient callbacks" }
'
'left. The stack traces for when they were registered are as follows:'
);
if
(
transientCallbackCount
==
1
)
{
information
.
writeln
(
'There was one transient callback left. '
'The stack traces for when it was registered is as follows:'
);
}
else
{
information
.
writeln
(
'There were
$transientCallbackCount
transient callbacks left. '
'The stack traces for when they were registered are as follows:'
);
}
for
(
int
id
in
_transientCallbacks
.
keys
)
{
_FrameCallbackEntry
entry
=
_transientCallbacks
[
id
];
information
.
writeln
(
'-- callback
$id
--'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment