Commits · 3538e4c788e106b76649f99758c39ebafa03b8ea · abdullh.alsoleman / Front-End

20 Feb, 2024 14 commits

Changing `TextPainter.getOffsetForCaret` implementation to remove the logarithmic search (#143281) · 3538e4c7

LongCatIsLooong authored Feb 20, 2024

The behavior largely remains the same, except:

1. The EOT cursor `(textLength, downstream)` for text ending in the opposite writing direction as the paragraph is now placed at the visual end of the last line. 
  For example, in a LTR paragraph, the EOT cursor for `aA` (lowercase for LTR and uppercase for RTL) is placed to the right of the line: `aA|` (it was `a|A` before). 
  This matches the behavior of most applications that do logical order arrow key navigation instead of visual order navigation. 
  And it makes the navigation order consistent for `aA\naA`:
```
  |aA    =>  aA|  => aA|  => aA  => aA   => aA 
   aA        aA      aA     |aA     aA|     aA|     
   (1)       (2)     (3)    (4)    (5)      (6)
```
This is indeed still pretty confusing as (2) and (3), as well as (5) and (6) are hard to distinguish (when the I beam has a large width they are actually visually distinguishable -- they use the same anchor but one gets painted to the left and the other to the right. I noticed that emacs does the same). 
But logical order navigation will always be confusing in bidi text, in one way or another.

Interestingly there are 3 different behaviors I've observed in chrome:
- the chrome download dialog (which I think uses GTK text widgets but not sure which version) gives me 2 cursors when navigating bidi text, and 
- its HTML fields only show one, and presumably they place the I beam at the **trailing edge** of the character (which makes more sense for backspacing I guess). 
- On the other hand, its (new) omnibar seems to use visual order arrow navigation

Side note: we may need to update the "tap to place the caret here" logic to handle the case where the tap lands outside of the text and the text ends in the opposite writing direction. 

2. Removed the logarithmic search. The same could be done using the characters package but when glyphInfo tells you about the baseline location in the future we probably don't need the `getBoxesForRange` call. This should fix https://github.com/flutter/flutter/issues/123424.

## Internal Tests

This is going to change the image output of some internal golden tests. I'm planning to merge https://github.com/flutter/flutter/pull/143281 before this to avoid updating the same golden files twice for invalid selections.

3538e4c7

Delete local.properties that shouldn't have been pushed (#143774) · 3ae71f5c

Gray Mackall authored Feb 20, 2024

This file shouldn't be in version control

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/ChatCo-authored-by: Gray Mackall <mackall@google.com>

3ae71f5c

Clean leaks. (#142818) · 39befd81
Polina Cherkasova authored Feb 20, 2024

39befd81

Introduce tone-based surfaces and accent color add-ons - Part 2 (#138521) · a2c7ed95

Qun Cheng authored Feb 20, 2024

This PR is to introduce 19 new color roles and deprecate 3 color roles in `ColorScheme`.
**Tone-based surface colors** (7 colors): 
* surfaceBright
* surfaceDim
* surfaceContainer
* surfaceContainerLowest
* surfaceContainerLow
* surfaceContainerHigh
* surfaceContainerHighest

**Accent color add-ons** (12 colors):
* primary/secondary/tertiary-Fixed
* primary/secondary/tertiary-FixedDim
* onPrimary/onSecondary/onTertiary-Fixed
* onPrimary/onSecondary/onTertiary-FixedVariant

**Deprecated colors**:
* background -> replaced with surface
* onBackground -> replaced with onSurface
* surfaceVariant -> replaced with surfaceContainerHighest

Please checkout this [design doc](https://docs.google.com/document/d/1ODqivpM_6c490T4j5XIiWCDKo5YqHy78YEFqDm4S8h4/edit?usp=sharing) for more information:)

![Screenshot 2024-01-08 at 4 56 51â¯PM](https://github.com/flutter/flutter/assets/36861262/353cdb4c-6ba9-4435-a518-fd3f67e415f0)

a2c7ed95

Explain when and why to use CrossAxisAlignment.baseline (#143632) · eacf0f9e

Greg Price authored Feb 20, 2024

Improves the docs around horizontal alignment of text, due to several issues expressing confusion about this topic.

eacf0f9e

Roll Flutter Engine from a41da3701923 to e16a260265ad (2 revisions) (#143763) · 718c8170

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/a41da3701923...e16a260265ad

2024-02-20 737941+loic-sharma@users.noreply.github.com [Windows] Make the engine create the view (flutter/engine#50673)
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from 2f9bb1517740 to 2dc00a705f1c (2 revisions) (flutter/engine#50782)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

718c8170

Handle FormatException from SkiaGoldClient (#143755) · 8a8616f9

Zachary Anderson authored Feb 20, 2024

Seen in
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Framework%20Smoke%20Tests/17183/overview
closing the engine tree.

8a8616f9

Roll Packages from 84ff11d7ee5a to 8bba41b0c046 (2 revisions) (#143757) · 6200026a

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/packages/compare/84ff11d7ee5a...8bba41b0c046

2024-02-20 engine-flutter-autoroll@skia.org Roll Flutter from 064c340b to 5129806e (9 revisions) (flutter/packages#6164)
2024-02-20 stuartmorgan@google.com [flutter_markdown] Replace deprecated API (flutter/packages#6134)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6200026a

Roll Flutter Engine from 781f308c6555 to a41da3701923 (1 revision) (#143756) · 096c917e

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/781f308c6555...a41da3701923

2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from a76b083ac4cc to 2f9bb1517740 (1 revision) (flutter/engine#50781)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

096c917e

Roll Flutter Engine from 0abe2b9d6c7c to 781f308c6555 (1 revision) (#143750) · 5129806e

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/0abe2b9d6c7c...781f308c6555

2024-02-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 8bb8ff24aea3 to f344e2266468 (1 revision) (flutter/engine#50780)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5129806e

Roll Flutter Engine from 92aad0d0fcee to 0abe2b9d6c7c (1 revision) (#143745) · 1a7a0618

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/92aad0d0fcee...0abe2b9d6c7c

2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from d448ca514a56 to a76b083ac4cc (1 revision) (flutter/engine#50778)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1a7a0618

Roll Flutter Engine from 2335115f08d3 to 92aad0d0fcee (2 revisions) (#143736) · c56d4d11

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/2335115f08d3...92aad0d0fcee

2024-02-20 skia-flutter-autoroll@skia.org Roll Dart SDK from 475e710429ee to 8bb8ff24aea3 (1 revision) (flutter/engine#50775)
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from ff602d384586 to d448ca514a56 (4 revisions) (flutter/engine#50776)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c56d4d11

Roll Flutter Engine from e96c18b6c5ee to 2335115f08d3 (1 revision) (#143731) · dd244747

engine-flutter-autoroll authored Feb 20, 2024

https://github.com/flutter/engine/compare/e96c18b6c5ee...2335115f08d3

2024-02-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HFmcvzkR3TYeHa_0U... to gKg6HlBeR52y-cMhu... (flutter/engine#50771)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from HFmcvzkR3TYe to gKg6HlBeR52y

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dd244747

Small fixes in TextEditingController docs (#143717) · 2d422a32

Greg Price authored Feb 20, 2024

This follows up on #143452, to slightly further address #95978.

The double- rather than triple-slash on the blank line caused it to be ignored by dartdoc, so that the two paragraphs it's intended to separate were getting joined as one paragraph instead.

Also expand this constructor's summary line slightly to mention its distinctive feature compared with the other constructor, and make other small fixes that I noticed in other docs on this class.

2d422a32

19 Feb, 2024 8 commits

Roll Flutter Engine from b41494f009f4 to e96c18b6c5ee (1 revision) (#143722) · f2eea969

engine-flutter-autoroll authored Feb 19, 2024

https://github.com/flutter/engine/compare/b41494f009f4...e96c18b6c5ee

2024-02-19 flar@google.com [Impeller] Run stroke benchmarks on unclosed paths (flutter/engine#50765)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f2eea969

Roll Flutter Engine from 714215d42e57 to b41494f009f4 (1 revision) (#143713) · 3b5b462a

engine-flutter-autoroll authored Feb 19, 2024

https://github.com/flutter/engine/compare/714215d42e57...b41494f009f4

2024-02-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 6d659f880394 to 475e710429ee (1 revision) (flutter/engine#50763)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b5b462a

Reland (2): "Fix how Gradle resolves Android plugin" (#142498) · 9620e3f6
Gustl22 authored Feb 19, 2024
```
Previous PR: #137115, 
Revert: #142464
Fixes #141940
Closes #142487
```
9620e3f6

Roll Packages from 0af905d779d5 to 84ff11d7ee5a (1 revision) (#143710) · 05daee3d

engine-flutter-autoroll authored Feb 19, 2024

https://github.com/flutter/packages/compare/0af905d779d5...84ff11d7ee5a

2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter from d7867ca7 to 064c340b (33 revisions) (flutter/packages#6161)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

05daee3d

Roll Flutter Engine from f71b7eee2266 to 714215d42e57 (1 revision) (#143708) · 064c340b

engine-flutter-autoroll authored Feb 19, 2024

https://github.com/flutter/engine/compare/f71b7eee2266...714215d42e57

2024-02-19 skia-flutter-autoroll@skia.org Roll Skia from 6eaa7cf6d013 to ff602d384586 (1 revision) (flutter/engine#50762)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

064c340b

Roll Flutter Engine from 07c73b0c8413 to f71b7eee2266 (2 revisions) (#143694) · d2e7414a

engine-flutter-autoroll authored Feb 19, 2024

https://github.com/flutter/engine/compare/07c73b0c8413...f71b7eee2266

2024-02-19 tessertaha@gmail.com Revert "Fix iOS password autofill prompt dismissal causes layout to resize (#50364)" (flutter/engine#50760)
2024-02-19 skia-flutter-autoroll@skia.org Roll Skia from a4ff02094bbd to 6eaa7cf6d013 (4 revisions) (flutter/engine#50759)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d2e7414a

Roll Flutter Engine from 80d6745c6fd6 to 07c73b0c8413 (1 revision) (#143682) · 74e054f0

engine-flutter-autoroll authored Feb 19, 2024

https://github.com/flutter/engine/compare/80d6745c6fd6...07c73b0c8413

2024-02-19 skia-flutter-autoroll@skia.org Roll Skia from b0680ba29971 to a4ff02094bbd (1 revision) (flutter/engine#50756)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

74e054f0

Roll Flutter Engine from 67abf6eb36a1 to 80d6745c6fd6 (1 revision) (#143676) · 4c8e30cc

engine-flutter-autoroll authored Feb 19, 2024

https://github.com/flutter/engine/compare/67abf6eb36a1...80d6745c6fd6

2024-02-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uSZ0te7RWVq4IFpjb... to HFmcvzkR3TYeHa_0U... (flutter/engine#50752)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uSZ0te7RWVq4 to HFmcvzkR3TYe

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4c8e30cc

18 Feb, 2024 5 commits

Roll Flutter Engine from 8ae232196fc9 to 67abf6eb36a1 (1 revision) (#143673) · 043facce

engine-flutter-autoroll authored Feb 18, 2024

https://github.com/flutter/engine/compare/8ae232196fc9...67abf6eb36a1

2024-02-18 matanlurey@users.noreply.github.com Write `adb logcat` results and screenshots to `FLUTTER_LOGS_DIR` if able. (flutter/engine#50722)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

043facce

Roll Flutter Engine from f636f9635438 to 8ae232196fc9 (1 revision) (#143659) · 3578e75e

engine-flutter-autoroll authored Feb 18, 2024

https://github.com/flutter/engine/compare/f636f9635438...8ae232196fc9

2024-02-18 skia-flutter-autoroll@skia.org Roll Skia from 0d2dbf53aef6 to b0680ba29971 (1 revision) (flutter/engine#50748)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3578e75e

Fixed the issue of incorrect item position when prototypeItem is set in... · bce848eb

yim authored Feb 18, 2024

Fixed the issue of incorrect item position when prototypeItem is set in SliverReorderableList. (#142880)

Fixes #142708

bce848eb

ShowCaretOnScreen is correctly scheduled within a SliverMainAxisGroup (#141671) · 73c26a1c
yim authored Feb 18, 2024
```
Fixes #141577 
Fixes #135407
```
73c26a1c

Roll Flutter Engine from 0ebd580cb8a7 to f636f9635438 (1 revision) (#143657) · deaf53ef

engine-flutter-autoroll authored Feb 18, 2024

https://github.com/flutter/engine/compare/0ebd580cb8a7...f636f9635438

2024-02-17 bdero@google.com [Impeller] Fix golden flake due to rand use. (flutter/engine#50743)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

deaf53ef

17 Feb, 2024 12 commits

Roll Flutter Engine from c807aeaab89c to 0ebd580cb8a7 (1 revision) (#143655) · fe4ab13c

engine-flutter-autoroll authored Feb 17, 2024

https://github.com/flutter/engine/compare/c807aeaab89c...0ebd580cb8a7

2024-02-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YN5KCfom7Ax0Z69s_... to uSZ0te7RWVq4IFpjb... (flutter/engine#50746)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YN5KCfom7Ax0 to uSZ0te7RWVq4

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fe4ab13c

Roll Flutter Engine from e51d4f1e285a to c807aeaab89c (4 revisions) (#143652) · b9030461

engine-flutter-autoroll authored Feb 17, 2024

https://github.com/flutter/engine/compare/e51d4f1e285a...c807aeaab89c

2024-02-17 skia-flutter-autoroll@skia.org Roll Skia from bb61c2b4614e to 0d2dbf53aef6 (3 revisions) (flutter/engine#50744)
2024-02-17 jonahwilliams@google.com [Impeller] add additional setup method that caches more pipelines, warms internal shader code (flutter/engine#50521)
2024-02-17 bdero@google.com [Impeller] Assign subpass depth on restore rather than creation. (flutter/engine#50626)
2024-02-17 skia-flutter-autoroll@skia.org Roll Dart SDK from fa66195a3814 to 6d659f880394 (1 revision) (flutter/engine#50739)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b9030461

Manual roll Packages from c56c12dd51ef to 0af905d779d5 (#143651) · 2d48ab75

Jason Simmons authored Feb 17, 2024

0af905d77 [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152)
f865bafd8 Raise gradle wrapper version of legacy project (flutter/packages#6132)
b4d8ad719 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142)
cc34b78a0 [ci/various] Update for 3.19 stable (flutter/packages#6147)
10a8b76ad Roll Flutter (stable) from 41456452f29d to bae5e49bc2a8 (1550 revisions) (flutter/packages#6145)
a36071b5e Roll Flutter from a628814e to d7867ca7 (66 revisions) (flutter/packages#6146)

2d48ab75

Add an override annotation to the lineTerminator setter in the MemoryStdout fake class (#143646) · 80364887
Jason Simmons authored Feb 17, 2024
```
This is required by a new API recently added to Dart.

See https://github.com/flutter/flutter/issues/143614
```
80364887

InputDecorator M3 tests migration - Step3 (#143520) · 8a5efa53

Bruno Leroux authored Feb 17, 2024

## Description

This PR is the third step for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369

This PR moves some tests out of the 'Material2' group (the ones that are ok on M3).
@justinmc The diff is almost unreadable, I moved the tests as carefully as possible and I checked that before and after the number of tests is exactly the same. 

## Related Issue

Related to https://github.com/flutter/flutter/issues/139076

## Tests

Move some tests from 'Material2' group to main().

8a5efa53

Update InputDecoration.contentPadding documentation (#143519) · 13ed551e

Bruno Leroux authored Feb 17, 2024

## Description

This PR updates the `InputDecoration.contentPadding` documentation to detail both Material 3 and Material 2 default values.

## Related Issue

Follow-up to https://github.com/flutter/flutter/pull/142981.

## Tests

Documentation only.

13ed551e

[Impeller] skip selectable text goldens for instability. (#143627) · ae1488cf

Jonah Williams authored Feb 17, 2024

Similar to other issues, appears that text goldens are really unstable with Impeller.

Part of https://github.com/flutter/flutter/issues/143616

ae1488cf

Roll Flutter Engine from 2ed159a786ef to e51d4f1e285a (2 revisions) (#143624) · 789acb32

engine-flutter-autoroll authored Feb 17, 2024

https://github.com/flutter/engine/compare/2ed159a786ef...e51d4f1e285a

2024-02-17 robert.ancell@canonical.com Connect signals in swapped form. (flutter/engine#50705)
2024-02-17 jason-simmons@users.noreply.github.com Restore use of the API 34 device in the Firebase Test Lab script and handle FTL infrastructure errors in the script (flutter/engine#50735)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

789acb32

[Impeller] skip perspective transformed text goldens. (#143623) · 4e27f347

Jonah Williams authored Feb 17, 2024

Part of https://github.com/flutter/flutter/issues/143616

The perspective transformed text goldens are super unstable, possibly for the same reason they are in flutter/engine.

4e27f347

[framework] Skip 5 failing framework tests. (#143618) · bb1c7a6c
Jonah Williams authored Feb 17, 2024
```
Part of https://github.com/flutter/flutter/issues/143616
```
bb1c7a6c

Roll Flutter Engine from afb270929a6c to 2ed159a786ef (1 revision) (#143622) · e0f126a4

engine-flutter-autoroll authored Feb 17, 2024

https://github.com/flutter/engine/compare/afb270929a6c...2ed159a786ef

2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from e4e234d412ee to bb61c2b4614e (4 revisions) (flutter/engine#50736)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e0f126a4

Roll Flutter Engine from c4fe6f01e0f5 to afb270929a6c (1 revision) (#143619) · bf1d3dfa

engine-flutter-autoroll authored Feb 17, 2024

https://github.com/flutter/engine/compare/c4fe6f01e0f5...afb270929a6c

2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 6ae5032133d0 to e4e234d412ee (1 revision) (flutter/engine#50733)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bf1d3dfa

16 Feb, 2024 1 commit

Implement `lineTerminator` in `MemoryStdout` Fake (#143608) · e8dcf190

Brian Quinlan authored Feb 16, 2024

https://dart-review.googlesource.com/c/sdk/+/326761/24/sdk/lib/io/stdio.dart#380
added a `lineTerminator` field to `Stdout`.

Add that field to the fake in packages/test.

Fixes https://github.com/flutter/flutter/issues/143614

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

e8dcf190