Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
bb1c7a6c
Unverified
Commit
bb1c7a6c
authored
Feb 17, 2024
by
Jonah Williams
Committed by
GitHub
Feb 17, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[framework] Skip 5 failing framework tests. (#143618)
Part of
https://github.com/flutter/flutter/issues/143616
parent
e0f126a4
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
33 additions
and
9 deletions
+33
-9
impeller_test_helpers.dart
packages/flutter/test/impeller_test_helpers.dart
+19
-0
default_colors_test.dart
packages/flutter/test/widgets/default_colors_test.dart
+5
-3
snapshot_widget_test.dart
packages/flutter/test/widgets/snapshot_widget_test.dart
+3
-1
widget_inspector_test.dart
packages/flutter/test/widgets/widget_inspector_test.dart
+6
-5
No files found.
packages/flutter/test/impeller_test_helpers.dart
0 → 100644
View file @
bb1c7a6c
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'dart:io'
as
io
;
import
'package:flutter/foundation.dart'
;
/// Whether or not Flutter CI has configured Impeller for this test run.
///
/// This is intended only to be used for a migration effort to enable Impeller
/// on Flutter CI.
///
/// See also: https://github.com/flutter/flutter/issues/143616
bool
get
impellerEnabled
{
if
(
kIsWeb
)
{
return
false
;
}
return
io
.
Platform
.
environment
.
containsKey
(
'FLUTTER_TEST_IMPELLER'
);
}
packages/flutter/test/widgets/default_colors_test.dart
View file @
bb1c7a6c
...
...
@@ -8,6 +8,8 @@ import 'dart:ui' as ui;
import
'package:flutter/material.dart'
;
import
'package:flutter_test/flutter_test.dart'
;
import
'../impeller_test_helpers.dart'
;
const
double
_crispText
=
100.0
;
// this font size is selected to avoid needing any antialiasing.
const
String
_expText
=
'Éxp'
;
// renders in the test font as:
...
...
@@ -38,7 +40,7 @@ void main() {
const
Offset
(
799
,
599
):
const
Color
(
0x00000000
),
// the background
},
);
},
skip:
!
canCaptureImage
);
// [intended] Test relies on captureImage, which is not supported on web currently.
},
skip:
!
canCaptureImage
||
impellerEnabled
);
// [intended] Test relies on captureImage, which is not supported on web currently.
testWidgets
(
'Default text color'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
const
ColoredBox
(
...
...
@@ -63,7 +65,7 @@ void main() {
const
Offset
(
799
,
599
):
const
Color
(
0xFFABCDEF
),
// the background
},
);
},
skip:
!
canCaptureImage
);
// [intended] Test relies on captureImage, which is not supported on web currently.
},
skip:
!
canCaptureImage
||
impellerEnabled
);
// [intended] Test relies on captureImage, which is not supported on web currently.
testWidgets
(
'Default text selection color'
,
(
WidgetTester
tester
)
async
{
final
GlobalKey
key
=
GlobalKey
();
...
...
@@ -118,7 +120,7 @@ void main() {
const
Offset
(
799
,
599
):
const
Color
(
0xFFFFFFFF
),
// the background
},
);
},
skip:
!
canCaptureImage
);
// [intended] Test relies on captureImage, which is not supported on web currently.
},
skip:
!
canCaptureImage
||
impellerEnabled
);
// [intended] Test relies on captureImage, which is not supported on web currently.
}
Color
_getPixel
(
ByteData
bytes
,
int
x
,
int
y
,
int
width
)
{
...
...
packages/flutter/test/widgets/snapshot_widget_test.dart
View file @
bb1c7a6c
...
...
@@ -15,6 +15,8 @@ import 'package:flutter/rendering.dart';
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker_flutter_testing/leak_tracker_flutter_testing.dart'
;
import
'../impeller_test_helpers.dart'
;
void
main
(
)
{
testWidgets
(
'SnapshotWidget can rasterize child'
,
(
WidgetTester
tester
)
async
{
final
SnapshotController
controller
=
SnapshotController
(
allowSnapshotting:
true
);
...
...
@@ -325,7 +327,7 @@ void main() {
await
expectLater
(
find
.
byKey
(
repaintBoundaryKey
),
matchesReferenceImage
(
imageWhenDisabled
));
},
skip:
kIsWeb
);
// TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
skip:
kIsWeb
||
impellerEnabled
);
// TODO(jonahwilliams): https://github.com/flutter/flutter/issues/106689
test
(
'SnapshotPainter dispatches memory events'
,
()
async
{
await
expectLater
(
...
...
packages/flutter/test/widgets/widget_inspector_test.dart
View file @
bb1c7a6c
...
...
@@ -21,6 +21,7 @@ import 'package:flutter/rendering.dart';
import
'package:flutter_test/flutter_test.dart'
;
import
'package:leak_tracker/leak_tracker.dart'
;
import
'../impeller_test_helpers.dart'
;
import
'widget_inspector_test_utils.dart'
;
// Start of block of code where widget creation location line numbers and
...
...
@@ -3869,7 +3870,7 @@ class _TestWidgetInspectorService extends TestWidgetInspectorService {
_CreationLocation
location
=
knownLocations
[
id
]!;
expect
(
location
.
file
,
equals
(
file
));
// ClockText widget.
expect
(
location
.
line
,
equals
(
5
6
));
expect
(
location
.
line
,
equals
(
5
7
));
expect
(
location
.
column
,
equals
(
9
));
expect
(
location
.
name
,
equals
(
'ClockText'
));
expect
(
count
,
equals
(
1
));
...
...
@@ -3879,7 +3880,7 @@ class _TestWidgetInspectorService extends TestWidgetInspectorService {
location
=
knownLocations
[
id
]!;
expect
(
location
.
file
,
equals
(
file
));
// Text widget in _ClockTextState build method.
expect
(
location
.
line
,
equals
(
9
4
));
expect
(
location
.
line
,
equals
(
9
5
));
expect
(
location
.
column
,
equals
(
12
));
expect
(
location
.
name
,
equals
(
'Text'
));
expect
(
count
,
equals
(
1
));
...
...
@@ -3906,7 +3907,7 @@ class _TestWidgetInspectorService extends TestWidgetInspectorService {
location
=
knownLocations
[
id
]!;
expect
(
location
.
file
,
equals
(
file
));
// ClockText widget.
expect
(
location
.
line
,
equals
(
5
6
));
expect
(
location
.
line
,
equals
(
5
7
));
expect
(
location
.
column
,
equals
(
9
));
expect
(
location
.
name
,
equals
(
'ClockText'
));
expect
(
count
,
equals
(
3
));
// 3 clock widget instances rebuilt.
...
...
@@ -3916,7 +3917,7 @@ class _TestWidgetInspectorService extends TestWidgetInspectorService {
location
=
knownLocations
[
id
]!;
expect
(
location
.
file
,
equals
(
file
));
// Text widget in _ClockTextState build method.
expect
(
location
.
line
,
equals
(
9
4
));
expect
(
location
.
line
,
equals
(
9
5
));
expect
(
location
.
column
,
equals
(
12
));
expect
(
location
.
name
,
equals
(
'Text'
));
expect
(
count
,
equals
(
3
));
// 3 clock widget instances rebuilt.
...
...
@@ -4551,7 +4552,7 @@ class _TestWidgetInspectorService extends TestWidgetInspectorService {
screenshot12
,
matchesGoldenFile
(
'inspector.sizedBox_debugPaint_margin.png'
),
);
}
);
}
,
skip:
impellerEnabled
);
// TODO(jonahwilliams): https://github.com/flutter/flutter/issues/143616
group
(
'layout explorer'
,
()
{
const
String
group
=
'test-group'
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment