- 20 Feb, 2024 1 commit
-
-
Greg Price authored
This follows up on #143452, to slightly further address #95978. The double- rather than triple-slash on the blank line caused it to be ignored by dartdoc, so that the two paragraphs it's intended to separate were getting joined as one paragraph instead. Also expand this constructor's summary line slightly to mention its distinctive feature compared with the other constructor, and make other small fixes that I noticed in other docs on this class.
-
- 19 Feb, 2024 8 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b41494f009f4...e96c18b6c5ee 2024-02-19 flar@google.com [Impeller] Run stroke benchmarks on unclosed paths (flutter/engine#50765) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/714215d42e57...b41494f009f4 2024-02-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 6d659f880394 to 475e710429ee (1 revision) (flutter/engine#50763) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Gustl22 authored
Previous PR: #137115, Revert: #142464 Fixes #141940 Closes #142487
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/0af905d779d5...84ff11d7ee5a 2024-02-19 engine-flutter-autoroll@skia.org Roll Flutter from d7867ca7 to 064c340b (33 revisions) (flutter/packages#6161) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f71b7eee2266...714215d42e57 2024-02-19 skia-flutter-autoroll@skia.org Roll Skia from 6eaa7cf6d013 to ff602d384586 (1 revision) (flutter/engine#50762) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/07c73b0c8413...f71b7eee2266 2024-02-19 tessertaha@gmail.com Revert "Fix iOS password autofill prompt dismissal causes layout to resize (#50364)" (flutter/engine#50760) 2024-02-19 skia-flutter-autoroll@skia.org Roll Skia from a4ff02094bbd to 6eaa7cf6d013 (4 revisions) (flutter/engine#50759) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/80d6745c6fd6...07c73b0c8413 2024-02-19 skia-flutter-autoroll@skia.org Roll Skia from b0680ba29971 to a4ff02094bbd (1 revision) (flutter/engine#50756) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/67abf6eb36a1...80d6745c6fd6 2024-02-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uSZ0te7RWVq4IFpjb... to HFmcvzkR3TYeHa_0U... (flutter/engine#50752) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from uSZ0te7RWVq4 to HFmcvzkR3TYe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 18 Feb, 2024 5 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8ae232196fc9...67abf6eb36a1 2024-02-18 matanlurey@users.noreply.github.com Write `adb logcat` results and screenshots to `FLUTTER_LOGS_DIR` if able. (flutter/engine#50722) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f636f9635438...8ae232196fc9 2024-02-18 skia-flutter-autoroll@skia.org Roll Skia from 0d2dbf53aef6 to b0680ba29971 (1 revision) (flutter/engine#50748) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
yim authored
Fixed the issue of incorrect item position when prototypeItem is set in SliverReorderableList. (#142880) Fixes #142708
-
yim authored
Fixes #141577 Fixes #135407
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0ebd580cb8a7...f636f9635438 2024-02-17 bdero@google.com [Impeller] Fix golden flake due to rand use. (flutter/engine#50743) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 17 Feb, 2024 12 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c807aeaab89c...0ebd580cb8a7 2024-02-17 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YN5KCfom7Ax0Z69s_... to uSZ0te7RWVq4IFpjb... (flutter/engine#50746) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from YN5KCfom7Ax0 to uSZ0te7RWVq4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e51d4f1e285a...c807aeaab89c 2024-02-17 skia-flutter-autoroll@skia.org Roll Skia from bb61c2b4614e to 0d2dbf53aef6 (3 revisions) (flutter/engine#50744) 2024-02-17 jonahwilliams@google.com [Impeller] add additional setup method that caches more pipelines, warms internal shader code (flutter/engine#50521) 2024-02-17 bdero@google.com [Impeller] Assign subpass depth on restore rather than creation. (flutter/engine#50626) 2024-02-17 skia-flutter-autoroll@skia.org Roll Dart SDK from fa66195a3814 to 6d659f880394 (1 revision) (flutter/engine#50739) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jason Simmons authored
0af905d77 [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152) f865bafd8 Raise gradle wrapper version of legacy project (flutter/packages#6132) b4d8ad719 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142) cc34b78a0 [ci/various] Update for 3.19 stable (flutter/packages#6147) 10a8b76ad Roll Flutter (stable) from 41456452f29d to bae5e49bc2a8 (1550 revisions) (flutter/packages#6145) a36071b5e Roll Flutter from a628814e to d7867ca7 (66 revisions) (flutter/packages#6146)
-
Jason Simmons authored
This is required by a new API recently added to Dart. See https://github.com/flutter/flutter/issues/143614
-
Bruno Leroux authored
## Description This PR is the third step for the M3 test migration for `InputDecorator`. Step 1: https://github.com/flutter/flutter/pull/142981 Step 2: https://github.com/flutter/flutter/pull/143369 This PR moves some tests out of the 'Material2' group (the ones that are ok on M3). @justinmc The diff is almost unreadable, I moved the tests as carefully as possible and I checked that before and after the number of tests is exactly the same. ## Related Issue Related to https://github.com/flutter/flutter/issues/139076 ## Tests Move some tests from 'Material2' group to main().
-
Bruno Leroux authored
## Description This PR updates the `InputDecoration.contentPadding` documentation to detail both Material 3 and Material 2 default values. ## Related Issue Follow-up to https://github.com/flutter/flutter/pull/142981. ## Tests Documentation only.
-
Jonah Williams authored
Similar to other issues, appears that text goldens are really unstable with Impeller. Part of https://github.com/flutter/flutter/issues/143616
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2ed159a786ef...e51d4f1e285a 2024-02-17 robert.ancell@canonical.com Connect signals in swapped form. (flutter/engine#50705) 2024-02-17 jason-simmons@users.noreply.github.com Restore use of the API 34 device in the Firebase Test Lab script and handle FTL infrastructure errors in the script (flutter/engine#50735) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Jonah Williams authored
Part of https://github.com/flutter/flutter/issues/143616 The perspective transformed text goldens are super unstable, possibly for the same reason they are in flutter/engine.
-
Jonah Williams authored
Part of https://github.com/flutter/flutter/issues/143616
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/afb270929a6c...2ed159a786ef 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from e4e234d412ee to bb61c2b4614e (4 revisions) (flutter/engine#50736) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c4fe6f01e0f5...afb270929a6c 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 6ae5032133d0 to e4e234d412ee (1 revision) (flutter/engine#50733) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 16 Feb, 2024 14 commits
-
-
Brian Quinlan authored
https://dart-review.googlesource.com/c/sdk/+/326761/24/sdk/lib/io/stdio.dart#380 added a `lineTerminator` field to `Stdout`. Add that field to the fake in packages/test. Fixes https://github.com/flutter/flutter/issues/143614 ## Pre-launch Checklist - [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X] I signed the [CLA]. - [X] I listed at least one issue that this PR fixes in the description above. - [X] I updated/added relevant documentation (doc comments with `///`). - [X] I added new tests to check the change I am making, or this PR is [test-exempt]. - [X] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2eed3fbb293a...c4fe6f01e0f5 2024-02-16 30870216+gaaclarke@users.noreply.github.com Pulled out dir contents golden tool (flutter/engine#50703) 2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 21b9ee6f0a52 to fa66195a3814 (3 revisions) (flutter/engine#50732) 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 2919d86cad12 to 6ae5032133d0 (8 revisions) (flutter/engine#50729) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
LongCatIsLooong authored
Fixes https://github.com/flutter/flutter/issues/79495 This is basically a reland of https://github.com/flutter/flutter/pull/79607. Currently when the cursor is invalid, arrow key navigation / typing / backspacing doesn't work since the cursor position is unknown. Showing the cursor when the selection is invalid gives the user the wrong information about the current insert point in the text. This is going to break internal golden tests.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/13dc857bf2ef...2eed3fbb293a 2024-02-16 jacksongardner@google.com Temporarily disable goldens for Safari. (flutter/engine#50724) 2024-02-16 kustermann@google.com [web] Remove unused `allowInterop` usage in flutter web code (flutter/engine#50718) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Work towards https://github.com/dart-lang/linter/issues/4859 There are libraries outside a `lib/` directory, which violate `implementation_imports`. Supersedes https://github.com/flutter/flutter/pull/143560.
-
Andrew Kolos authored
In service of https://github.com/flutter/flutter/issues/143348. This PR enables parsing of the pubspec yaml schemes for assets with transformations as described in #143348.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5fd5ccf32d08...13dc857bf2ef 2024-02-16 jonahwilliams@google.com [Impeller] use fewer threads for shader bootstrap workers on low core machines. (flutter/engine#50726) 2024-02-16 goderbauer@google.com Fix implementation imports outside of lib (flutter/engine#50727) 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 87e8e9c8f42b to 2919d86cad12 (8 revisions) (flutter/engine#50723) 2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 947c8c487e28 to 21b9ee6f0a52 (2 revisions) (flutter/engine#50717) 2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from c89a4cd72308 to 87e8e9c8f42b (3 revisions) (flutter/engine#50716) 2024-02-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fXqP_YC4zTp9G2hA5... to YN5KCfom7Ax0Z69s_... (flutter/engine#50719) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from fXqP_YC4zTp9 to YN5KCfom7Ax0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Michael Goderbauer authored
Fixes https://github.com/flutter/flutter/issues/143405. It was counter-intuitive that a SemanticsFinder without specifying a FlutterView would only search the nodes in the default view. This change makes it so that when no view is specified the semantics trees of all known FlutterViews are searched.
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/143513 Should be cherry-picked to beta.
-
Tirth authored
Added Missing Field Name in Doc Comment in SnackBarThemeData.
-
Nate authored
This PR is the 8áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293) I did a pass through all of `packages/flutter/lib/src/` and found a whole bunch of `switch` statements to improve: most of them were really simple, but many involved some thorough refactoring. This pull request is just the complicated stuff. ð I'll make comments to describe the changes, and then in the future there will be another PR (and it'll be much easier to review than this one).
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/dd530f1556df...5fd5ccf32d08 2024-02-16 jason-simmons@users.noreply.github.com Use the Pixel 7/API 33 device in the Firebase test lab script (flutter/engine#50721) 2024-02-16 leroux_bruno@yahoo.fr [Web] Ignore invalid keyboard events related to autofill (flutter/engine#50590) 2024-02-16 jason-simmons@users.noreply.github.com Add the web package to the set of Dart third_party packages in DEPS (flutter/engine#50714) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/ef349bec8ee9...c56c12dd51ef 2024-02-16 10687576+bparrishMines@users.noreply.github.com [tool] Add support for using a Kotlin test runner file (flutter/packages#6131) 2024-02-16 louisehsu@google.com [in_app_purchase] fix skerror nullability (flutter/packages#6139) 2024-02-15 jacksongardner@google.com Explicitly pass the web renderer into the tests. (flutter/packages#6140) 2024-02-15 stuartmorgan@google.com [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141) 2024-02-15 stuartmorgan@google.com [local_auth] Add compatibility with latest `intl` (flutter/packages#6138) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
fixes [Calling `setState` in a `MaterialStatesController` listener and `MaterialStateController.update` causes Exception](https://github.com/flutter/flutter/issues/138986) ### Description `MaterialStatesController` listener calls `setState` during build when `MaterialStatesController.update` listener calls `notifyListeners`. I tried fixing this issue by putting `notifyListeners` in a post-frame callback. However, this breaks existing customer tests (particularly super editor tests). A safer approach would be to document that the listener's `setState` call should be in a post-frame callback to delay it and not call this during the build phase triggered by the `MaterialStatesController.update` in the widgets such as InkWell or buttons.
-
