1. 11 Jul, 2018 3 commits
  2. 10 Jul, 2018 1 commit
    • Danny Tuppeny's avatar
      Improve flutter tools integration tests (#18865) · b931640c
      Danny Tuppeny authored
      * Rename util -> test_utils
      
      * Rename flutter_test_driver -> test_driver
      
      * Switch testWithContext -> test
      
      * Remove unused import
      
      * Move test project into a class to make it easier to have multiple of these
      
      Each "TestProject" class can contain its files and things like named breakpoint locations.
      
      * Split expression evaluation tests into own file
      
      * Include last response in error messages
      
      * Update expectations based on current bugs
      
      * Fix async-ness in tests
      
      * Fix incorrect expectation in test
      
      * Fix incorrect evaluations
      
      * Remove skips for tests that are now passing on master
      
      * Expect pass on Linux
      
      :shrug:‍♂️
      
      * Call the code
      
      * Skip expression evaluation tests on Windows
      
      * Skip whole group, not just one test
      
      * Remove duplicated method from merge
      
      * Fix misplaced close of group
      
      * Remove code that was duplicated from test we copied
      
      Not sure how this ended up in here?
      
      * Re-fix typo
      b931640c
  3. 09 Jul, 2018 2 commits
  4. 06 Jul, 2018 1 commit
    • abykov2's avatar
      Adding a setup function for hot restart (#18921) · e5d9feb5
      abykov2 authored
      * Adding a setup function for hot restart that can be overwritten to perform any necessary initialization before a restart is started.
      
      * Adding a test for setupHotRestart
      
      * Removing local pubspec change
      
      * Fixing some type annotation errors
      
      * Responding to comments
      e5d9feb5
  5. 03 Jul, 2018 1 commit
  6. 01 Jul, 2018 1 commit
  7. 28 Jun, 2018 8 commits
    • Danny Tuppeny's avatar
      Remove flaky flutter_tester test (#18916) · abc3c4eb
      Danny Tuppeny authored
      This test was designed to ensure flutter_tester keeps running (previously it would quit immediately). However it's turned out ot be rather flaky and we have new tests on the way that supersede this by actually testing real things (debug stepping, reloading, expression evaluation).
      abc3c4eb
    • Danny Tuppeny's avatar
      Remove the 'app' domain from flutter daemon (#18873) · 108da013
      Danny Tuppeny authored
      * Remove the 'app' domain from flutter daemon
      
      By default the daemon won't register the "app" domain, you need to opt-in (which the 'run' command does, as well as the tests for the app functionality).
      
      Fixes #6658.
      
      * Tweak text
      
      * Put restart/callServiceExtension/stop back into daemon mode
      
      * Add a comment about removing discoverApps
      108da013
    • Sigurd Meldgaard's avatar
      Add iOS module template (#18830) (#18903) · 1e8ef602
      Sigurd Meldgaard authored
      Add iOS module template
      
      This will enable integration of flutter-views into existing iOS project.
      1e8ef602
    • Sigurd Meldgaard's avatar
      Revert "Add iOS module template (#18830)" (#18902) · 4a6558f8
      Sigurd Meldgaard authored
      This reverts commit 8be198d8 that broke the build.
      4a6558f8
    • Danny Tuppeny's avatar
      Re-skip flutter_device_tester test (#18900) · 328f9b30
      Danny Tuppeny authored
      After landing the un-skip this test failed with a timeout. It then passed on the next build (!). I think it's too flaky to leave running until we can better diagnose what's happening.
      328f9b30
    • Sigurd Meldgaard's avatar
      Add iOS module template (#18830) · 8be198d8
      Sigurd Meldgaard authored
      Add iOS module template
      
      This will enable integration of flutter-views into existing iOS project.
      8be198d8
    • Danny Tuppeny's avatar
      Add process output for flutter_tester test and unskip (#18899) · 3158d857
      Danny Tuppeny authored
      * Add process output for flutter_tester test and unskip
      
      * Add a comment about this potential flake
      3158d857
    • Danny Tuppeny's avatar
      Add --create option to `flutter emulators` command (#18235) · cdb01187
      Danny Tuppeny authored
      * Add --create option to flutter emulators
      
      * Tweaks to error message
      
      * Simplify emulator search logic
      
      * Make name optional
      
      * Add a note about this option being used with --create
      
      * Tweaks to help information
      
      * Switch to processManager for easier testing
      
      * Don't crash on missing files or missing properties in Android Emulator
      
      * Move name suffixing into emulator manager
      
      This allows it to be tested in the EmulatorManager tests and also used by daemon later if desired.
      
      * Pass the context's android SDK through so it can be mocked by tests
      
      * Misc fixes
      
      * Add tests around emulator creation
      
      Process calls are mocked to avoid needing a real SDK (and to be fast). Full integration tests may be useful, but may require ensuring all build environments etc. are set up correctly.
      
      * Simplify avdManagerPath
      
      Previous changes were to emulatorPath!
      
      * Fix lint errors
      
      * Fix incorrect file exgtension for Windows
      
      * Fix an issue where no system images would crash
      
      reduce throws on an empty collection.
      
      * Fix "null" appearing in error messages
      
      The name we attempted to use will now always be returned, even in the case of failure.
      
      * Add additional info to missing-system-image failure message
      
      On Windows after installing Andriod Studio I didn't have any of these and got this message. Installing with sdkmanager fixed the issue.
      
      * Fix thrown errors
      
      runResult had a toString() but we moved to ProcessResult when switching to ProcessManager to this ended up throwing "Instance of ProcessResult".
      
      * Fix package import
      
      * Fix more package imports
      
      * Move mock implementation into Mock class
      
      There seemed to be issues using Lists in args with Mockito that I couldn't figure out (docs say to use typed() but I couldn't make this compile with these lists still)..
      
      * Rename method that's ambigious now we have create
      
      * Handle where there's no avd path
      
      * Add another toList() :(
      
      * Remove comment that was rewritten
      
      * Fix forbidden import
      
      * Make optional arg more obviously optional
      
      * Reformat doc
      
      * Note that we create a pixel device in help text
      
      * Make this a named arg
      cdb01187
  8. 27 Jun, 2018 6 commits
    • Ian Hickson's avatar
      Remove race conditions involving finding available ports (#18698) · 35ad2a78
      Ian Hickson authored
      This is an attempt to reland #18488 with less breakage on macOS.
      35ad2a78
    • Danny Tuppeny's avatar
    • Danny Tuppeny's avatar
    • Danny Tuppeny's avatar
      Improve update checking (#18193) · e616c6ce
      Danny Tuppeny authored
      * Improve update checking
      
      This change emables pinging the server to check for updates regardless of whether the local version is "out of date". The server code already has a 7-day cache so the result is that we can now ping the server once every 7 days instead of waiting for the local install to be 4 weeks out of date before pinging.
      
      The original 4 week period is still used for when we'll start warning the user they're out of date if we could not confirm with the server whether there's a new version.
      
      * Improve message when we know there's a new version available
      
      * Fix bnullable bool checks
      
      * Switch nullable bool to enum
      
      * Fix casing of enum values
      
      * Remove stale comment
      
      The names are now descriptive so doesn't need additional explanation.
      
      * Improve name of function
      
      * Remove note:
      
      * Rename kPauseToLetUserReadTheMessage -> timeToPauseToLetUserReadTheMessage
      
      * Change kVersionAgeConsideredUpToDate to 5 weeks from 4
      
      * Inline the isNewerFrameworkVersionAvailable check
      
      * Fix indenting (?)
      
      * Fix more indenting
      
      * Rename function to be clearer it's getting the commit date
      
      * Formating tweaks
      
      * Update stamp when connection failed, and reduce time before we'll try again
      
      Previously we would hit the server on every command if we thought we might be out of date and we never successfully connected (eg. if you're offline). This makes the stamp update even when there's a conneciton failure so that this won't happen, but reduces the time till we check again from 7 days to 3 days to compensate a little in case it was a one-off.
      
      https://github.com/flutter/flutter/pull/18193#issuecomment-399222269
      
      * Fix comment
      
      * Don't perform update checks if not on an official channel
      e616c6ce
    • Danny Tuppeny's avatar
      Mark flutter-tester-runs-forever test as skip (#18867) · 0fb20972
      Danny Tuppeny authored
      This test is failing on mac_bot (but passing elsewhere) because flutter-tester is apparently quitting earlier than expected. Locally it fails with an even weirder error and almost all tests are failing with "Compilation failed" (this isn't happening on the builds, so something is bad on my MacBook). Marking as skip to fix build while investigating; there's no real impact of this test not running; it's testing a tool that its itself used for testing (and not currently in any way that should be affected by this failure).
      0fb20972
    • Danny Tuppeny's avatar
  9. 25 Jun, 2018 2 commits
  10. 22 Jun, 2018 1 commit
  11. 21 Jun, 2018 2 commits
  12. 20 Jun, 2018 2 commits
  13. 19 Jun, 2018 1 commit
  14. 15 Jun, 2018 3 commits
  15. 14 Jun, 2018 1 commit
  16. 13 Jun, 2018 1 commit
    • Chris Bracken's avatar
      Revert elimination of Dart 1 (#18460) · 2ae48845
      Chris Bracken authored
      fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly
      from source, flutter_platform.dart automatically runs a kernel compile when
      operating in Dart 2 mode, but this assumes a functional Dart SDK is available
      in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts
      directory with an empty temp dir.
      
      Remaining work is:
      1. Get the frontend server building as a dependency on Fuchsia.
      2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server.
      
      This also reverts migration to Dart 2 typedef syntax.
      
      This reverts commit 6c56bb24. (#18362)
      This reverts commit 3daebd05. (#18316)
      2ae48845
  17. 11 Jun, 2018 2 commits
  18. 09 Jun, 2018 1 commit
  19. 08 Jun, 2018 1 commit
    • Chris Bracken's avatar
      It's time to #deleteDart1 (again) (#18316) · 3daebd05
      Chris Bracken authored
      * It's time to #deleteDart1 (#18293)
      
      Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1
      benchmarks. All commands now run in Dart 1 mode only.
      
      Eliminates --preview-dart-2 / --no-preview-dart-2 support.
      
      * Fix indentation, remove no longer necessary .toList()
      
      * Only push udpated kernel if >0 invalidated srcs
      3daebd05