Unverified Commit 328f9b30 authored by Danny Tuppeny's avatar Danny Tuppeny Committed by GitHub

Re-skip flutter_device_tester test (#18900)

After landing the un-skip this test failed with a timeout. It then passed on the next build (!). I think it's too flaky to leave running until we can better diagnose what's happening.
parent 8be198d8
......@@ -107,15 +107,19 @@ class MyApp extends StatelessWidget {
expect(result.started, isTrue);
expect(result.observatoryUri, isNotNull);
// This test has been seen to fail on mac_bot because the process did not keep running.
// Capturing stdout/stderr has been added subsequently to try and track this down.
// If you're ivnestigating this test failing in the future, feel free to
// mark is as skip (it's not currently critical) and notifiy dantup@ to look at the logs.
// This test has been seen to flake on mac_bot because the process did not keep running.
// and on Travis with a timeout:
// 05:33 +416 ~9 -1: test/integration/flutter_tester_test.dart: FlutterTesterDevice start [E]
// TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
// package:test Invoker._onRun.<fn>.<fn>.<fn>
// 06:00 +623 ~9 -1: Some tests failed.
//
// TODO(dantup): Find a way to better log what's going on before un-skipping again.
await new Future<void>.delayed(const Duration(seconds: 3));
expect(device.isRunning, true, reason: 'Device did not remain running.\n\n$logs'.trim());
expect(await device.stopApp(null), isTrue);
});
}, skip: true);
});
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment