Unverified Commit 3158d857 authored by Danny Tuppeny's avatar Danny Tuppeny Committed by GitHub

Add process output for flutter_tester test and unskip (#18899)

* Add process output for flutter_tester test and unskip

* Add a comment about this potential flake
parent cdb01187
......@@ -97,15 +97,25 @@ class MyApp extends StatelessWidget {
}
''');
// Capture process output so that if the process quits we can print the
// stdout/stderr in the error.
final StringBuffer logs = new StringBuffer();
device.getLogReader().logLines.listen(logs.write);
final LaunchResult result = await start(mainPath);
expect(result.started, isTrue);
expect(result.observatoryUri, isNotNull);
// This test has been seen to fail on mac_bot because the process did not keep running.
// Capturing stdout/stderr has been added subsequently to try and track this down.
// If you're ivnestigating this test failing in the future, feel free to
// mark is as skip (it's not currently critical) and notifiy dantup@ to look at the logs.
await new Future<void>.delayed(const Duration(seconds: 3));
expect(device.isRunning, true);
expect(device.isRunning, true, reason: 'Device did not remain running.\n\n$logs'.trim());
expect(await device.stopApp(null), isTrue);
}, skip: true);
});
});
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment