1. 10 Feb, 2021 1 commit
  2. 15 Jan, 2021 1 commit
  3. 07 Jan, 2021 1 commit
    • Ian Hickson's avatar
      Minor doc, style, and perf updates to Navigator/Routes (#71689) · fdab8546
      Ian Hickson authored
      * Minor doc, style, and perf updates to Navigator/Routes
      
      These are minor fixes I ended up making while working on a larger
      project that never went anywhere.
      
      - Used a ColoredBox instead of a DecoratedBox for ModalBarrier
        (probably a trivial memory/perf win).
      
      - A bunch of Navigator documentation fixes around when things rebuild.
      
      - Mark routes dirty when the Navigator has a dependency change. I
        cannot find a way to test this because as far as I can tell it makes
        no actual difference to when things rebuild because whenever the
        Navigator rebuilds the Overlay rebuilds and whenever that happens
        every OverlayEntry rebuilds, but in theory that's not guaranteed so
        this is sort of a correctness fix. It may even be a perf loss. We do
        something similar in didUpdateWidget already. I could be convinced
        to maybe remove these...
      
      - Make ModalRoute.filter public like everything else.
      
      - Made ModalRoute update its barrier when it gets an update, in case
        e.g. the modal barrier depends on inherited widgets via the
        navigator context. Again, not sure of any way to detect this, it
        might actually be moot, but it seems to be the technically correct
        solution?
      
      - Minor style fixes.
      
      All in all I couldn't figure out a way to test any of this (I wrote
      multiple large tests but it turns out they all already pass on master
      and are effectively redundant with existing tests).
      
      * Remove extraneous blank line
      fdab8546
  4. 05 Jan, 2021 1 commit
  5. 31 Dec, 2020 1 commit
  6. 24 Dec, 2020 2 commits
  7. 11 Dec, 2020 1 commit
  8. 20 Nov, 2020 1 commit
  9. 09 Nov, 2020 1 commit
  10. 02 Nov, 2020 1 commit
  11. 31 Oct, 2020 1 commit
  12. 26 Oct, 2020 2 commits
  13. 21 Oct, 2020 1 commit
  14. 10 Oct, 2020 1 commit
  15. 08 Oct, 2020 1 commit
  16. 07 Oct, 2020 2 commits
  17. 06 Oct, 2020 1 commit
  18. 05 Oct, 2020 1 commit
  19. 02 Oct, 2020 1 commit
  20. 27 Sep, 2020 2 commits
  21. 23 Sep, 2020 1 commit
  22. 17 Sep, 2020 1 commit
  23. 15 Sep, 2020 1 commit
    • Alexandre Ardhuin's avatar
      Reland "Nnbd widgets" (#65528) · b007a81a
      Alexandre Ardhuin authored
      * Reland "Nnbd widgets (#64672)"
      
      This reverts commit 127e6790.
      
      * remove non-nullable enforcement on AsyncSnapshot
      
      * make data param non-nullable for AsyncSnapshot.withData
      
      * make some Text params non-nullable
      b007a81a
  24. 09 Sep, 2020 2 commits
    • Michael Goderbauer's avatar
      Revert "Nnbd widgets (#64672)" (#65488) · 127e6790
      Michael Goderbauer authored
      This reverts commit e682ec71.
      127e6790
    • Alexandre Ardhuin's avatar
      Nnbd widgets (#64672) · e682ec71
      Alexandre Ardhuin authored
      * migrate widget to nullsafety
      
      * remove double blank line after license
      
      * address review comments in actions.dart
      
      * nullable ObjectKey.value
      
      * use local variable oldElement
      
      * make State.build non-nullable
      
      * make State.context non-nullable
      
      * newline at eof
      
      * make ProxyWidget.child non-nullable
      
      * make _InactiveElements.debugContains non-nullable
      
      * make Element.depth non-nullable
      
      * make ProxyElement.build non-nullable
      
      * make StatefulElement.state non-nullable
      
      * remove 'Notice that'
      
      * avoid cast of list in RenderObjectElement.updateChildren
      
      * make IndexedSlot.value non-nullable
      
      * avoid cast of list in MultiChildRenderObjectElement.mount
      
      * make some WidgetsApp parameters non-nullable
      
      * hitTest take non-nullable position
      
      * make ScrollableState.position non-nullable
      
      * use _pixels instead of pixels
      
      * make ViewportOffset.pixels non-nullable
      
      * make param and return type of IndexedWidgetBuilder non-nullable
      
      * unused_import
      
      * make context param non-nullable for Builder in animated_list.dart
      
      * make ScrollMetrics.viewportDimension non-nullable
      
      * make ScrollMetrics.{min,max}ScrollExtent non-nullable
      
      * make _Location.file non-nullable
      
      * _WidgetForTypeTests.createElement throw UnimplementedError
      
      * update _NullWidget.build error message
      
      * make _ShortcutsState.manager non-nullable
      
      * Fix childCount issues for NNBD
      
      * fix childCount computation on web
      
      * increase max value on js side to compute childCount
      
      * make aspect parameter of dependOnInheritedWidgetOfExactType nullable
      
      * merge has{min,max}ScrollExtent into hasScrollExtents
      
      * update focus_manager.dart
      
      * address review comments in icon.dart
      
      * address review comments in image.dart
      
      * address review comments in routes.dart
      
      * address review comments in scroll_activity.dart
      
      * update doc comments
      
      * make UserScrollNotification.direction non-nullable and required
      
      * rename hasScrollExtents to hasContentDimensions
      
      * unnecessary late
      Co-authored-by: 's avatarIan Hickson <ian@hixie.ch>
      e682ec71
  25. 08 Aug, 2020 1 commit
  26. 06 Aug, 2020 1 commit
  27. 29 Jul, 2020 2 commits
  28. 28 Jul, 2020 2 commits
  29. 14 Jul, 2020 1 commit
  30. 13 Jul, 2020 1 commit
  31. 09 Jul, 2020 1 commit
  32. 08 Jul, 2020 1 commit
  33. 25 Jun, 2020 1 commit