mac.dart 24.2 KB
Newer Older
Ian Hickson's avatar
Ian Hickson committed
1
// Copyright 2014 The Flutter Authors. All rights reserved.
2 3 4
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

5 6
// @dart = 2.8

7
import 'package:meta/meta.dart';
8
import 'package:process/process.dart';
9

10
import '../artifacts.dart';
11
import '../base/common.dart';
12
import '../base/file_system.dart';
13
import '../base/io.dart';
14
import '../base/logger.dart';
15
import '../base/process.dart';
16
import '../base/project_migrator.dart';
17
import '../base/utils.dart';
18
import '../build_info.dart';
19
import '../cache.dart';
20
import '../flutter_manifest.dart';
21
import '../globals_null_migrated.dart' as globals;
22
import '../macos/cocoapod_utils.dart';
23
import '../macos/xcode.dart';
24
import '../project.dart';
25
import '../reporting/reporting.dart';
26
import 'application_package.dart';
27
import 'code_signing.dart';
28
import 'devices.dart';
29
import 'migrations/project_base_configuration_migration.dart';
30
import 'migrations/project_build_location_migration.dart';
31
import 'migrations/remove_framework_link_and_embedding_migration.dart';
32
import 'migrations/xcode_build_system_migration.dart';
33
import 'xcode_build_settings.dart';
34
import 'xcodeproj.dart';
35

36
class IMobileDevice {
37 38 39 40 41
  IMobileDevice({
    @required Artifacts artifacts,
    @required Cache cache,
    @required ProcessManager processManager,
    @required Logger logger,
42 43
  }) : _idevicesyslogPath = artifacts.getHostArtifact(HostArtifact.idevicesyslog).path,
      _idevicescreenshotPath = artifacts.getHostArtifact(HostArtifact.idevicescreenshot).path,
44 45 46
      _dyLdLibEntry = cache.dyLdLibEntry,
      _processUtils = ProcessUtils(logger: logger, processManager: processManager),
      _processManager = processManager;
47

48 49
  final String _idevicesyslogPath;
  final String _idevicescreenshotPath;
50 51 52
  final MapEntry<String, String> _dyLdLibEntry;
  final ProcessManager _processManager;
  final ProcessUtils _processUtils;
53

54
  bool get isInstalled => _isInstalled ??= _processManager.canRun(_idevicescreenshotPath);
55
  bool _isInstalled;
56

57
  /// Starts `idevicesyslog` and returns the running process.
58
  Future<Process> startLogger(String deviceID) {
59
    return _processUtils.start(
60 61 62 63 64 65
      <String>[
        _idevicesyslogPath,
        '-u',
        deviceID,
      ],
      environment: Map<String, String>.fromEntries(
66
        <MapEntry<String, String>>[_dyLdLibEntry]
67 68 69
      ),
    );
  }
70

71
  /// Captures a screenshot to the specified outputFile.
72 73 74 75 76
  Future<void> takeScreenshot(
    File outputFile,
    String deviceID,
    IOSDeviceInterface interfaceType,
  ) {
77
    return _processUtils.run(
78 79
      <String>[
        _idevicescreenshotPath,
80
        outputFile.path,
81 82
        '--udid',
        deviceID,
83 84
        if (interfaceType == IOSDeviceInterface.network)
          '--network',
85
      ],
86
      throwOnError: true,
87
      environment: Map<String, String>.fromEntries(
88
        <MapEntry<String, String>>[_dyLdLibEntry]
89 90
      ),
    );
91
  }
92 93
}

94 95 96 97 98 99 100 101 102
Future<XcodeBuildResult> buildXcodeProject({
  BuildableIOSApp app,
  BuildInfo buildInfo,
  String targetOverride,
  bool buildForDevice,
  DarwinArch activeArch,
  bool codesign = true,
  String deviceID,
  bool configOnly = false,
103
  XcodeBuildAction buildAction = XcodeBuildAction.build,
104
}) async {
105
  if (!upgradePbxProjWithFlutterAssets(app.project, globals.logger)) {
106
    return XcodeBuildResult(success: false);
107
  }
108

109
  final List<ProjectMigrator> migrators = <ProjectMigrator>[
110
    RemoveFrameworkLinkAndEmbeddingMigration(app.project, globals.logger, globals.flutterUsage),
111
    XcodeBuildSystemMigration(app.project, globals.logger),
112
    ProjectBaseConfigurationMigration(app.project, globals.logger),
113
    ProjectBuildLocationMigration(app.project, globals.logger),
114 115
  ];

116
  final ProjectMigration migration = ProjectMigration(migrators);
117
  if (!migration.run()) {
118
    return XcodeBuildResult(success: false);
119 120
  }

121
  if (!_checkXcodeVersion()) {
122
    return XcodeBuildResult(success: false);
123
  }
124

125
  await removeFinderExtendedAttributes(app.project.parent.directory, globals.processUtils, globals.logger);
126

127
  final XcodeProjectInfo projectInfo = await app.project.projectInfo();
128 129
  final String scheme = projectInfo.schemeFor(buildInfo);
  if (scheme == null) {
130
    projectInfo.reportFlavorNotFoundAndExit();
131 132 133
  }
  final String configuration = projectInfo.buildConfigurationFor(buildInfo, scheme);
  if (configuration == null) {
134 135 136 137 138 139 140
    globals.printError('');
    globals.printError('The Xcode project defines build configurations: ${projectInfo.buildConfigurations.join(', ')}');
    globals.printError('Flutter expects a build configuration named ${XcodeProjectInfo.expectedBuildConfigurationFor(buildInfo, scheme)} or similar.');
    globals.printError('Open Xcode to fix the problem:');
    globals.printError('  open ios/Runner.xcworkspace');
    globals.printError('1. Click on "Runner" in the project navigator.');
    globals.printError('2. Ensure the Runner PROJECT is selected, not the Runner TARGET.');
141
    if (buildInfo.isDebug) {
142
      globals.printError('3. Click the Editor->Add Configuration->Duplicate "Debug" Configuration.');
143
    } else {
144
      globals.printError('3. Click the Editor->Add Configuration->Duplicate "Release" Configuration.');
145
    }
146 147 148 149 150 151 152 153 154 155
    globals.printError('');
    globals.printError('   If this option is disabled, it is likely you have the target selected instead');
    globals.printError('   of the project; see:');
    globals.printError('   https://stackoverflow.com/questions/19842746/adding-a-build-configuration-in-xcode');
    globals.printError('');
    globals.printError('   If you have created a completely custom set of build configurations,');
    globals.printError('   you can set the FLUTTER_BUILD_MODE=${buildInfo.modeName.toLowerCase()}');
    globals.printError('   in the .xcconfig file for that configuration and run from Xcode.');
    globals.printError('');
    globals.printError('4. If you are not using completely custom build configurations, name the newly created configuration ${buildInfo.modeName}.');
156
    return XcodeBuildResult(success: false);
157 158
  }

159 160 161 162 163
  final FlutterManifest manifest = app.project.parent.manifest;
  final String buildName = parsedBuildName(manifest: manifest, buildInfo: buildInfo);
  final bool buildNameIsMissing = buildName == null || buildName.isEmpty;

  if (buildNameIsMissing) {
164
    globals.printStatus('Warning: Missing build name (CFBundleShortVersionString).');
165 166 167 168 169 170
  }

  final String buildNumber = parsedBuildNumber(manifest: manifest, buildInfo: buildInfo);
  final bool buildNumberIsMissing = buildNumber == null || buildNumber.isEmpty;

  if (buildNumberIsMissing) {
171
    globals.printStatus('Warning: Missing build number (CFBundleVersion).');
172 173
  }
  if (buildNameIsMissing || buildNumberIsMissing) {
174 175
    globals.printError('Action Required: You must set a build name and number in the pubspec.yaml '
      'file version field before submitting to the App Store.');
176 177
  }

178
  Map<String, String> autoSigningConfigs;
179 180 181 182 183 184

  final Map<String, String> buildSettings = await app.project.buildSettingsForBuildInfo(
        buildInfo,
        environmentType: buildForDevice ? EnvironmentType.physical : EnvironmentType.simulator,
      ) ?? <String, String>{};

185
  if (codesign && buildForDevice) {
186
    autoSigningConfigs = await getCodeSigningIdentityDevelopmentTeam(
187
      buildSettings: buildSettings,
188
      processManager: globals.processManager,
189
      logger: globals.logger,
190 191
      config: globals.config,
      terminal: globals.terminal,
192
    );
193
  }
194

195
  final FlutterProject project = FlutterProject.current();
196 197
  await updateGeneratedXcodeProperties(
    project: project,
198
    targetOverride: targetOverride,
199
    buildInfo: buildInfo,
200
  );
201
  await processPodsIfNeeded(project.ios, getIosBuildDirectory(), buildInfo.mode);
202 203 204
  if (configOnly) {
    return XcodeBuildResult(success: true);
  }
205

xster's avatar
xster committed
206
  final List<String> buildCommands = <String>[
207
    ...globals.xcode.xcrunCommand(),
208
    'xcodebuild',
209 210
    '-configuration',
    configuration,
211 212 213
  ];

  if (globals.logger.isVerbose) {
xster's avatar
xster committed
214 215
    // An environment variable to be passed to xcode_backend.sh determining
    // whether to echo back executed commands.
216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235
    buildCommands.add('VERBOSE_SCRIPT_LOGGING=YES');
  } else {
    // This will print warnings and errors only.
    buildCommands.add('-quiet');
  }

  if (autoSigningConfigs != null) {
    for (final MapEntry<String, String> signingConfig in autoSigningConfigs.entries) {
      buildCommands.add('${signingConfig.key}=${signingConfig.value}');
    }
    buildCommands.add('-allowProvisioningUpdates');
    buildCommands.add('-allowProvisioningDeviceRegistration');
  }

  final List<FileSystemEntity> contents = app.project.hostAppRoot.listSync();
  for (final FileSystemEntity entity in contents) {
    if (globals.fs.path.extension(entity.path) == '.xcworkspace') {
      buildCommands.addAll(<String>[
        '-workspace', globals.fs.path.basename(entity.path),
        '-scheme', scheme,
236 237
        if (buildAction != XcodeBuildAction.archive) // dSYM files aren't copied to the archive if BUILD_DIR is set.
          'BUILD_DIR=${globals.fs.path.absolute(getIosBuildDirectory())}',
238 239 240 241
      ]);
      break;
    }
  }
242

243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265
  // Check if the project contains a watchOS companion app.
  final bool hasWatchCompanion = await app.project.containsWatchCompanion(
    projectInfo.targets,
    buildInfo,
  );
  if (hasWatchCompanion) {
    // The -sdk argument has to be omitted if a watchOS companion app exists.
    // Otherwise the build will fail as WatchKit dependencies cannot be build using the iOS SDK.
    globals.printStatus('Watch companion app found. Adjusting build settings.');
    if (!buildForDevice && (deviceID == null || deviceID == '')) {
      globals.printError('No simulator device ID has been set.');
      globals.printError('A device ID is required to build an app with a watchOS companion app.');
      globals.printError('Please run "flutter devices" to get a list of available device IDs');
      globals.printError('and specify one using the -d, --device-id flag.');
      return XcodeBuildResult(success: false);
    }
    if (!buildForDevice) {
      buildCommands.addAll(<String>['-destination', 'id=$deviceID']);
    }
  } else {
    if (buildForDevice) {
      buildCommands.addAll(<String>['-sdk', 'iphoneos']);
    } else {
266
      buildCommands.addAll(<String>['-sdk', 'iphonesimulator']);
267 268
    }
  }
269

270 271 272 273 274 275 276 277 278 279 280
  if (activeArch != null) {
    final String activeArchName = getNameForDarwinArch(activeArch);
    if (activeArchName != null) {
      buildCommands.add('ONLY_ACTIVE_ARCH=YES');
      // Setting ARCHS to $activeArchName will break the build if a watchOS companion app exists,
      // as it cannot be build for the architecture of the flutter app.
      if (!hasWatchCompanion) {
        buildCommands.add('ARCHS=$activeArchName');
      }
    }
  }
281

282 283 284 285 286 287 288 289 290
  if (!codesign) {
    buildCommands.addAll(
      <String>[
        'CODE_SIGNING_ALLOWED=NO',
        'CODE_SIGNING_REQUIRED=NO',
        'CODE_SIGNING_IDENTITY=""',
      ],
    );
  }
291

292 293
  Status buildSubStatus;
  Status initialBuildStatus;
294
  Directory tempDir;
295

296
  File scriptOutputPipeFile;
297 298
  if (globals.logger.hasTerminal) {
    tempDir = globals.fs.systemTempDirectory.createTempSync('flutter_build_log_pipe.');
299
    scriptOutputPipeFile = tempDir.childFile('pipe_to_stdout');
300
    globals.os.makePipe(scriptOutputPipeFile.path);
301 302 303

    Future<void> listenToScriptOutputLine() async {
      final List<String> lines = await scriptOutputPipeFile.readAsLines();
304
      for (final String line in lines) {
305
        if (line == 'done' || line == 'all done') {
306 307
          buildSubStatus?.stop();
          buildSubStatus = null;
308 309 310
          if (line == 'all done') {
            // Free pipe file.
            tempDir?.deleteSync(recursive: true);
311
            return;
312
          }
313
        } else {
314 315
          initialBuildStatus?.cancel();
          initialBuildStatus = null;
316
          buildSubStatus = globals.logger.startProgress(
317
            line,
318
            progressIndicatorPadding: kDefaultStatusPadding - 7,
319 320 321
          );
        }
      }
322
      await listenToScriptOutputLine();
323 324 325
    }

    // Trigger the start of the pipe -> stdout loop. Ignore exceptions.
326
    unawaited(listenToScriptOutputLine());
327 328 329 330

    buildCommands.add('SCRIPT_OUTPUT_STREAM_FILE=${scriptOutputPipeFile.absolute.path}');
  }

331 332 333 334 335 336
  // Don't log analytics for downstream Flutter commands.
  // e.g. `flutter build bundle`.
  buildCommands.add('FLUTTER_SUPPRESS_ANALYTICS=true');
  buildCommands.add('COMPILER_INDEX_STORE_ENABLE=NO');
  buildCommands.addAll(environmentVariablesAsXcodeBuildSettings(globals.platform));

337 338 339 340 341 342 343 344
  if (buildAction == XcodeBuildAction.archive) {
    buildCommands.addAll(<String>[
      '-archivePath',
      globals.fs.path.absolute(app.archiveBundlePath),
      'archive',
    ]);
  }

345
  final Stopwatch sw = Stopwatch()..start();
346
  initialBuildStatus = globals.logger.startProgress('Running Xcode build...');
347 348 349

  final RunResult buildResult = await _runBuildWithRetries(buildCommands, app);

350 351
  // Notifies listener that no more output is coming.
  scriptOutputPipeFile?.writeAsStringSync('all done');
352
  buildSubStatus?.stop();
353
  buildSubStatus = null;
354
  initialBuildStatus?.cancel();
355
  initialBuildStatus = null;
356
  globals.printStatus(
357
    'Xcode ${xcodeBuildActionToString(buildAction)} done.'.padRight(kDefaultStatusPadding + 1)
358
        + getElapsedAsSeconds(sw.elapsed).padLeft(5),
359
  );
360
  globals.flutterUsage.sendTiming(xcodeBuildActionToString(buildAction), 'xcode-ios', Duration(milliseconds: sw.elapsedMilliseconds));
xster's avatar
xster committed
361 362

  if (buildResult.exitCode != 0) {
363
    globals.printStatus('Failed to build iOS app');
xster's avatar
xster committed
364
    if (buildResult.stderr.isNotEmpty) {
365 366
      globals.printStatus('Error output from Xcode build:\n↳');
      globals.printStatus(buildResult.stderr, indent: 4);
367
    }
xster's avatar
xster committed
368
    if (buildResult.stdout.isNotEmpty) {
369
      globals.printStatus("Xcode's output:\n↳");
370
      globals.printStatus(buildResult.stdout, indent: 4);
371
    }
372
    return XcodeBuildResult(
373
      success: false,
xster's avatar
xster committed
374 375
      stdout: buildResult.stdout,
      stderr: buildResult.stderr,
376
      xcodeBuildExecution: XcodeBuildExecution(
xster's avatar
xster committed
377
        buildCommands: buildCommands,
378
        appDirectory: app.project.hostAppRoot.path,
379
        buildForPhysicalDevice: buildForDevice,
xster's avatar
xster committed
380
        buildSettings: buildSettings,
381 382
      ),
    );
383 384
  } else {
    String outputDir;
385 386 387 388 389 390 391 392 393
    if (buildAction == XcodeBuildAction.build) {
      // If the app contains a watch companion target, the sdk argument of xcodebuild has to be omitted.
      // For some reason this leads to TARGET_BUILD_DIR always ending in 'iphoneos' even though the
      // actual directory will end with 'iphonesimulator' for simulator builds.
      // The value of TARGET_BUILD_DIR is adjusted to accommodate for this effect.
      String targetBuildDir = buildSettings['TARGET_BUILD_DIR'];
      if (hasWatchCompanion && !buildForDevice) {
        globals.printTrace('Replacing iphoneos with iphonesimulator in TARGET_BUILD_DIR.');
        targetBuildDir = targetBuildDir.replaceFirst('iphoneos', 'iphonesimulator');
394
      }
395
      final String appBundle = buildSettings['WRAPPER_NAME'];
396 397
      final String expectedOutputDirectory = globals.fs.path.join(
        targetBuildDir,
398
        appBundle,
399
      );
400
      if (globals.fs.directory(expectedOutputDirectory).existsSync()) {
401 402
        // Copy app folder to a place where other tools can find it without knowing
        // the BuildInfo.
403 404 405 406 407 408 409 410 411 412 413 414 415 416 417
        outputDir = targetBuildDir.replaceFirst('/$configuration-', '/');
        globals.fs.directory(outputDir).createSync(recursive: true);

        // rsync instead of copy to maintain timestamps to support incremental
        // app install deltas. Use --delete to remove incompatible artifacts
        // (for example, kernel binary files produced from previous run).
        await globals.processUtils.run(
          <String>[
            'rsync',
            '-av',
            '--delete',
            expectedOutputDirectory,
            outputDir,
          ],
          throwOnError: true,
418
        );
419 420 421 422
        outputDir = globals.fs.path.join(
          outputDir,
          appBundle,
        );
423 424 425
      } else {
        globals.printError('Build succeeded but the expected app at $expectedOutputDirectory not found');
      }
426
    } else {
427
      outputDir = globals.fs.path.absolute(app.archiveBundleOutputPath);
428 429 430
      if (!globals.fs.isDirectorySync(outputDir)) {
        globals.printError('Archive succeeded but the expected xcarchive at $outputDir not found');
      }
431
    }
432 433 434 435 436 437 438 439 440
    return XcodeBuildResult(
        success: true,
        output: outputDir,
        xcodeBuildExecution: XcodeBuildExecution(
          buildCommands: buildCommands,
          appDirectory: app.project.hostAppRoot.path,
          buildForPhysicalDevice: buildForDevice,
          buildSettings: buildSettings,
      ),
441
    );
442
  }
443 444
}

445 446 447
/// Extended attributes applied by Finder can cause code signing errors. Remove them.
/// https://developer.apple.com/library/archive/qa/qa1940/_index.html
@visibleForTesting
448
Future<void> removeFinderExtendedAttributes(Directory projectDirectory, ProcessUtils processUtils, Logger logger) async {
449 450 451 452 453 454
  final bool success = await processUtils.exitsHappy(
    <String>[
      'xattr',
      '-r',
      '-d',
      'com.apple.FinderInfo',
455
      projectDirectory.path,
456 457 458 459
    ]
  );
  // Ignore all errors, for example if directory is missing.
  if (!success) {
460
    logger.printTrace('Failed to remove xattr com.apple.FinderInfo from ${projectDirectory.path}');
461 462 463
  }
}

464 465 466 467 468 469 470 471 472
Future<RunResult> _runBuildWithRetries(List<String> buildCommands, BuildableIOSApp app) async {
  int buildRetryDelaySeconds = 1;
  int remainingTries = 8;

  RunResult buildResult;
  while (remainingTries > 0) {
    remainingTries--;
    buildRetryDelaySeconds *= 2;

473
    buildResult = await globals.processUtils.run(
474 475 476 477 478 479 480 481 482 483 484 485
      buildCommands,
      workingDirectory: app.project.hostAppRoot.path,
      allowReentrantFlutter: true,
    );

    // If the result is anything other than a concurrent build failure, exit
    // the loop after the first build.
    if (!_isXcodeConcurrentBuildFailure(buildResult)) {
      break;
    }

    if (remainingTries > 0) {
486
      globals.printStatus('Xcode build failed due to concurrent builds, '
487 488 489
        'will retry in $buildRetryDelaySeconds seconds.');
      await Future<void>.delayed(Duration(seconds: buildRetryDelaySeconds));
    } else {
490
      globals.printStatus(
491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506
        'Xcode build failed too many times due to concurrent builds, '
        'giving up.');
      break;
    }
  }

  return buildResult;
}

bool _isXcodeConcurrentBuildFailure(RunResult result) {
return result.exitCode != 0 &&
    result.stdout != null &&
    result.stdout.contains('database is locked') &&
    result.stdout.contains('there are two concurrent builds running');
}

507
Future<void> diagnoseXcodeBuildFailure(XcodeBuildResult result, Usage flutterUsage, Logger logger) async {
508 509 510
  if (result.xcodeBuildExecution != null &&
      result.xcodeBuildExecution.buildForPhysicalDevice &&
      result.stdout?.toUpperCase()?.contains('BITCODE') == true) {
511
    BuildEvent('xcode-bitcode-failure',
512
      type: 'ios',
513 514
      command: result.xcodeBuildExecution.buildCommands.toString(),
      settings: result.xcodeBuildExecution.buildSettings.toString(),
515
      flutterUsage: flutterUsage,
516
    ).send();
517 518
  }

519 520 521 522 523 524
  // Building for iOS Simulator, but the linked and embedded framework 'App.framework' was built for iOS.
  // or
  // Building for iOS, but the linked and embedded framework 'App.framework' was built for iOS Simulator.
  if (result.stdout?.contains('Building for iOS') == true
      && result.stdout?.contains('but the linked and embedded framework') == true
      && result.stdout?.contains('was built for iOS') == true) {
525 526 527 528
    logger.printError('');
    logger.printError('Your Xcode project requires migration. See https://flutter.dev/docs/development/ios-project-migration for details.');
    logger.printError('');
    logger.printError('You can temporarily work around this issue by running:');
529
    logger.printError('  flutter clean');
530 531 532
    return;
  }

533 534
  if (result.xcodeBuildExecution != null &&
      result.xcodeBuildExecution.buildForPhysicalDevice &&
535 536
      result.stdout?.contains('BCEROR') == true &&
      // May need updating if Xcode changes its outputs.
537
      result.stdout?.contains("Xcode couldn't find a provisioning profile matching") == true) {
538
    logger.printError(noProvisioningProfileInstruction, emphasis: true);
539 540
    return;
  }
541 542 543
  // Make sure the user has specified one of:
  // * DEVELOPMENT_TEAM (automatic signing)
  // * PROVISIONING_PROFILE (manual signing)
544 545
  if (result.xcodeBuildExecution != null &&
      result.xcodeBuildExecution.buildForPhysicalDevice &&
xster's avatar
xster committed
546
      !<String>['DEVELOPMENT_TEAM', 'PROVISIONING_PROFILE'].any(
547
        result.xcodeBuildExecution.buildSettings.containsKey)) {
548
    logger.printError(noDevelopmentTeamInstruction, emphasis: true);
549 550
    return;
  }
551 552
  if (result.xcodeBuildExecution != null &&
      result.xcodeBuildExecution.buildForPhysicalDevice &&
553
      result.xcodeBuildExecution.buildSettings['PRODUCT_BUNDLE_IDENTIFIER']?.contains('com.example') == true) {
554 555 556 557
    logger.printError('');
    logger.printError('It appears that your application still contains the default signing identifier.');
    logger.printError("Try replacing 'com.example' with your signing id in Xcode:");
    logger.printError('  open ios/Runner.xcworkspace');
558
    return;
559 560
  }
  if (result.stdout?.contains('Code Sign error') == true) {
561 562 563 564 565 566 567
    logger.printError('');
    logger.printError('It appears that there was a problem signing your application prior to installation on the device.');
    logger.printError('');
    logger.printError('Verify that the Bundle Identifier in your project is your signing id in Xcode');
    logger.printError('  open ios/Runner.xcworkspace');
    logger.printError('');
    logger.printError("Also try selecting 'Product > Build' to fix the problem:");
568
    return;
569
  }
570 571
}

572 573 574 575 576
/// xcodebuild <buildaction> parameter (see man xcodebuild for details).
///
/// `clean`, `test`, `analyze`, and `install` are not supported.
enum XcodeBuildAction { build, archive }

577 578
String xcodeBuildActionToString(XcodeBuildAction action) {
    switch (action) {
579 580 581 582 583 584 585 586 587
      case XcodeBuildAction.build:
        return 'build';
      case XcodeBuildAction.archive:
        return 'archive';
      default:
        throw UnsupportedError('Unknown Xcode build action');
    }
}

588
class XcodeBuildResult {
589 590 591 592 593 594 595
  XcodeBuildResult({
    @required this.success,
    this.output,
    this.stdout,
    this.stderr,
    this.xcodeBuildExecution,
  });
596

597 598
  final bool success;
  final String output;
599 600
  final String stdout;
  final String stderr;
601 602 603 604 605 606
  /// The invocation of the build that resulted in this result instance.
  final XcodeBuildExecution xcodeBuildExecution;
}

/// Describes an invocation of a Xcode build command.
class XcodeBuildExecution {
607 608 609 610 611 612
  XcodeBuildExecution({
    @required this.buildCommands,
    @required this.appDirectory,
    @required this.buildForPhysicalDevice,
    @required this.buildSettings,
  });
613 614 615 616 617

  /// The original list of Xcode build commands used to produce this build result.
  final List<String> buildCommands;
  final String appDirectory;
  final bool buildForPhysicalDevice;
xster's avatar
xster committed
618 619
  /// The build settings corresponding to the [buildCommands] invocation.
  final Map<String, String> buildSettings;
620 621
}

622
final String _xcodeRequirement = 'Xcode $xcodeRequiredVersion or greater is required to develop for iOS.';
623 624

bool _checkXcodeVersion() {
625
  if (!globals.platform.isMacOS) {
626
    return false;
627
  }
628
  if (!globals.xcodeProjectInterpreter.isInstalled) {
629
    globals.printError('Cannot find "xcodebuild". $_xcodeRequirement');
630 631
    return false;
  }
632
  if (!globals.xcode.isRequiredVersionSatisfactory) {
633
    globals.printError('Found "${globals.xcodeProjectInterpreter.versionText}". $_xcodeRequirement');
634 635
    return false;
  }
636 637 638
  return true;
}

639
// TODO(jmagman): Refactor to IOSMigrator.
640
bool upgradePbxProjWithFlutterAssets(IosProject project, Logger logger) {
641
  final File xcodeProjectFile = project.xcodeProjectInfoFile;
642 643
  assert(xcodeProjectFile.existsSync());
  final List<String> lines = xcodeProjectFile.readAsLinesSync();
644

645 646
  final RegExp oldAssets = RegExp(r'\/\* (flutter_assets|app\.flx)');
  final StringBuffer buffer = StringBuffer();
647
  final Set<String> printedStatuses = <String>{};
648

649 650 651
  for (final String line in lines) {
    final Match match = oldAssets.firstMatch(line);
    if (match != null) {
652
      if (printedStatuses.add(match.group(1))) {
653
        logger.printStatus('Removing obsolete reference to ${match.group(1)} from ${project.xcodeProject?.basename}');
654
      }
655 656 657
    } else {
      buffer.writeln(line);
    }
658
  }
659
  xcodeProjectFile.writeAsStringSync(buffer.toString());
660
  return true;
661
}