Unverified Commit 024cebf8 authored by Chris Bracken's avatar Chris Bracken Committed by GitHub

Fix mismatched bracket in Xcode failure diagnostic (#14478)

When diagnosing a failed Xcode build, if neither the development team
(for automatic provisioning) nor the provisioning profile (for manual
provisioning) is set, display the appropriate error message. Previously,
this method would not output the appropriate error message if a
only a development team was set.
parent 23ee4a4a
......@@ -386,13 +386,13 @@ Future<Null> diagnoseXcodeBuildFailure(
printError(noProvisioningProfileInstruction, emphasis: true);
return;
}
// Make sure the user has specified one of:
// * DEVELOPMENT_TEAM (automatic signing)
// * PROVISIONING_PROFILE (manual signing)
if (result.xcodeBuildExecution != null &&
result.xcodeBuildExecution.buildForPhysicalDevice &&
// Make sure the user has specified one of:
// DEVELOPMENT_TEAM (automatic signing)
// PROVISIONING_PROFILE (manual signing)
!(app.buildSettings?.containsKey('DEVELOPMENT_TEAM')) == true
|| app.buildSettings?.containsKey('PROVISIONING_PROFILE') == true) {
app.buildSettings != null &&
!<String>['DEVELOPMENT_TEAM', 'PROVISIONING_PROFILE'].any(app.buildSettings.containsKey)) {
printError(noDevelopmentTeamInstruction, emphasis: true);
return;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment