Respect the --no-codesign flag even for simulators (#6799)

74e31679 · Todd Volkert · GitHub · 11ca0f1a · 74e31679
Commit 74e31679 authored Nov 10, 2016 by Todd Volkert Committed by GitHub Nov 10, 2016
Hide whitespace changes
Inline Side-by-side

Showing with 10 additions and 9 deletions

mac.dart packages/flutter_tools/lib/src/ios/mac.dart +10 -9

No files found.
--- a/packages/flutter_tools/lib/src/ios/mac.dart
+++ b/packages/flutter_tools/lib/src/ios/mac.dart
@@ -141,19 +141,20 @@ Future<XcodeBuildResult> buildXcodeProject({

  if (buildForDevice) {
    commands.addAll(<String>['-sdk', 'iphoneos', '-arch', 'arm64']);
-    if (!codesign) {
-      commands.addAll(
-        <String>[
-          'CODE_SIGNING_ALLOWED=NO',
-          'CODE_SIGNING_REQUIRED=NO',
-          'CODE_SIGNING_IDENTITY=""'
-        ]
-      );
-    }
  } else {
    commands.addAll(<String>['-sdk', 'iphonesimulator', '-arch', 'x86_64']);
  }

+  if (!codesign) {
+    commands.addAll(
+      <String>[
+        'CODE_SIGNING_ALLOWED=NO',
+        'CODE_SIGNING_REQUIRED=NO',
+        'CODE_SIGNING_IDENTITY=""'
+      ]
+    );
+  }
+
  RunResult result = await runAsync(
    commands,
    workingDirectory: app.appDirectory,