Commits · fcbe8f44eadc21f09cb3690d98e4de22e7200c93 · abdullh.alsoleman / Front-End

05 Oct, 2019 1 commit

Restructure ProjectFileInvalidator.findInvalidated a bit (#42008) · fcbe8f44

James D. Lin authored Oct 05, 2019

Restructure ProjectFileInvalidator.findInvalidated a bit

I plan to modify `ProjectFileInvalidator.findInvalidated` to allow
it to use `FileStat.stat` instead of `FileStat.statSync`.
Restructure `findInvalidated` a bit so that `FileStat.statSync` is
called in only one place.

Note that this change now always counts the `.packages` file as one
of the files scanned, even if it does not exist.  I think that this
is okay since it more accurately reflects the number of times that we
hit the filesystem with `stat()`, and it is consistent with how other
files are counted.

fcbe8f44

04 Oct, 2019 28 commits

Roll engine 759d3dba259b..7d90779bb66f (5 commits) (#42004) · 71497367

engine-flutter-autoroll authored Oct 04, 2019

git@github.com:flutter/engine.git/compare/759d3dba259b...7d90779bb66f

git log 759d3dba259b..7d90779bb66f --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VkAgX... to by2LL... (flutter/engine#12791)
2019-10-04 bkonyi@google.com Roll src/third_party/dart 28f21d4e99..d6c6d12ebf (3 commits)
2019-10-04 jonahwilliams@google.com Fix bug in package script and add dev_compiler to list of uploaded packages (flutter/engine#12785)
2019-10-04 bkonyi@google.com Roll src/third_party/dart 7a7dcd1ed9..28f21d4e99 (2 commits)
2019-10-04 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from wYLiQ... to JyZWz... (flutter/engine#12788)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

71497367

Clean up ProjectFileInvalidator.findInvalidated a bit (#41889) · 14c5c6e1

James D. Lin authored Oct 04, 2019

In preparation for some refactoring that I will be doing to
`ProjectFileInvalidator.findInvalidated`, make its code a bit
clearer:
* Indicate which arguments may be null.
* Don't bother calling `FileStat.statSync` on the `.packages` file
  for the initial load.  This makes the checks for the `.packages`
  file consistent with those for other files.
* Use `DateTime.isAfter()` instead of comparing microseconds
  ourselves.

While I was touching this file, I also removed some unnecessary
comparisons to `false`. (`_ManifestAssetBundle.wasBuiltOnce()` is the
only implementation I can find of `AssetBundle.wasBuiltOnce()`, and
it never returns `null`.)

14c5c6e1

AOT support for Linux Desktop I: switch Linux builds to assemble (#41612) · 3024053c
Jonah Williams authored Oct 04, 2019

3024053c
Plumb --enable-asserts through to frontend_server invocation in debug mode. (#41832) · cdb3578b
Ryan Macnak authored Oct 04, 2019
```
Bytecode generation will otherwise omit assert code, causing --enable-asserts to have no effect in the VM.
```
cdb3578b
Fix CupertinoTextField and TextField ToolbarOptions not changing (#40665) · b730a993
Rody Davis authored Oct 04, 2019

b730a993
Revert "Fix ReorderableListView's use of child keys (#41334) (#41338)" (#41931) · 0e605cc4
krisgiesing authored Oct 04, 2019
```
This reverts commit 2b138fd7.
```
0e605cc4
Fix 'popupTheme' variable name in a MaterialBannerTheme method (#41632) · 62ae5883
Erick Ghaumez authored Oct 04, 2019

62ae5883

Generate projects using the new Android embedding (#41666) · 5961bcc5

Emmanuel Garcia authored Oct 04, 2019

* Generate projects using the new Android embedding

* Add comment about usesNewEmbedding:true

* Feedback

* Rework way to detect new embedding in new apps

5961bcc5

indent formal parameters correctly (#41644) · 890b9394
Alexandre Ardhuin authored Oct 04, 2019

890b9394

759d3dba2 Roll src/third_party/skia 35a60f622c58..fbdf48ecb204 (2 commits)... · dc03c443

engine-flutter-autoroll authored Oct 04, 2019

759d3dba2 Roll src/third_party/skia 35a60f622c58..fbdf48ecb204 (2 commits) (flutter/engine#12787) (#41965)

git@github.com:flutter/engine.git/compare/ec9d487b0599...759d3dba259b

git log ec9d487b0599..759d3dba259b --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia 35a60f622c58..fbdf48ecb204 (2 commits) (flutter/engine#12787)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

dc03c443

Ensure plugin registrants are generated in build_web (#41906) · ae18f073
Jonah Williams authored Oct 04, 2019

ae18f073

ec9d487b0 Roll src/third_party/dart b4688e9172..7a7dcd1ed9 (5 commits) (#41961) · ea305c50

engine-flutter-autoroll authored Oct 04, 2019


git@github.com:flutter/engine.git/compare/a0605af402ac...ec9d487b0599

git log a0605af402ac..ec9d487b0599 --no-merges --oneline
2019-10-04 bkonyi@google.com Roll src/third_party/dart b4688e9172..7a7dcd1ed9 (5 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

ea305c50

a0605af40 Roll src/third_party/skia d71344590a2f..35a60f622c58 (9 commits)... · 3a728a9b

engine-flutter-autoroll authored Oct 04, 2019

a0605af40 Roll src/third_party/skia d71344590a2f..35a60f622c58 (9 commits) (flutter/engine#12784) (#41958)

git@github.com:flutter/engine.git/compare/9db06370490d...a0605af402ac

git log 9db06370490d..a0605af402ac --no-merges --oneline
2019-10-04 skia-flutter-autoroll@skia.org Roll src/third_party/skia d71344590a2f..35a60f622c58 (9 commits) (flutter/engine#12784)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

3a728a9b

Revert "replace package:vm_service_client with package:vm_service in the... · f25812ba
Jonah Williams authored Oct 04, 2019
```
Revert "replace package:vm_service_client with package:vm_service in the devicelab project (#41646)" (#41960)
```
f25812ba

9db063704 Roll src/third_party/dart 7376167b2a..b4688e9172 (4 commits) (#41957) · 96b4e8cf

engine-flutter-autoroll authored Oct 04, 2019


git@github.com:flutter/engine.git/compare/2e163b27805b...9db06370490d

git log 2e163b27805b..9db06370490d --no-merges --oneline
2019-10-04 bkonyi@google.com Roll src/third_party/dart 7376167b2a..b4688e9172 (4 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

96b4e8cf

replace package:vm_service_client with package:vm_service in the devicelab project (#41646) · 4de496a4
Devon Carew authored Oct 04, 2019

4de496a4

added questions on Platform / OS Version / Device (#41651) · 2713ee61

escamoteur authored Oct 04, 2019

* added questions on Platform / OS Version / Design

* changed following the comments

* removed the host platform question

2713ee61

Use `mergeResourcesProvider` instead of deprecated `mergeResources` (#41942) · 00f82d90
Emmanuel Garcia authored Oct 04, 2019

00f82d90
Include embedding transitive dependencies in plugins (#41885) · ed49a795
Emmanuel Garcia authored Oct 04, 2019

ed49a795
Add Profile entry to macOS Podfile (#41747) · 18d6d9bc
stuartmorgan authored Oct 04, 2019

18d6d9bc
Revert ActivateAction PR (#41945) · 3e2dc8ca
Greg Spencer authored Oct 04, 2019

3e2dc8ca

Roll engine 62e58c5d9fc2..2e163b27805b (4 commits) (#41954) · 780bddcc

engine-flutter-autoroll authored Oct 04, 2019

git@github.com:flutter/engine.git/compare/62e58c5d9fc2...2e163b27805b

git log 62e58c5d9fc2..2e163b27805b --no-merges --oneline
2019-10-04 dnfield@google.com Revert "Build AOT and test targets, generate FARs when building Fuchsia (#12761)" (flutter/engine#12781)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Enabled people to chose if SystemNavigator.pop is animated on iOS. (flutter/engine#12752)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Added some thread asserts to the code and made ios_surface_ safe since (flutter/engine#12775)
2019-10-03 dnfield@google.com Build AOT and test targets, generate FARs when building Fuchsia (flutter/engine#12761)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

780bddcc

Deflake web_fs_test.dart in flutter_tools (#41952) · db9ad60b
Jonah Williams authored Oct 04, 2019

db9ad60b
Update label applied for performance template bugs (#41717) · 6048b62e
Dan Field authored Oct 04, 2019

6048b62e
Fix CupertinoActivityIndicator radius (#41892) · 97d191de
LongCatIsLooong authored Oct 04, 2019

97d191de

Roll engine 8aa47326ae73..62e58c5d9fc2 (3 commits) (#41949) · d85d6eb4

engine-flutter-autoroll authored Oct 04, 2019

git@github.com:flutter/engine.git/compare/8aa47326ae73...62e58c5d9fc2

git log 8aa47326ae73..62e58c5d9fc2 --no-merges --oneline
2019-10-03 bkonyi@google.com Roll src/third_party/dart 07a63a17a4..7376167b2a (8 commits)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 35e0a58278a3..d71344590a2f (11 commits) (flutter/engine#12774)
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from p319_... to VkAgX... (flutter/engine#12778)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

d85d6eb4

Set DEFINES_MODULE=YES in plugin templates (#41828) · 4331c172
Jenn Magder authored Oct 04, 2019

4331c172

Roll engine 7d67e275ff82..8aa47326ae73 (7 commits) (#41944) · f8c75305

engine-flutter-autoroll authored Oct 04, 2019

git@github.com:flutter/engine.git/compare/7d67e275ff82...8aa47326ae73

git log 7d67e275ff82..8aa47326ae73 --no-merges --oneline
2019-10-03 chinmaygarde@google.com Fix Metal builds. (flutter/engine#12777)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Revert "Manage resource and onscreen contexts using separate IOSGLContext objects (#12277)" (flutter/engine#12773)
2019-10-03 bkonyi@google.com Roll src/third_party/dart afac6a3714..07a63a17a4 (6 commits)
2019-10-03 dnfield@google.com roll buildroot to 01e923507b28e5d1d3fe7597d2db2b30b0a543e9 (flutter/engine#12771)
2019-10-03 jonahwilliams@google.com Create a package-able incremental compiler (flutter/engine#12681)
2019-10-03 47866232+chunhtai@users.noreply.github.com add windows embedding test (flutter/engine#12423)
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from g-PD1... to wYLiQ... (flutter/engine#12770)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

f8c75305

03 Oct, 2019 9 commits

Refactor: Make MouseTracker test concise with some utility functions (#41791) · 297fe91f
Tong Mu authored Oct 03, 2019
```
* Extract pointerData and _equalToEventsOnCriticalFields for simplicity
```
297fe91f
Upload x64 android host release (#41933) · 6edd79ab
Jonah Williams authored Oct 03, 2019

6edd79ab

7d67e275f Roll src/third_party/skia cb55010652b2..35e0a58278a3 (2 commits)... · 32ad3db8

engine-flutter-autoroll authored Oct 03, 2019

7d67e275f Roll src/third_party/skia cb55010652b2..35e0a58278a3 (2 commits) (flutter/engine#12769) (#41929)

git@github.com:flutter/engine.git/compare/623be87e65e6...7d67e275ff82

git log 623be87e65e6..7d67e275ff82 --no-merges --oneline
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia cb55010652b2..35e0a58278a3 (2 commits) (flutter/engine#12769)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

32ad3db8

Roll engine e9edb8e14f6d..623be87e65e6 (12 commits) (#41928) · 2a7395ca

engine-flutter-autoroll authored Oct 03, 2019

git@github.com:flutter/engine.git/compare/e9edb8e14f6d...623be87e65e6

git log e9edb8e14f6d..623be87e65e6 --no-merges --oneline
2019-10-03 bkonyi@google.com Roll src/third_party/dart 967673c005..afac6a3714 (2 commits)
2019-10-03 bkonyi@google.com Roll src/third_party/dart 97bb624cfe..967673c005 (16 commits)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 087aa99a21ca..cb55010652b2 (1 commits) (flutter/engine#12766)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia f070cbec0708..087aa99a21ca (2 commits) (flutter/engine#12765)
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from EeMsz... to p319_... (flutter/engine#12764)
2019-10-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from AGoPT... to g-PD1... (flutter/engine#12763)
2019-10-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 40d1246d0c80..f070cbec0708 (10 commits) (flutter/engine#12762)
2019-10-03 bkonyi@google.com Roll src/third_party/dart 2e99a418a0..97bb624cfe (5 commits)
2019-10-03 30870216+gaaclarke@users.noreply.github.com Expanded channel buffer resize to method channels. (flutter/engine#12725)
2019-10-02 bkonyi@google.com Roll src/third_party/dart eaf1c308ab..2e99a418a0 (6 commits)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia ce240cc6fd8e..40d1246d0c80 (4 commits) (flutter/engine#12755)
2019-10-02 chinmaygarde@google.com Fix Metal builds by accounting for the updated SubmitFrame signature. (flutter/engine#12754)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

2a7395ca

[web] Make it clear that lowercase "r" can also perform hot restart (#41815) · 61d364f3
Mouad Debbar authored Oct 03, 2019

61d364f3
Allow customization of label styles for semantics debugger (#41730) · 6b09543e
Mehmet Fidanboylu authored Oct 03, 2019

6b09543e
[flutter_tools] Add more info to pub get failure event (#41652) · c7c8a6c4
Zachary Anderson authored Oct 03, 2019

c7c8a6c4
Make output directory a build input (#41862) · 517c08e8
Jonah Williams authored Oct 03, 2019

517c08e8

Roll engine 73dd5a33d9d1..e9edb8e14f6d (3 commits) (#41860) · 439dc5cf

engine-flutter-autoroll authored Oct 03, 2019

git@github.com:flutter/engine.git/compare/73dd5a33d9d1...e9edb8e14f6d

git log 73dd5a33d9d1..e9edb8e14f6d --no-merges --oneline
2019-10-02 mouad.debbar@gmail.com Support correct keymap for web (flutter/engine#12712)
2019-10-02 garyq@google.com Explain vertical font metrics and refactor UpdateLineMetrics. (flutter/engine#11795)
2019-10-02 mouad.debbar@gmail.com [web] Don't require felt to be in PATH (flutter/engine#12753)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

439dc5cf

02 Oct, 2019 2 commits

Return WidgetSpans from getSpanForPosition (#40635) · fa7340a3
Gary Qian authored Oct 02, 2019

fa7340a3

Roll engine aa8fcbb65283..73dd5a33d9d1 (4 commits) (#41856) · fe46eba6

engine-flutter-autoroll authored Oct 02, 2019

git@github.com:flutter/engine.git/compare/aa8fcbb65283...73dd5a33d9d1

git log aa8fcbb65283..73dd5a33d9d1 --no-merges --oneline
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from LSKbP... to EeMsz... (flutter/engine#12751)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia a1ea0a96f490..ce240cc6fd8e (13 commits) (flutter/engine#12750)
2019-10-02 bkonyi@google.com Roll src/third_party/dart 98b286de21..eaf1c308ab (5 commits)
2019-10-02 yjbanov@google.com Add web implementation for channel_buffers.dart (flutter/engine#12747)

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

fe46eba6