Commits · f53335bff482b42e01b0e921e863b3ff3cec7ec6 · abdullh.alsoleman / Front-End

04 May, 2023 10 commits

Roll Flutter Engine from ee646f9dd4c0 to 31de1c79ad56 (1 revision) (#126060) · f53335bf

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/ee646f9dd4c0...31de1c79ad56

2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 02e4b3087869 to 6950f56ad2ec (1 revision) (flutter/engine#41729)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f53335bf

Roll Flutter Engine from a344b0df36f1 to ee646f9dd4c0 (3 revisions) (#126057) · accc9432

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/a344b0df36f1...ee646f9dd4c0

2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 5c0f4c9bdc35 to 02e4b3087869 (1 revision) (flutter/engine#41728)
2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 9b19c0a0acf0 to 5c0f4c9bdc35 (1 revision) (flutter/engine#41727)
2023-05-04 skia-flutter-autoroll@skia.org Roll Dart SDK from 59787216f670 to 47da769ae13a (2 revisions) (flutter/engine#41726)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

accc9432

Roll Flutter Engine from b764b9cd2c45 to a344b0df36f1 (1 revision) (#126048) · dbd1d534

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/b764b9cd2c45...a344b0df36f1

2023-05-04 skia-flutter-autoroll@skia.org Roll Skia from 93c869da03f5 to 9b19c0a0acf0 (14 revisions) (flutter/engine#41725)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dbd1d534

Switch imports from test_api to focused libaries (#125854) · 2089eacc

Nate Bosch authored May 04, 2023

Move imports of API available in `hooks.dart` or `scaffolding.dart` to use those more narrow libraries.

Move imports of APIs from `package:matcher` to import directly. The next major version of `test_api` will remove the exports of `matcher` APIs.

2089eacc

Roll Flutter Engine from 4152b851e78e to b764b9cd2c45 (1 revision) (#126045) · f309eadf

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/4152b851e78e...b764b9cd2c45

2023-05-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from n1UnzmslAzt04yRv6... to LIacrdFhuTuHnYh0B... (flutter/engine#41724)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from n1UnzmslAzt0 to LIacrdFhuTuH

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f309eadf

Roll Flutter Engine from da45a21708f2 to 4152b851e78e (1 revision) (#126042) · d51c59c7

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/da45a21708f2...4152b851e78e

2023-05-04 jacksongardner@google.com Populate fallback fonts from CIPD in tests (flutter/engine#41656)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d51c59c7

Roll Flutter Engine from ee65be7d8fb1 to da45a21708f2 (3 revisions) (#126037) · ebf3ea17

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/ee65be7d8fb1...da45a21708f2

2023-05-04 dnfield@google.com Make run_tests.py assert that the ios test dylib is at least as new as libFlutter.dylib (flutter/engine#41720)
2023-05-04 bdero@google.com [Impeller] Remove the DrawPaint->Clear optimization (flutter/engine#41711)
2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 3cfcfb24bc6a to 59787216f670 (2 revisions) (flutter/engine#41718)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ebf3ea17

Roll Flutter Engine from 85516ecc0e4c to ee65be7d8fb1 (2 revisions) (#126032) · 15386d9d

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/85516ecc0e4c...ee65be7d8fb1

2023-05-03 godofredoc@google.com Add relative path support for malioc_diff. (flutter/engine#41703)
2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from WAfNudyWPOGyWSpZD... to LCajvqTauUudC-7RW... (flutter/engine#41716)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from WAfNudyWPOGy to LCajvqTauUud

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15386d9d

[tool] consistently use environment (not globals) in targets/web.dart (#125937) · 5816da80
Kevin Moore authored May 04, 2023
```
Also update the order of args to commands so that testing has less repeated "stuff"
```
5816da80

Roll Flutter Engine from a0906bdfc845 to 85516ecc0e4c (1 revision) (#126027) · 8449623e

engine-flutter-autoroll authored May 04, 2023

https://github.com/flutter/engine/compare/a0906bdfc845...85516ecc0e4c

2023-05-03 dkwingsmt@users.noreply.github.com [macOS] Remove view ID from public (flutter/engine#41712)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8449623e

03 May, 2023 22 commits

Remove `complex_layout_*__compile` benchmarks (#126023) · 4f3c989b
Jenn Magder authored May 03, 2023
```
Fixes https://github.com/flutter/flutter/issues/126020.
```
4f3c989b

Roll Flutter Engine from 7d70dc81cfa5 to a0906bdfc845 (8 revisions) (#126018) · d6ef15ed

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/7d70dc81cfa5...a0906bdfc845

2023-05-03 bdero@google.com [Impeller] Load instead of restore drawing for non-MSAA passes (flutter/engine#41676)
2023-05-03 jonahwilliams@google.com Remove physical model layer (flutter/engine#41593)
2023-05-03 gspencergoog@users.noreply.github.com Reland: "Determine lifecycle by looking at window focus also" (#41094) (flutter/engine#41702)
2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 887e58fff02f to 93c869da03f5 (12 revisions) (flutter/engine#41705)
2023-05-03 mdebbar@google.com [web] Improve null safety for color->css (flutter/engine#41699)
2023-05-03 mdebbar@google.com [web] Remove unused function parameter (flutter/engine#41700)
2023-05-03 godofredoc@google.com Migrate Android Engine Debug to Engine V2. (flutter/engine#41687)
2023-05-03 kjlubick@users.noreply.github.com Migrate SkSurface::getBackend* methods to static functions (flutter/engine#41693)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d6ef15ed

[tool] Improve help info with build web --wasm flags (#125907) · 2c56a25d
Kevin Moore authored May 03, 2023
```
Also fixed some comments
```
2c56a25d
tool: use switch expressions (#125930) · 0f9d66aa
Kevin Moore authored May 03, 2023

0f9d66aa

[Reland] Add migrator to upgrade gradle version when conflict with Android... · c12488a7

gmackall authored May 03, 2023

[Reland] Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected (#125836)

This is an attempt to reland https://github.com/flutter/flutter/pull/124085.

Differences from this attempt and the last: 
1. Adds a check for null android studio versions and a test for this case.
2. Wraps the migrate code in a try-catch [per the suggestion here](https://github.com/flutter/flutter/pull/125728/files#r1181747899).

Old PR description:
This PR adds an android project migrator that checks the version of android studio and the version of gradle for conflicts, and upgrades to 7.4 if a conflict is detected. For more detail about the particular conflict, see https://github.com/flutter/flutter/issues/122376.

The PR also upgrades older gradle versions being used in integration testing to 7.4.

Fixes/related to: https://github.com/flutter/flutter/issues/122376 and https://github.com/flutter/flutter/issues/123636

c12488a7

tool: DRY up DepfileService (#125922) · 4bd9bcd7
Kevin Moore authored May 03, 2023

4bd9bcd7

Add `InlineSpan.visitDirectChildren` (#125656) · f704c689

LongCatIsLooong authored May 03, 2023

I'd like to find out the `fontSize` of a `PlaceholderSpan`, and currently there doesn't seem to be a way to do `TextStyle` cascading in the framework:

 `InlineSpan.visitChildren` traverses the entire `InlineSpan` tree using a preorder traversal, and nodes that don't have "content" will be skipped (https://master-api.flutter.dev/flutter/painting/InlineSpan/visitChildren.html): 

> Walks this [InlineSpan](https://master-api.flutter.dev/flutter/painting/InlineSpan-class.html) and any descendants in pre-order and calls visitor for each span that has content.

which makes it impossible to do `TextStyle` cascading in the framework: 
- `InlineSpan`s with a non-null `TextStyle` but has no content will be skipped
- `visitChildren` doesn't directly expose the hierarchy, it only gives information about the flattened tree.

This doesn't look like a breaking change, most internal customers are extending `WidgetSpan` which has a concrete implementation of the new method.

Alternatively I could create a fake `ui.ParagraphBuilder` and record the `ui.TextStyle` at the top of the stack when `addPlaceholder` is called. But `ui.TextStyle` properties are not exposed to the framework.

f704c689

add slsa l1 badge (#125932) · 7815699d
godofredoc authored May 03, 2023
```
Adds SLSA L1 badge
```
7815699d

Roll Flutter Engine from b71728bee873 to 7d70dc81cfa5 (3 revisions) (#125989) · affb3436

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/b71728bee873...7d70dc81cfa5

2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 342dff83c38e to 3cfcfb24bc6a (1 revision) (flutter/engine#41698)
2023-05-03 joshualitt@google.com [web] Add `dart:js_interop_unsafe` to SDK. (flutter/engine#41591)
2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9T4mGpfsJZO0KPtfp... to n1UnzmslAzt04yRv6... (flutter/engine#41697)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 9T4mGpfsJZO0 to n1UnzmslAzt0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

affb3436

Roll Packages from f163786731b8 to 407b7da0079e (13 revisions) (#125988) · fd7efc6f

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/packages/compare/f163786731b8...407b7da0079e

2023-05-03 vashworth@google.com Update Cirrus to Xcode 14.3 (flutter/packages#3890)
2023-05-03 stuartmorgan@google.com [file_selector] Deprecates `macUTIs` (flutter/packages#3888)
2023-05-03 41930132+hellohuanlin@users.noreply.github.com [pigeon]enable treat warning as errors for swift code in unit test (flutter/packages#3889)
2023-05-02 vashworth@google.com Update xcode to 14e222b (flutter/packages#3868)
2023-05-02 41930132+hellohuanlin@users.noreply.github.com [pigeon]fix "as Any" workaround due to nested optional (flutter/packages#3658)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to accept third party cookies (flutter/packages#3834)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes an exception caused by the `onUrlChange` callback returning a null url (flutter/packages#3848)
2023-05-02 pateltirth454@gmail.com [google_maps_flutter] [Docs] Note regarding usage within a bounded & an unbound widget (flutter/packages#3691)
2023-05-02 evace93@gmail.com [local_auth_android] Fix Android lint warnings (flutter/packages#3764)
2023-05-02 koji.wakamiya@gmail.com [go_router_builder] Support go_router v7 (flutter/packages#3858)
2023-05-02 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes internal enum type and adds unknown enum values (flutter/packages#3812)
2023-05-02 stuartmorgan@google.com [file_selector] Add MIME type support on macOS (flutter/packages#3862)
2023-05-02 engine-flutter-autoroll@skia.org Roll Flutter from 828a0404 to db6074ad (12 revisions) (flutter/packages#3881)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd7efc6f

Marks Linux_android slider_perf_android to be unflaky (#125968) · 15bd29c8

Flutter GitHub Bot authored May 03, 2023

<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux_android slider_perf_android"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux_android%20slider_perf_android%22).
This test can be marked as unflaky.

15bd29c8

Adding printOnFailure for result of process (#125910) · 9160c6e7

Elias Yishak authored May 03, 2023

Adding a `printOnFailure` call into the flakey test to help debug the cause for future failures.

- Reference issue: https://github.com/flutter/flutter/issues/125512

9160c6e7

Roll Flutter Engine from bc8f14001d7a to b71728bee873 (1 revision) (#125972) · c4d6c8c6

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/bc8f14001d7a...b71728bee873

2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 4d084f5b8f91 to 342dff83c38e (2 revisions) (flutter/engine#41692)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c4d6c8c6

Roll Flutter Engine from 99e5184c7aa8 to bc8f14001d7a (2 revisions) (#125969) · c4ad07dc

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/99e5184c7aa8...bc8f14001d7a

2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ubfKertFqqUj0WD8I... to WAfNudyWPOGyWSpZD... (flutter/engine#41691)
2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from b58340991480 to 887e58fff02f (2 revisions) (flutter/engine#41690)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from ubfKertFqqUj to WAfNudyWPOGy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c4ad07dc

Roll Flutter Engine from 0407a16a9b5e to 99e5184c7aa8 (3 revisions) (#125954) · bea17cc9

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/0407a16a9b5e...99e5184c7aa8

2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 3c1ecab42cd4 to b58340991480 (1 revision) (flutter/engine#41689)
2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 7781dda8104f to 3c1ecab42cd4 (2 revisions) (flutter/engine#41688)
2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 7c061d8c9dc0 to 4d084f5b8f91 (1 revision) (flutter/engine#41686)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bea17cc9

`ModalBarrier`'s gesture recognizer does not call `invokeCallback` (#125386) · 4d38f94e

fzyzcjy authored May 03, 2023

Close #125385 - please see explanations there :)

If you think this PR looks OK, I will polish it (e.g. copy-and-paste-and-modify the tests shown in #125385 into here and make CI pass)

4d38f94e

Roll Flutter Engine from 228da31894f7 to 0407a16a9b5e (1 revision) (#125941) · 110fe75b

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/228da31894f7...0407a16a9b5e

2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 54c32e41eced to 7781dda8104f (1 revision) (flutter/engine#41684)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

110fe75b

Allow .xcworkspace and .xcodeproj to be renamed from default name 'Runner' (#124533) · c9b132d0

LouiseHsu authored May 03, 2023

Adds the ability to rename Runner.xcodeproj and Runner.xcworkspace - fixes https://github.com/flutter/flutter/issues/9767.

To rename a project:
1. Open Runner.xcodeproj in Xcode
2. In the left panel, left click "Show File Inspector" 
<img width="441" alt="Screenshot 2023-04-17 at 11 41 07 PM" src="https://user-images.githubusercontent.com/36148254/232692957-8743742d-c3ef-42e5-833f-dff31aeb2b6a.png">
3. In the right panel, the name of the project, "Runner", should be visible under "Identity and Type". Change the name and press enter.
<img width="299" alt="Screenshot 2023-04-17 at 11 40 43 PM" src="https://user-images.githubusercontent.com/36148254/232693315-b6a71165-f5e3-4a0f-8954-2f3eee5b67cf.png">
4. A wizard should pop up. Click Rename.
<img width="573" alt="Screenshot 2023-04-17 at 11 44 01 PM" src="https://user-images.githubusercontent.com/36148254/232693381-bb9cf026-2a75-4844-b42d-ae0036ae9fdd.png">
To rename the workspace:

1. Make sure Xcode is closed.
2. Rename the .xcworkspace to your new name.

If you also renamed the project

&nbsp; 3. Reopen the .xcworkspace in Xcode. If the selected project is the old name and in red, update it to match the new project name.

Tests for schemeFor were changed as with Xcode 14, in some cases the scheme will be renamed along with the project. Thus we will get the best match scheme for either the project name, or the default name Runner. However if a flavor is present, the scheme should always match the flavor.

c9b132d0

Report total_ui_gc_time to SkiaPerf (#125919) · aef7929f
Zachary Anderson authored May 03, 2023
```
Not sure why this wasn't already being reported.
```
aef7929f

Roll Flutter Engine from fb3002443fcc to 228da31894f7 (1 revision) (#125936) · 707261fa

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/fb3002443fcc...228da31894f7

2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 089b9cca26fe to 54c32e41eced (3 revisions) (flutter/engine#41683)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

707261fa

Roll Flutter Engine from 7e77d838df3a to fb3002443fcc (3 revisions) (#125934) · b2e01939

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/7e77d838df3a...fb3002443fcc

2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from g_6rn9e-GBQGQGwgt... to 9T4mGpfsJZO0KPtfp... (flutter/engine#41679)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from ea1fce8e0aa7 to 7c061d8c9dc0 (1 revision) (flutter/engine#41677)
2023-05-02 ianloic@google.com [fuchsia] fix run_integration_test.sh (flutter/engine#41668)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from g_6rn9e-GBQG to 9T4mGpfsJZO0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b2e01939

Roll Flutter Engine from c4a2712e8f4d to 7e77d838df3a (2 revisions) (#125925) · 0a77373f

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/c4a2712e8f4d...7e77d838df3a

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from 644e199b6832 to 089b9cca26fe (14 revisions) (flutter/engine#41675)
2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from moQlKaNgpc0WD3sjC... to ubfKertFqqUj0WD8I... (flutter/engine#41674)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from moQlKaNgpc0W to ubfKertFqqUj

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0a77373f

02 May, 2023 8 commits

Roll Flutter Engine from cd989fbc80bf to c4a2712e8f4d (3 revisions) (#125909) · 68cf636d

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/cd989fbc80bf...c4a2712e8f4d

2023-05-02 leroux_bruno@yahoo.fr Web - Fix selection jump on Chrome for Android (flutter/engine#41202)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 84f3080c3165 to ea1fce8e0aa7 (1 revision) (flutter/engine#41672)
2023-05-02 magder@google.com Stop specifiying Macmini8,1 in ci builders, use inherited mac_model dimension (flutter/engine#41223)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

68cf636d

Update xcode to 14e222b (#125716) · 9fcb42d0
Chris Yang authored May 02, 2023
```
Framework part of https://github.com/flutter/flutter/issues/125814
```
9fcb42d0

Clarify Visual Studio isn't strictly necessary for Windows development (#125837) · f94112e5

Loïc Sharma authored May 02, 2023

Update `flutter doctor` to clarify that Visual Studio is needed only if creating Windows apps. Windows users targeting Android do not need to install Visual Studio.

f94112e5

Mark microbenchmarks_ios unflaky (#125332) · cc9a3d9d
Jenn Magder authored May 02, 2023
```
This hasn't flaked for > 50 commits which is our threshhold.  Marking as unflaky.
```
cc9a3d9d

Roll Flutter Engine from 6fe3f5079792 to cd989fbc80bf (1 revision) (#125894) · c5183601

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/6fe3f5079792...cd989fbc80bf

2023-05-02 godofredoc@google.com Migrate Linux Android AOT Engine to engine V2. (flutter/engine#41638)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c5183601

Mark build_test builds as bringup. (#125898) · d0069bec

godofredoc authored May 02, 2023

They require an additional dimension to be passed as part of the
.ci.yaml configuration.

Bug: https://github.com/flutter/flutter/issues/125897

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

d0069bec

Align the Popup Menu under its child (#125534) · 00cd3eda

Valentin Vignal authored May 02, 2023

Align the `PopupMenu` under its child.

Before:

![image](https://user-images.githubusercontent.com/32538273/234468262-beddb257-5f5a-422f-a678-c26efc52dc07.png)

After:

![image](https://user-images.githubusercontent.com/32538273/234468233-3ea4d741-b04c-4012-bdd7-a36ecedc029c.png)

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/125474

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

00cd3eda

Roll Flutter Engine from 53c192f41f96 to 6fe3f5079792 (2 revisions) (#125888) · 25bbe5c5

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/53c192f41f96...6fe3f5079792

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from c574ba686a93 to 644e199b6832 (1 revision) (flutter/engine#41666)
2023-05-02 jason-simmons@users.noreply.github.com Clone the parent Android engine's asset provider into a spawned engine (flutter/engine#41642)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

25bbe5c5