Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
aef7929f
Unverified
Commit
aef7929f
authored
May 03, 2023
by
Zachary Anderson
Committed by
GitHub
May 03, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Report total_ui_gc_time to SkiaPerf (#125919)
Not sure why this wasn't already being reported.
parent
707261fa
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
7 additions
and
0 deletions
+7
-0
perf_tests.dart
dev/devicelab/lib/tasks/perf_tests.dart
+5
-0
perf_tests_test.dart
dev/devicelab/test/perf_tests_test.dart
+2
-0
No files found.
dev/devicelab/lib/tasks/perf_tests.dart
View file @
aef7929f
...
...
@@ -936,6 +936,7 @@ class PerfTest {
this
.
timelineFileName
,
{
this
.
measureCpuGpu
=
true
,
this
.
measureMemory
=
true
,
this
.
measureTotalGCTime
=
true
,
this
.
saveTraceFile
=
false
,
this
.
testDriver
,
this
.
needsFullTimeline
=
true
,
...
...
@@ -953,6 +954,7 @@ class PerfTest {
this
.
testTarget
,
{
this
.
measureCpuGpu
=
false
,
this
.
measureMemory
=
false
,
this
.
measureTotalGCTime
=
false
,
this
.
testDriver
=
'test_driver/e2e_test.dart'
,
this
.
needsFullTimeline
=
false
,
this
.
benchmarkScoreKeys
=
_kCommonScoreKeys
,
...
...
@@ -979,6 +981,8 @@ class PerfTest {
final
bool
measureCpuGpu
;
/// Whether to collect memory metrics.
final
bool
measureMemory
;
/// Whether to summarize total GC time on the UI thread from the timeline.
final
bool
measureTotalGCTime
;
/// Whether to collect full timeline, meaning if `--trace-startup` flag is needed.
final
bool
needsFullTimeline
;
/// Whether to save the trace timeline file `*.timeline.json`.
...
...
@@ -1114,6 +1118,7 @@ class PerfTest {
if
(
data
[
'90th_percentile_memory_usage'
]
!=
null
)
'90th_percentile_memory_usage'
,
if
(
data
[
'99th_percentile_memory_usage'
]
!=
null
)
'99th_percentile_memory_usage'
,
],
if
(
measureTotalGCTime
)
'total_ui_gc_time'
,
if
(
data
[
'30hz_frame_percentage'
]
!=
null
)
'30hz_frame_percentage'
,
if
(
data
[
'60hz_frame_percentage'
]
!=
null
)
'60hz_frame_percentage'
,
if
(
data
[
'80hz_frame_percentage'
]
!=
null
)
'80hz_frame_percentage'
,
...
...
dev/devicelab/test/perf_tests_test.dart
View file @
aef7929f
...
...
@@ -52,6 +52,7 @@ void main() {
'90th_percentile_picture_cache_memory'
:
1
,
'99th_percentile_picture_cache_memory'
:
1
,
'worst_picture_cache_memory'
:
1
,
'total_ui_gc_time'
:
1
,
'new_gen_gc_count'
:
1
,
'old_gen_gc_count'
:
1
,
'average_vsync_transitions_missed'
:
1
,
...
...
@@ -95,6 +96,7 @@ void main() {
'90th_percentile_picture_cache_memory'
:
1
,
'99th_percentile_picture_cache_memory'
:
1
,
'worst_picture_cache_memory'
:
1
,
'total_ui_gc_time'
:
1
,
'new_gen_gc_count'
:
1
,
'old_gen_gc_count'
:
1
,
'average_vsync_transitions_missed'
:
1
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment