1. 28 Sep, 2019 5 commits
  2. 27 Sep, 2019 23 commits
  3. 26 Sep, 2019 12 commits
    • Jonah Williams's avatar
    • engine-flutter-autoroll's avatar
      Roll engine 5b5fd7508c63..0018135a1c28 (3 commits) (#41416) · 194256cc
      engine-flutter-autoroll authored
      
      git@github.com:flutter/engine.git/compare/5b5fd7508c63...0018135a1c28
      
      git log 5b5fd7508c63..0018135a1c28 --no-merges --oneline
      2019-09-26 garyq@google.com Make kDoNotResizeDimension public so framework can use it directly (flutter/engine#12448)
      2019-09-26 skia-flutter-autoroll@skia.org Roll src/third_party/skia 559ffe4a23ce..ec85f407bfee (44 commits) (flutter/engine#12463)
      2019-09-26 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from PyQPO... to YDv3O... (flutter/engine#12462)
      
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC aaclarke@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      194256cc
    • engine-flutter-autoroll's avatar
      Roll engine b126ba758533..5b5fd7508c63 (2 commits) (#41412) · 26465f4c
      engine-flutter-autoroll authored
      
      git@github.com:flutter/engine.git/compare/b126ba758533...5b5fd7508c63
      
      git log b126ba758533..5b5fd7508c63 --no-merges --oneline
      2019-09-26 chinmaygarde@google.com Revert "Support accessibility labels on iOS switches. (#12404)" (flutter/engine#12466)
      2019-09-26 1036976+brandondiamond@users.noreply.github.com Support accessibility labels on iOS switches. (flutter/engine#12404)
      
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC aaclarke@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      26465f4c
    • Greg Spencer's avatar
      Change the way ActionDispatcher is found. (#41245) · a0856358
      Greg Spencer authored
      This changes the way ActionDispatchers are found by the Actions widget, so that by default it will look for dispatchers of the parent Actions widgets instead of just creating a default ActionDispatcher. This allows overriding of the ActionDispatcher at the top level: before, the custom action dispatcher would only be invoked if explicitly set on all the Actions widgets.
      
      This is not a breaking change because there was a default value to the dispatcher parameter before that performed this function, and not specifying the dispatcher anywhere will still result in a default dispatcher being created.
      a0856358
    • Greg Spencer's avatar
      Added proper focus handling when pushing and popping routes (#40166) · 1a7bb1f5
      Greg Spencer authored
      The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped.
      
      This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node.
      
      This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
      1a7bb1f5
    • Jonah Williams's avatar
    • stuartmorgan's avatar
      Add the beginnings of plugin support for Windows and Linux (#41015) · 56d68a90
      stuartmorgan authored
      Adds very preliminary support for Windows and Linux plugins:
      - Adds those platforms to the new plugin schema, initially supporting just a plugin class.
      - Adds C++ plugin registrant generation for any Windows or Linux plugins found.
      
      This doesn't have yet have any build tooling for either platform, so anyone using the generated registrant still needs to do manual build configuration. This reduces the manual work, however, and creates a starting point for future tooling work.
      
      As with all Windows and Linux work at this time, this is not final, and subject to change without warning in the future (e.g., Windows could potentially switch to a C# interface, or
      'linux' may change to 'gtk' or 'linux_gtk' in pubspec.yaml).
      56d68a90
    • engine-flutter-autoroll's avatar
      b126ba758 Add .mskp file to binary format (flutter/engine#12454) (#41404) · 5a27e1c1
      engine-flutter-autoroll authored
      
      git@github.com:flutter/engine.git/compare/b520d7fd4b6d...b126ba758533
      
      git log b520d7fd4b6d..b126ba758533 --no-merges --oneline
      2019-09-26 liyuqian@google.com Add .mskp file to binary format (flutter/engine#12454)
      
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
      Please CC aaclarke@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
      5a27e1c1
    • Kristin Ho's avatar
      Prevent PointerEnter[or Exit]Event from erasing event.down value (#40637) (#41332) · 034358e3
      Kristin Ho authored
      * MouseRegion documentation claimed that onEnter and onExit
        would track entry and exit regardless of whether the pointer was
        down or up
      * It did such, but when grabbing the value of `event.down` from
        the passed event, the value was always `false`
      * PointerEnterEvent and PointerExitEvent were overriding the value
        passed from PointerEvent in constructors, even if the value was true
        e.g. in invocations of .fromMouseEvent((PointerMoveEvent...))
      * This change now passes the value along to PointerEnter/ExitEvents
        while providing it a default of false, and updates documentation
      
      Fixes #40637
      034358e3
    • Zachary Anderson's avatar
    • Jonah Williams's avatar
      Serve every html file under web (#41386) · 0980fa2d
      Jonah Williams authored
      0980fa2d
    • Greg Spencer's avatar
      Fix mouse hover to not schedule a frame for every mouse move. (#41014) · 05097916
      Greg Spencer authored
      This fixes the mouse hover code to not schedule frames with every mouse move.
      
      Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame.
      
      The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
      05097916