Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
efd2ba29
Unverified
Commit
efd2ba29
authored
Sep 26, 2019
by
Jonah Williams
Committed by
GitHub
Sep 26, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Flutter build bundle without --precompiled should always perform a debug build. (#41401)
parent
194256cc
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
1 deletion
+10
-1
bundle.dart
packages/flutter_tools/lib/src/bundle.dart
+4
-0
build_bundle.dart
packages/flutter_tools/lib/src/commands/build_bundle.dart
+4
-1
bundle_shim_test.dart
...es/flutter_tools/test/general.shard/bundle_shim_test.dart
+2
-0
No files found.
packages/flutter_tools/lib/src/bundle.dart
View file @
efd2ba29
...
...
@@ -89,6 +89,7 @@ class BundleBuilder {
flutterProject:
flutterProject
,
outputDir:
assetDirPath
,
depfilePath:
depfilePath
,
precompiled:
precompiledSnapshot
,
);
return
;
}
...
...
@@ -150,7 +151,10 @@ Future<void> buildWithAssemble({
@required
String
mainPath
,
@required
String
outputDir
,
@required
String
depfilePath
,
@required
bool
precompiled
,
})
async
{
// If the precompiled flag was not passed, force us into debug mode.
buildMode
=
precompiled
?
buildMode
:
BuildMode
.
debug
;
final
Environment
environment
=
Environment
(
projectDir:
flutterProject
.
directory
,
outputDir:
fs
.
directory
(
outputDir
),
...
...
packages/flutter_tools/lib/src/commands/build_bundle.dart
View file @
efd2ba29
...
...
@@ -21,7 +21,10 @@ class BuildBundleCommand extends BuildSubCommand {
usesBuildNumberOption
();
addBuildModeFlags
(
verboseHelp:
verboseHelp
);
argParser
..
addFlag
(
'precompiled'
,
negatable:
false
)
..
addFlag
(
'precompiled'
,
negatable:
false
,
help:
'If not provided, then '
'a debug build is always provided, regardless of build mode. If provided '
'then release is the default mode.'
)
// This option is still referenced by the iOS build scripts. We should
// remove it once we've updated those build scripts.
..
addOption
(
'asset-base'
,
help:
'Ignored. Will be removed.'
,
hide:
!
verboseHelp
)
...
...
packages/flutter_tools/test/general.shard/bundle_shim_test.dart
View file @
efd2ba29
...
...
@@ -39,6 +39,7 @@ void main() {
outputDir:
'example'
,
targetPlatform:
TargetPlatform
.
ios
,
depfilePath:
'example.d'
,
precompiled:
false
,
);
expect
(
fs
.
file
(
fs
.
path
.
join
(
'example'
,
'kernel_blob.bin'
)).
existsSync
(),
true
);
expect
(
fs
.
file
(
fs
.
path
.
join
(
'example'
,
'LICENSE'
)).
existsSync
(),
true
);
...
...
@@ -60,6 +61,7 @@ void main() {
outputDir:
'example'
,
targetPlatform:
TargetPlatform
.
linux_x64
,
depfilePath:
'example.d'
,
precompiled:
false
,
),
throwsA
(
isInstanceOf
<
ToolExit
>()));
}));
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment