Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
d7a8dda2
Unverified
Commit
d7a8dda2
authored
Sep 27, 2019
by
Jonah Williams
Committed by
GitHub
Sep 27, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Dont update last compiled time when compilation is rejected (#41424)
parent
a1852a19
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
4 additions
and
1 deletion
+4
-1
devfs.dart
packages/flutter_tools/lib/src/devfs.dart
+2
-1
devfs_test.dart
packages/flutter_tools/test/general.shard/devfs_test.dart
+2
-0
No files found.
packages/flutter_tools/lib/src/devfs.dart
View file @
d7a8dda2
...
...
@@ -465,7 +465,6 @@ class DevFS {
generator
.
reset
();
}
printTrace
(
'Compiling dart to kernel with
${invalidatedFiles.length}
updated files'
);
lastCompiled
=
DateTime
.
now
();
final
CompilerOutput
compilerOutput
=
await
generator
.
recompile
(
mainPath
,
invalidatedFiles
,
...
...
@@ -475,6 +474,8 @@ class DevFS {
if
(
compilerOutput
==
null
||
compilerOutput
.
errorCount
>
0
)
{
return
UpdateFSReport
(
success:
false
);
}
// Only update the last compiled time if we successfully compiled.
lastCompiled
=
DateTime
.
now
();
// list of sources that needs to be monitored are in [compilerOutput.sources]
sources
=
compilerOutput
.
sources
;
//
...
...
packages/flutter_tools/test/general.shard/devfs_test.dart
View file @
d7a8dda2
...
...
@@ -178,6 +178,7 @@ void main() {
testUsingContext
(
'reports unsuccessful compile when errors are returned'
,
()
async
{
devFS
=
DevFS
(
vmService
,
'test'
,
tempDir
);
await
devFS
.
create
();
final
DateTime
previousCompile
=
devFS
.
lastCompiled
;
final
RealMockResidentCompiler
residentCompiler
=
RealMockResidentCompiler
();
when
(
residentCompiler
.
recompile
(
...
...
@@ -197,6 +198,7 @@ void main() {
);
expect
(
report
.
success
,
false
);
expect
(
devFS
.
lastCompiled
,
previousCompile
);
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
fs
,
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment