1. 23 Aug, 2023 1 commit
  2. 09 Jun, 2023 1 commit
    • William Hesse's avatar
      [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (#128335) · 0d39f646
      William Hesse authored
      Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location.
      
      This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.
      
      Bug: #127683
      
      - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
      - [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
      - [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
      - [X ] I signed the [CLA].
      - [X ] I listed at least one issue that this PR fixes in the description above.
      - [X ] I updated/added relevant documentation (doc comments with `///`).
      0d39f646
  3. 16 May, 2023 1 commit
  4. 29 Mar, 2023 1 commit
  5. 22 Mar, 2023 1 commit
  6. 23 Feb, 2023 1 commit
  7. 15 Feb, 2023 1 commit
    • Ian Hickson's avatar
      Improve network resources doctor check (#120417) · d29668dd
      Ian Hickson authored
      ...and various other minor cleanup:
      
      * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing.
      
      * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too.
      
      * Made the logger delete the slow warning when it's finished.
      
      * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'.
      
      * Added a debug toString to ValidationResult for debugging purposes (not used).
      
      * In http_host_validator:
      
        - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev).
        - Added GitHub as a tested host since when you run `flutter` we hit that immediately.
        - Renamed the check "Network resources".
        - Updated the `slowWarning` of the check to say which hosts are pending.
        - Removed all timeout logic. Timeouts violate our style guide.
        - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient.
        - Replaced the `_HostValidationResult` class with `String?` for simplicity.
        - Improved the error messages to be more detailed.
        - Removed all checks that dependened on the stringification of exceptions. That's very brittle.
        - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks).
        - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result.
        - Replaced a lot of list-filtering logic with just a single for loop to check the results.
        - Replaced code that added a constant to a known-empty list with just returning a constant list.
        - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
      d29668dd
  8. 23 Jan, 2023 1 commit
  9. 11 Oct, 2022 1 commit
  10. 07 Sep, 2022 1 commit
  11. 02 Sep, 2022 1 commit
  12. 18 Jul, 2022 1 commit
  13. 27 Apr, 2022 1 commit
  14. 12 Apr, 2022 1 commit
  15. 31 Mar, 2022 1 commit
  16. 28 Mar, 2022 1 commit
  17. 22 Feb, 2022 1 commit
  18. 15 Dec, 2021 1 commit
  19. 11 Nov, 2021 1 commit
  20. 13 Jul, 2021 1 commit
  21. 12 Jul, 2021 1 commit
  22. 08 Jun, 2021 1 commit
  23. 01 Jun, 2021 1 commit
  24. 03 May, 2021 1 commit
  25. 23 Mar, 2021 1 commit
  26. 16 Mar, 2021 1 commit
  27. 08 Mar, 2021 1 commit
  28. 13 Feb, 2021 1 commit
  29. 27 Jan, 2021 1 commit
  30. 14 Jan, 2021 1 commit
  31. 20 Nov, 2020 1 commit
  32. 13 Oct, 2020 1 commit
  33. 09 Oct, 2020 1 commit
    • James D. Lin's avatar
      [flutter tools] Add a DelegatingLogger class (#67581) · e4206ac5
      James D. Lin authored
      [flutter tools] Add a DelegatingLogger class
      
      Move most of `DelegateLogger` `from test/src/testbed.dart` to
      `lib/src/base/logger.dart` to better formalize the common practice of
      chaining `Logger`s together.  I renamed the class since it isn't
      itself the delegate and to better match the `Delegating...` classes
      from `package:collection`.
      
      Additionally, add a freestanding `asLogger<T>` function to "cast" a
      `Logger` into a matching delegate if possible.  This will allow
      `Logger` chains to be ordered a *bit* more freely (e.g.
      `NotifyingLogger` and `AppRunLogger` will no longer required to be
      at the end of the chain, an unwritten rule that has led to breakage in
      google3).  Chain order still matters since lack of virtual dispatch
      means that parent `Logger`s can never invoke child methods, however.
      
      I made `asLogger<T>` a freestanding function because I didn't want to
      make it part of the `Logger` interface (and I thought that making it
      an extension method might be weird).
      
      Bonus cleanup:
      There no longer appears to be a way to construct an `AppRunLogger`
      with a null parent, so remove all of code paths for that case and
      make the `parent` construction parameter required.
      e4206ac5
  34. 13 Jul, 2020 1 commit
  35. 10 Jul, 2020 1 commit
  36. 09 Jun, 2020 1 commit
  37. 30 Mar, 2020 1 commit
  38. 19 Mar, 2020 3 commits