- 23 Aug, 2023 1 commit
-
-
Ian Hickson authored
-
- 09 Jun, 2023 1 commit
-
-
William Hesse authored
Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location. This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL. Bug: #127683 - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [X ] I signed the [CLA]. - [X ] I listed at least one issue that this PR fixes in the description above. - [X ] I updated/added relevant documentation (doc comments with `///`).
-
- 16 May, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 29 Mar, 2023 1 commit
-
-
Victoria Ashworth authored
Update device selection to wait for wireless devices to load
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 23 Feb, 2023 1 commit
-
-
Lioness100 authored
* Fix typos * lowercase animated & opacity * Undo typo fix --------- Co-authored-by:
Michael Goderbauer <goderbauer@google.com>
-
- 15 Feb, 2023 1 commit
-
-
Ian Hickson authored
...and various other minor cleanup: * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing. * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too. * Made the logger delete the slow warning when it's finished. * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'. * Added a debug toString to ValidationResult for debugging purposes (not used). * In http_host_validator: - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev). - Added GitHub as a tested host since when you run `flutter` we hit that immediately. - Renamed the check "Network resources". - Updated the `slowWarning` of the check to say which hosts are pending. - Removed all timeout logic. Timeouts violate our style guide. - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient. - Replaced the `_HostValidationResult` class with `String?` for simplicity. - Improved the error messages to be more detailed. - Removed all checks that dependened on the stringification of exceptions. That's very brittle. - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks). - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result. - Replaced a lot of list-filtering logic with just a single for loop to check the results. - Replaced code that added a constant to a known-empty list with just returning a constant list. - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
-
- 23 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
* dart fix --apply * manual fixes * fix after merge conflicts * review
-
- 11 Oct, 2022 1 commit
-
-
Jenn Magder authored
-
- 07 Sep, 2022 1 commit
-
-
Michael Thomsen authored
-
- 02 Sep, 2022 1 commit
-
-
Pierre-Louis authored
-
- 18 Jul, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Apr, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Apr, 2022 1 commit
-
-
Emmanuel Garcia authored
-
- 31 Mar, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 28 Mar, 2022 1 commit
-
-
Christopher Fujino authored
* warn when doctor takes long
-
- 22 Feb, 2022 1 commit
-
-
Tomasz Gucio authored
-
- 15 Dec, 2021 1 commit
-
-
Emmanuel Garcia authored
-
- 11 Nov, 2021 1 commit
-
-
Greg Spencer authored
-
- 13 Jul, 2021 1 commit
-
-
Jonah Williams authored
This reverts commit 53d8cba3.
-
- 12 Jul, 2021 1 commit
-
-
Jonah Williams authored
-
- 08 Jun, 2021 1 commit
-
-
Lau Ching Jun authored
-
- 01 Jun, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 03 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 23 Mar, 2021 1 commit
-
-
Jonah Williams authored
-
- 16 Mar, 2021 1 commit
-
-
Jonah Williams authored
-
- 08 Mar, 2021 1 commit
-
-
Jonah Williams authored
-
- 13 Feb, 2021 1 commit
-
-
Jonah Williams authored
-
- 27 Jan, 2021 1 commit
-
-
Jonah Williams authored
* opt out the flutter tool * oops EOF * fix import * Update tool_backend.dart * Update daemon_client.dart * fix more
-
- 14 Jan, 2021 1 commit
-
-
J-P Nurmi authored
-
- 20 Nov, 2020 1 commit
-
-
Jonah Williams authored
-
- 13 Oct, 2020 1 commit
-
-
Jonah Williams authored
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
-
- 09 Oct, 2020 1 commit
-
-
James D. Lin authored
[flutter tools] Add a DelegatingLogger class Move most of `DelegateLogger` `from test/src/testbed.dart` to `lib/src/base/logger.dart` to better formalize the common practice of chaining `Logger`s together. I renamed the class since it isn't itself the delegate and to better match the `Delegating...` classes from `package:collection`. Additionally, add a freestanding `asLogger<T>` function to "cast" a `Logger` into a matching delegate if possible. This will allow `Logger` chains to be ordered a *bit* more freely (e.g. `NotifyingLogger` and `AppRunLogger` will no longer required to be at the end of the chain, an unwritten rule that has led to breakage in google3). Chain order still matters since lack of virtual dispatch means that parent `Logger`s can never invoke child methods, however. I made `asLogger<T>` a freestanding function because I didn't want to make it part of the `Logger` interface (and I thought that making it an extension method might be weird). Bonus cleanup: There no longer appears to be a way to construct an `AppRunLogger` with a null parent, so remove all of code paths for that case and make the `parent` construction parameter required.
-
- 13 Jul, 2020 1 commit
-
-
Dan Field authored
* Optionally invert oversized images
-
- 10 Jul, 2020 1 commit
-
-
Jonah Williams authored
We have too many loggers, and the logger construction rules are too complicated to be untested. Capture these in a LoggerFactory and test that construction is correct.
-
- 09 Jun, 2020 1 commit
-
-
Jonah Williams authored
[flutter_tools] create NotifyingLogger at the top level when running flutter run --machine or flutter attach --machine (#59087) Removes dependency on injecting additional logger with zones
-
- 30 Mar, 2020 1 commit
-
-
Jonah Williams authored
-
- 19 Mar, 2020 3 commits
-
-
Jonah Williams authored
Reland of #52091
-
Jonah Williams authored
This reverts commit f65421aa.
-
Jonah Williams authored
Remove dependency injection from GenSnapshot and AotBuilder and update tests to use FakeProcessManager
-