Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
1efb3603
Unverified
Commit
1efb3603
authored
Nov 20, 2020
by
Jonah Williams
Committed by
GitHub
Nov 20, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] display message for current null safety mode (#70718)
parent
a5519dc7
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
31 additions
and
13 deletions
+31
-13
logger.dart
packages/flutter_tools/lib/src/base/logger.dart
+2
-1
resident_web_runner.dart
...s/flutter_tools/lib/src/isolated/resident_web_runner.dart
+13
-1
resident_runner.dart
packages/flutter_tools/lib/src/resident_runner.dart
+2
-9
run_hot.dart
packages/flutter_tools/lib/src/run_hot.dart
+13
-2
resident_runner_test.dart
...lutter_tools/test/general.shard/resident_runner_test.dart
+1
-0
No files found.
packages/flutter_tools/lib/src/base/logger.dart
View file @
1efb3603
...
...
@@ -418,7 +418,8 @@ class WindowsStdoutLogger extends StdoutLogger {
.
replaceAll
(
'🖼️'
,
''
)
.
replaceAll
(
'✗'
,
'X'
)
.
replaceAll
(
'✓'
,
'√'
)
.
replaceAll
(
'🔨'
,
''
);
.
replaceAll
(
'🔨'
,
''
)
.
replaceAll
(
'💪'
,
''
);
_stdio
.
stdoutWrite
(
windowsMessage
);
}
}
...
...
packages/flutter_tools/lib/src/isolated/resident_web_runner.dart
View file @
1efb3603
...
...
@@ -723,7 +723,7 @@ class _ResidentWebRunner extends ResidentWebRunner {
??
debuggingOptions
.
buildInfo
.
packageConfig
,
);
final
Status
devFSStatus
=
globals
.
logger
.
startProgress
(
'
Syncing files to device
${device.device.name}
...'
,
'
Waiting for connection from debug service on
${device.device.name}
...'
,
);
final
UpdateFSReport
report
=
await
device
.
devFS
.
update
(
mainUri:
await
_generateEntrypoint
(
...
...
@@ -833,6 +833,18 @@ class _ResidentWebRunner extends ResidentWebRunner {
..
writeAsStringSync
(
websocketUri
.
toString
());
}
globals
.
printStatus
(
'Debug service listening on
$websocketUri
'
);
globals
.
printStatus
(
''
);
if
(
debuggingOptions
.
buildInfo
.
nullSafetyMode
==
NullSafetyMode
.
sound
)
{
globals
.
printStatus
(
'💪 Running with sound null safety 💪'
,
emphasis:
true
);
}
else
{
globals
.
printStatus
(
'Running with unsound null safety'
,
emphasis:
true
,
);
globals
.
printStatus
(
'For more information see https://dart.dev/null-safety/unsound-null-safety'
,
);
}
}
appStartedCompleter
?.
complete
();
connectionInfoCompleter
?.
complete
(
DebugConnectionInfo
(
wsUri:
websocketUri
));
...
...
packages/flutter_tools/lib/src/resident_runner.dart
View file @
1efb3603
...
...
@@ -1219,15 +1219,8 @@ abstract class ResidentRunner {
ipv6:
ipv6
,
disableServiceAuthCodes:
debuggingOptions
.
disableServiceAuthCodes
);
// This will wait for at least one flutter view before returning.
final
Status
status
=
globals
.
logger
.
startProgress
(
'Waiting for
${device.device.name}
to report its views...'
,
);
try
{
await
device
.
vmService
.
getFlutterViews
();
}
finally
{
status
.
stop
();
}
await
device
.
vmService
.
getFlutterViews
();
// This hooks up callbacks for when the connection stops in the future.
// We don't want to wait for them. We don't handle errors in those callbacks'
// futures either because they just print to logger and is not critical.
...
...
packages/flutter_tools/lib/src/run_hot.dart
View file @
1efb3603
...
...
@@ -1095,13 +1095,24 @@ class HotRunner extends ResidentRunner {
printHelpDetails
();
}
for
(
final
FlutterDevice
device
in
flutterDevices
)
{
final
String
dname
=
device
.
device
.
name
;
// Caution: This log line is parsed by device lab tests.
globals
.
printStatus
(
'An Observatory debugger and profiler on
$
dname
is available at: '
'An Observatory debugger and profiler on
$
{device.device.name}
is available at: '
'
${device.vmService.httpAddress}
'
,
);
}
globals
.
printStatus
(
''
);
if
(
debuggingOptions
.
buildInfo
.
nullSafetyMode
==
NullSafetyMode
.
sound
)
{
globals
.
printStatus
(
'💪 Running with sound null safety 💪'
,
emphasis:
true
);
}
else
{
globals
.
printStatus
(
'Running with unsound null safety'
,
emphasis:
true
,
);
globals
.
printStatus
(
'For more information see https://dart.dev/null-safety/unsound-null-safety'
,
);
}
}
Future
<
void
>
_evictDirtyAssets
()
async
{
...
...
packages/flutter_tools/test/general.shard/resident_runner_test.dart
View file @
1efb3603
...
...
@@ -1510,6 +1510,7 @@ void main() {
commandHelp
.
P
,
commandHelp
.
a
,
'An Observatory debugger and profiler on null is available at: null'
,
'
\n
💪 Running with sound null safety 💪'
,
''
].
join
(
'
\n
'
)
));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment