- 16 May, 2018 4 commits
-
-
Chris Bracken authored
Remaining issue was fixed in 580c844c.
-
Chris Bracken authored
-
Chris Bracken authored
-
Sarah Zakarias authored
-
- 14 May, 2018 2 commits
-
-
Chris Bracken authored
-
jcollins-g authored
-
- 11 May, 2018 3 commits
-
-
Sam Rawlins authored
-
Devon Carew authored
-
Konstantin Scheglov authored
-
- 10 May, 2018 4 commits
-
-
Todd Volkert authored
-
Devon Carew authored
* no longer use the analyzer version shipped in the sdk * update all package versions to the latest
-
Devon Carew authored
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
-
Devon Carew authored
-
- 07 May, 2018 2 commits
-
-
Vyacheslav Egorov authored
-
Chris Bracken authored
This test fails consistently on mac2 and mac3 with the attached Moto G4 devices but passes consistently on other machines. Adding a delay of 1s right after driver.connect() in setUpAll() causes it to pass on the machines in question, which suggests a race condition. Specifically it looks like connect returns the moment Flutter Driver identifies that the isolate is up and running, but empirically it looks like we start running the first test before the UI is actually up. This triggers a failure wherein we start looking for elements before they're onstage. Link to viewport.dart:213 at HEAD: https://github.com/flutter/flutter/blob/b2b46659262c66ff13abc2b8016a94a47646eaad/packages/flutter/lib/src/widgets/viewport.dart#L213 Stack trace: FlutterDriver waitFor should find text "present" ``` DriverError: Error in Flutter application: Uncaught extension error while executing waitFor: NoSuchMethodError: The getter 'visible' was called on null. Receiver: null Tried calling: visible #0 Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:46:5) #1 _ViewportElement.debugVisitOnstageChildren. (package:flutter/src/widgets/viewport.dart:213:36) #2 WhereIterator.moveNext (dart:_internal/iterable.dart:439:11) #3 Iterable.forEach (dart:core/iterable.dart) #4 _ViewportElement.debugVisitOnstageChildren (package:flutter/src/widgets/viewport.dart:214:8) #5 _DepthFirstChildIterator._reverseChildrenOf (package:flutter_test/src/all_elements.dart:54:15) #6 _DepthFirstChildIterator.moveNext (package:flutter_test/src/all_elements.dart:45:19) #7 CachingIterable._fillNext (package:flutter/src/foundation/basic_types.dart:252:27) #8 _LazyListIterator.moveNext (package:flutter/src/foundation/basic_types.dart:279:21) #9 WhereIterator.moveNext (dart:_internal/iterable.dart:438:22) #10 CachingIterable._fillNext (package:flutter/src/foundation/basic_types.dart:252:27) #11 _LazyListIterator.moveNext (package:flutter/src/foundation/basic_types.dart:279:21) #12 Iterable.isEmpty (dart:core/iterable.dart:449:33) #13 Iterable.isNotEmpty (dart:core/iterable.dart:456:27) #14 FlutterDriverExtension._waitForElement. (package:flutter_driver/src/extension/extension.dart:215:51) #15 FlutterDriverExtension._waitUntilFrame (package:flutter_driver/src/extension/extension.dart:197:19) #16 FlutterDriverExtension._waitForElement (package:flutter_driver/src/extension/extension.dart:215:11) #17 FlutterDriverExtension._waitFor (package:flutter_driver/src/extension/extension.dart:286:11) #18 FlutterDriverExtension.call (package:flutter_driver/src/extension/extension.dart:168:51) #19 BindingBase.registerServiceExtension. (package:flutter/src/foundation/binding.dart:370:32) ``` Removes a previous hack that no longer appears to help (adding a 1 second delay in setUpAll() does seem to work around this issue though).
-
- 05 May, 2018 2 commits
-
-
Chris Bracken authored
This reverts commit f37b84f0.
-
Chris Bracken authored
-
- 04 May, 2018 3 commits
-
-
Todd Volkert authored
The new values are not ready for use yet inside Google
-
Yegor authored
* Roll engine to e976be13c51448f89107d082ec81e2b6731671fa * move away from deprecated constants
-
Todd Volkert authored
* Exclude flutter_goldens package from dartdoc because it's for internal use only * Document why flutter_tools doesn' tneed to be excluded from the list of packages to document * Performance optimization in the flutter comparator, and associated test updates.
-
- 03 May, 2018 1 commit
-
-
Todd Volkert authored
In order to avoid checking binaries into flutter/flutter, this comparator can be used to retrieve golden files from a sibling flutter/goldens repository. https://github.com/flutter/flutter/issues/16859
-
- 01 May, 2018 1 commit
-
-
Fedor Korotkov authored
* Configure Cirrus CI * Read file directly instead of shelling a command * Wait for all streams to finish * Add LTR `textDirection` Since `RenderFlex#_debugHasNecessaryDirections` requires it when `direction` is horizontal and there are multiple children.
-
- 30 Apr, 2018 1 commit
-
-
Todd Volkert authored
* Add a `matchesGoldenFile()` async matcher that will match a finder's widget's rasterized image against a golden file. * Add support for pluggable image comparison backends * Add a default backend that does simplistic PNG byte comparison on locally stored golden files. * Add support for `flutter test --update-goldens`, which will treat the rasterized image bytes produced during the test as the new golden bytes and update the golden file accordingly Still TODO: * Add support for the `flutter_test_config.dart` test config hook * Utilize `flutter_test_config.dart` in `packages/flutter/test` to install a backend that retrieves golden files from a dedicated `flutter/goldens` repo https://github.com/flutter/flutter/issues/16859
-
- 27 Apr, 2018 1 commit
-
-
Hans Muller authored
-
- 26 Apr, 2018 5 commits
-
-
Ian Hickson authored
-
Ian Hickson authored
See https://docs.flutter.io/ to see what I mean.
-
Hans Muller authored
Increased the channels test timeout
-
Todd Volkert authored
-
Hans Muller authored
* Revert "New Flutter Gallery UI (#16936)" This reverts commit 7038597b.
-
- 25 Apr, 2018 1 commit
-
-
Hans Muller authored
A new front-end for the Flutter Gallery example.
-
- 20 Apr, 2018 3 commits
-
-
Michael Goderbauer authored
-
Yegor authored
-
Mikkel Nygaard Ravn authored
-
- 19 Apr, 2018 1 commit
-
-
xster authored
-
- 18 Apr, 2018 1 commit
-
-
Alexander Aprelev authored
* Run tests in dart2 mode. * Fix type check * Drop --checked, leave --preview-dart-2 * Remove debugging leftovers.
-
- 17 Apr, 2018 3 commits
-
-
Chinmay Garde authored
-
Todd Volkert authored
-
Todd Volkert authored
This will catch the case where tests hang -- and it will force them to fail so that we see the output from the test.
-
- 16 Apr, 2018 2 commits
-
-
Siva authored
* Turn support for sync-async on in Flutter. With this feature execution of async functions starts immediately instead of it being delayed by one microtask tick. * Address review comments. * Adjust some stack trace expectations which are slightly different with --sync-async turned on.