1. 16 May, 2018 4 commits
  2. 14 May, 2018 2 commits
  3. 11 May, 2018 3 commits
  4. 10 May, 2018 4 commits
  5. 07 May, 2018 2 commits
    • Vyacheslav Egorov's avatar
    • Chris Bracken's avatar
      Mark integration_ui flaky (#17319) · 4509b15d
      Chris Bracken authored
      This test fails consistently on mac2 and mac3 with the attached Moto G4
      devices but passes consistently on other machines.
      
      Adding a delay of 1s right after driver.connect() in setUpAll() causes
      it to pass on the machines in question, which suggests a race condition.
      Specifically it looks like connect returns the moment Flutter Driver
      identifies that the isolate is up and running, but empirically it looks
      like we start running the first test before the UI is actually up. This
      triggers a failure wherein we start looking for elements before they're
      onstage.
      
      Link to viewport.dart:213 at HEAD:
      https://github.com/flutter/flutter/blob/b2b46659262c66ff13abc2b8016a94a47646eaad/packages/flutter/lib/src/widgets/viewport.dart#L213
      
      Stack trace:
      FlutterDriver waitFor should find text "present"
      
      ```
        DriverError: Error in Flutter application: Uncaught extension error while executing waitFor: NoSuchMethodError: The getter 'visible' was called on null.
        Receiver: null
        Tried calling: visible
        #0      Object.noSuchMethod (dart:core/runtime/libobject_patch.dart:46:5)
        #1      _ViewportElement.debugVisitOnstageChildren. (package:flutter/src/widgets/viewport.dart:213:36)
        #2      WhereIterator.moveNext (dart:_internal/iterable.dart:439:11)
        #3      Iterable.forEach (dart:core/iterable.dart)
        #4      _ViewportElement.debugVisitOnstageChildren (package:flutter/src/widgets/viewport.dart:214:8)
        #5      _DepthFirstChildIterator._reverseChildrenOf (package:flutter_test/src/all_elements.dart:54:15)
        #6      _DepthFirstChildIterator.moveNext (package:flutter_test/src/all_elements.dart:45:19)
        #7      CachingIterable._fillNext (package:flutter/src/foundation/basic_types.dart:252:27)
        #8      _LazyListIterator.moveNext (package:flutter/src/foundation/basic_types.dart:279:21)
        #9      WhereIterator.moveNext (dart:_internal/iterable.dart:438:22)
        #10     CachingIterable._fillNext (package:flutter/src/foundation/basic_types.dart:252:27)
        #11     _LazyListIterator.moveNext (package:flutter/src/foundation/basic_types.dart:279:21)
        #12     Iterable.isEmpty (dart:core/iterable.dart:449:33)
        #13     Iterable.isNotEmpty (dart:core/iterable.dart:456:27)
        #14     FlutterDriverExtension._waitForElement. (package:flutter_driver/src/extension/extension.dart:215:51)
        #15     FlutterDriverExtension._waitUntilFrame (package:flutter_driver/src/extension/extension.dart:197:19)
        #16     FlutterDriverExtension._waitForElement (package:flutter_driver/src/extension/extension.dart:215:11)
      
        #17     FlutterDriverExtension._waitFor (package:flutter_driver/src/extension/extension.dart:286:11)
      
        #18     FlutterDriverExtension.call (package:flutter_driver/src/extension/extension.dart:168:51)
      
        #19     BindingBase.registerServiceExtension. (package:flutter/src/foundation/binding.dart:370:32)
      ```
      
      Removes a previous hack that no longer appears to help (adding a 1
      second delay in setUpAll() does seem to work around this issue though).
      4509b15d
  6. 05 May, 2018 2 commits
  7. 04 May, 2018 3 commits
  8. 03 May, 2018 1 commit
  9. 01 May, 2018 1 commit
    • Fedor Korotkov's avatar
      Configure Cirrus CI (#16224) · 73334599
      Fedor Korotkov authored
      * Configure Cirrus CI
      
      * Read file directly instead of shelling a command
      
      * Wait for all streams to finish
      
      * Add LTR `textDirection`
      
      Since `RenderFlex#_debugHasNecessaryDirections` requires it when `direction` is horizontal and there are multiple children.
      73334599
  10. 30 Apr, 2018 1 commit
    • Todd Volkert's avatar
      Add basic support for golden image file testing (#17094) · e19db89a
      Todd Volkert authored
      * Add a `matchesGoldenFile()` async matcher that will match
        a finder's widget's rasterized image against a golden file.
      * Add support for pluggable image comparison backends
      * Add a default backend that does simplistic PNG byte
        comparison on locally stored golden files.
      * Add support for `flutter test --update-goldens`, which will
        treat the rasterized image bytes produced during the test
        as the new golden bytes and update the golden file accordingly
      
      Still TODO:
      
      * Add support for the `flutter_test_config.dart` test config hook
      * Utilize `flutter_test_config.dart` in `packages/flutter/test`
        to install a backend that retrieves golden files from a dedicated
        `flutter/goldens` repo
      
      https://github.com/flutter/flutter/issues/16859
      e19db89a
  11. 27 Apr, 2018 1 commit
  12. 26 Apr, 2018 5 commits
  13. 25 Apr, 2018 1 commit
  14. 20 Apr, 2018 3 commits
  15. 19 Apr, 2018 1 commit
  16. 18 Apr, 2018 1 commit
  17. 17 Apr, 2018 3 commits
  18. 16 Apr, 2018 2 commits