Fail with better error message in microbenchmarks (#16676)

ec26a7ba · Todd Volkert · GitHub · e9177ba3 · ec26a7ba
Unverified Commit ec26a7ba authored Apr 17, 2018 by Todd Volkert Committed by GitHub Apr 17, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 1 deletion

microbenchmarks.dart dev/devicelab/lib/tasks/microbenchmarks.dart +6 -1

No files found.
--- a/dev/devicelab/lib/tasks/microbenchmarks.dart
+++ b/dev/devicelab/lib/tasks/microbenchmarks.dart
@@ -127,7 +127,12 @@ Future<Map<String, double>> _readJsonResults(Process process) {
      jsonStarted = false;
      processWasKilledIntentionally = true;
      process.kill(ProcessSignal.SIGINT); // flutter run doesn't quit automatically
-      completer.complete(json.decode(jsonBuf.toString()));
+      final String jsonOutput = jsonBuf.toString();
+      try {
+        completer.complete(json.decode(jsonOutput));
+      } catch (ex) {
+        completer.completeError('Decoding JSON failed ($ex). JSON string was: $jsonOutput');
+      }
      return;
    }