1. 04 Oct, 2017 4 commits
  2. 03 Oct, 2017 11 commits
  3. 02 Oct, 2017 10 commits
  4. 30 Sep, 2017 1 commit
  5. 29 Sep, 2017 10 commits
    • Ian Hickson's avatar
    • gspencergoog's avatar
      Fixing docs for testWidgets. No functionality change. (#12309) · f40d09e1
      gspencergoog authored
      * Fixing docs for testWidgets.  No functionality change.
      f40d09e1
    • Ian Hickson's avatar
      Border.add, improve BorderSide.merge (#12327) · 944fef45
      Ian Hickson authored
      ...and other minor Border improvements.
      And tests.
      
      This changes the merge logic I added yesterday to not support nulls
      but instead support BorderSide.none and equivalents. This makes more
      sense when dealing with actual Borders.
      944fef45
    • Todd Volkert's avatar
      Move assert into constructor body. (#12331) · ada593e8
      Todd Volkert authored
      Temporary workaround to the fact that the Analyzer API
      doesn't have a way to turn on asserts in initializers, coupled
      with the fact that this file is being parsed by package:intl
      using the Analyzer API.
      ada593e8
    • Chris Bracken's avatar
      Delete a duplicate EditableText test (#12325) · 2698fe85
      Chris Bracken authored
      In 85c425ac, a test was added to ensure that widget.onChanged was
      fired when the contents of an EditableText changed via system paste
      events (e.g. triggered from a TextSelectionOverlay). Due to a long stack
      of rebases and (less-than-perfect) manual merge conflict merge
      resolution, it was inadvertently added twice.
      2698fe85
    • Michael Thomsen's avatar
      Add a check for gradle failing due to missing licenses (#12318) · 3f6b28dd
      Michael Thomsen authored
      * Add a check for gradle failing due to missing licenses
      
      * Review feedback Jakob
      3f6b28dd
    • Michael Goderbauer's avatar
      35ce207b
    • Chris Bracken's avatar
      Improved behaviour for text-editing widgets (#12273) · 85c425ac
      Chris Bracken authored
      This patch fixes a collection of issues with widgets involved in text
      editing:
      
        * Fire widget.onChanged on EditableText value change:
          The value of an EditableText is composed of the text value as well
          as other editing-related data such as selection-related information.
      
          Previously, widget.onChanged() was only called for updates via
          updateEditingValue(). For pastes via a TextSelectionOverlay, updates
          are signalled via _handleSelectionOverlayChanged(), which only ever
          triggered widget.onSelectionChanged(), but not widget.onChanged().
      
          Both updateEditingValue() and _handleSelectionOverlayChanged()
          perform the value update via _formatAndSetValue(), which is where
          this patch moves the widget.onChanged() call.
      
        * Correctly update TextFormField value on edits via controller:
          The textual value of a TextFormField exists in two locations:
            1. FormField.value, as with all FormFields and subclasses.
            2. TextEditingController.value associated with the TextField
               underlying the TextFormField.
      
          Previously, edits to the TextEditingController associated with a
          TextFormField resulted in updates to the rendered TextField widget,
          but did not update TextFormField.value. FormField.value is updated
          via FormField's onChanged function, which is called from the
          EditableText underlying the TextField underlying the TextFormField.
          EditableText only fires onChanged when it receives changes from the
          engine. It does not fire onChanged for changes made to the
          underlying TextController, since the owner of the TextController is
          the one making these changes and thus, already aware of them.
          FormField, however, *does* need to listen to these changes to update
          its value.
      
        * Adds an initialValue parameter to the TextFormField constructor:
          FormField's constructor already takes an initialValue parameter,
          which specifies the initial value in the field, which is also the
          value to which reset() returns the field.
      
          Previously, TextFormField took its initial value from the controller
          value (if a controller was passed in) or the empty string (if not).
          This had the undesirable effect that calling reset() always resets
          the value to the current value of the controller... i.e., does
          nothing.
      
          We now take an initial value explicitly.
      85c425ac
    • Ian Hickson's avatar
      Retry on failed download. (#12293) · e1fa035b
      Ian Hickson authored
      e1fa035b
    • Ian Hickson's avatar
      SafeArea (#12292) · 4c83ea8b
      Ian Hickson authored
      * SafeArea
      
      * AnimatedSafeArea
      
      * AppBar test
      
      * Apply feedback
      4c83ea8b
  6. 28 Sep, 2017 4 commits