- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 23 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
Blocking issue (https://github.com/dart-lang/linter/issues/453) for this lint has been resolved.
-
- 16 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
It's time to say good bye to an old friend. It has outlived its usefulness. Farewell, AbstractNode! ð«¡
-
- 31 Mar, 2023 1 commit
-
-
Kate Lovett authored
Fix docs and error messages for scroll directions + sample code
-
- 23 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 20 Mar, 2023 1 commit
-
-
Kate Lovett authored
Fix error message for unbounded viewports
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 31 Oct, 2022 1 commit
-
-
Greg Spencer authored
-
- 27 Jul, 2022 1 commit
-
-
LongCatIsLooong authored
Suggest predicate-based formatter in [FilteringTextInputFormatter] docs for whole string matching (#107848)
-
- 24 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 20 May, 2022 1 commit
-
-
Casey Hillers authored
-
- 19 May, 2022 2 commits
-
-
Jonah Williams authored
-
Dan Field authored
-
- 18 May, 2022 1 commit
-
-
gaaclarke authored
-
- 17 May, 2022 1 commit
-
-
Dan Field authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 21 Mar, 2022 1 commit
-
-
Pierre-Louis authored
* fix deprecated_new_in_comment_reference for `material` library in a future version of the SDK, these will be flagged, fix them now * Update pubspec.yaml
-
- 12 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 20 Oct, 2021 1 commit
-
-
Kate Lovett authored
-
- 01 Oct, 2021 1 commit
-
-
Kate Lovett authored
-
- 30 Aug, 2021 1 commit
-
-
chunhtai authored
Reland "Fixes listview shrinkwrap and hidden semantics node gets updated incorrectly. (#88814)" (#89184)
-
- 25 Aug, 2021 2 commits
-
-
chunhtai authored
- 03 Aug, 2021 1 commit
-
-
Jonah Williams authored
-
- 28 Jul, 2021 1 commit
-
-
Kate Lovett authored
-
- 25 Jun, 2021 1 commit
-
-
Dan Field authored
-
- 13 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 18 Feb, 2021 1 commit
-
-
Ian Hickson authored
-
- 07 Jan, 2021 1 commit
-
-
Nathan Walker authored
-
- 06 Jan, 2021 1 commit
-
-
Sam Rawlins authored
-
- 21 Nov, 2020 1 commit
-
-
Michael Goderbauer authored
-
- 20 Nov, 2020 1 commit
-
-
Ian Hickson authored
-
- 02 Nov, 2020 1 commit
-
-
Greg Spencer authored
-
- 10 Oct, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 Oct, 2020 1 commit
-
-
Matej Knopp authored
-