Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
d50b5a07
Unverified
Commit
d50b5a07
authored
May 19, 2022
by
Dan Field
Committed by
GitHub
May 19, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Stop recommending "shrinkWrap" (#104008)
parent
4b678271
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
12 deletions
+11
-12
viewport.dart
packages/flutter/lib/src/rendering/viewport.dart
+6
-6
viewport_test.dart
packages/flutter/test/rendering/viewport_test.dart
+5
-6
No files found.
packages/flutter/lib/src/rendering/viewport.dart
View file @
d50b5a07
...
...
@@ -1385,9 +1385,9 @@ class RenderViewport extends RenderViewportBase<SliverPhysicalContainerParentDat
'If this widget is always nested in a scrollable widget there '
'is no need to use a viewport because there will always be enough '
'vertical space for the children. In this case, consider using a '
'Column
instead. Otherwise, consider using the "shrinkWrap" property
'
'
(or a ShrinkWrappingViewport) to size the height of the viewport
'
'
to the sum of the heights of its children
.'
,
'Column
or Wrap instead. Otherwise, consider using a
'
'
CustomScrollView to concatenate arbitrary slivers into a
'
'
single scrollable
.'
,
),
]);
}
...
...
@@ -1415,9 +1415,9 @@ class RenderViewport extends RenderViewportBase<SliverPhysicalContainerParentDat
'If this widget is always nested in a scrollable widget there '
'is no need to use a viewport because there will always be enough '
'horizontal space for the children. In this case, consider using a '
'Row
instead. Otherwise, consider using the "shrinkWrap" property
'
'
(or a ShrinkWrappingViewport) to size the width of the viewport
'
'
to the sum of the widths of its children
.'
,
'Row
or Wrap instead. Otherwise, consider using a
'
'
CustomScrollView to concatenate arbitrary slivers into a
'
'
single scrollable
.'
,
),
]);
}
...
...
packages/flutter/test/rendering/viewport_test.dart
View file @
d50b5a07
...
...
@@ -1708,9 +1708,8 @@ void main() {
' If this widget is always nested in a scrollable widget there is
\n
'
' no need to use a viewport because there will always be enough
\n
'
' horizontal space for the children. In this case, consider using a
\n
'
' Row instead. Otherwise, consider using the "shrinkWrap" property
\n
'
' (or a ShrinkWrappingViewport) to size the width of the viewport
\n
'
' to the sum of the widths of its children.
\n
'
,
' Row or Wrap instead. Otherwise, consider using a CustomScrollView
\n
'
' to concatenate arbitrary slivers into a single scrollable.
\n
'
,
);
});
...
...
@@ -1743,9 +1742,9 @@ void main() {
' If this widget is always nested in a scrollable widget there is
\n
'
' no need to use a viewport because there will always be enough
\n
'
' vertical space for the children. In this case, consider using a
\n
'
' Column
instead. Otherwise, consider using the "shrinkWrap"
\n
'
'
property (or a ShrinkWrappingViewport) to size the height of th
e
\n
'
'
viewport to the sum of the heights of its children
.
\n
'
,
' Column
or Wrap instead. Otherwise, consider using a
\n
'
'
CustomScrollView to concatenate arbitrary slivers into a singl
e
\n
'
'
scrollable
.
\n
'
,
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment