Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ce4d635a
Unverified
Commit
ce4d635a
authored
Oct 20, 2021
by
Kate Lovett
Committed by
GitHub
Oct 20, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix visual overflow when overscrolling RenderShrinkWrappingViewport (#91620)
parent
42eb9032
Changes
2
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
257 additions
and
203 deletions
+257
-203
viewport.dart
packages/flutter/lib/src/rendering/viewport.dart
+5
-1
viewport_test.dart
packages/flutter/test/rendering/viewport_test.dart
+252
-202
No files found.
packages/flutter/lib/src/rendering/viewport.dart
View file @
ce4d635a
...
...
@@ -1919,7 +1919,10 @@ class RenderShrinkWrappingViewport extends RenderViewportBase<SliverLogicalConta
assert
(
correctedOffset
.
isFinite
);
_maxScrollExtent
=
0.0
;
_shrinkWrapExtent
=
0.0
;
_hasVisualOverflow
=
false
;
// Since the viewport is shrinkwrapped, we know that any negative overscroll
// into the potentially infinite mainAxisExtent will overflow the end of
// the viewport.
_hasVisualOverflow
=
correctedOffset
<
0.0
;
switch
(
cacheExtentStyle
)
{
case
CacheExtentStyle
.
pixel
:
_calculatedCacheExtent
=
cacheExtent
;
...
...
@@ -1928,6 +1931,7 @@ class RenderShrinkWrappingViewport extends RenderViewportBase<SliverLogicalConta
_calculatedCacheExtent
=
mainAxisExtent
*
_cacheExtent
;
break
;
}
return
layoutChildSequence
(
child:
firstChild
,
scrollOffset:
math
.
max
(
0.0
,
correctedOffset
),
...
...
packages/flutter/test/rendering/viewport_test.dart
View file @
ce4d635a
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment