- 14 Aug, 2020 2 commits
-
-
Paul Berry authored
Now that https://github.com/dart-lang/sdk/issues/41985 is fixed, the analyzer detects dead code due to "unnecessary" null checks. Since we want to retain null checks in Flutter even when they appear unnecessary (in order to preserve runtime behavior in weak mode), we need to suppress these dead code hints. Note that one assertion is removed by this PR (`heightFactor != null || (heightFactor == 1.0 && heightDelta == 0.0)`). This is because `heightFactor == 1.0 && heightDelta == 0.0` can only be true if `heightFactor != null`, so this assertion is equivalent to simply asserting that `heightFactor != null`, which is already asserted two lines above.
-
Alexandre Ardhuin authored
* migrate painting to nullsafety * address review comments
-
- 11 Jun, 2020 1 commit
-
-
Alexandre Ardhuin authored
* add language version 2.8 in packages/flutter * enable non-nullable analyzer flag
-
- 31 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 28 Jan, 2020 1 commit
-
-
Dan Field authored
-
- 24 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 15 Jan, 2020 1 commit
-
-
Dan Field authored
-
- 09 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 08 Jan, 2020 1 commit
-
-
Greg Spencer authored
-
- 07 Jan, 2020 1 commit
-
-
Alexandre Ardhuin authored
-
- 05 Dec, 2019 1 commit
-
-
Alexandre Ardhuin authored
-
- 27 Nov, 2019 1 commit
-
-
Ian Hickson authored
* Update project.pbxproj files to say Flutter rather than Chromium Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright. * Update the copyright notice checker to require a standard notice on all files * Update copyrights on Dart files. (This was a mechanical commit.) * Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine. Some were already marked "The Flutter Authors", not clear why. Their dates have been normalized. Some were missing the blank line after the license. Some were randomly different in trivial ways for no apparent reason (e.g. missing the trailing period). * Clean up the copyrights in non-Dart files. (Manual edits.) Also, make sure templates don't have copyrights. * Fix some more ORGANIZATIONNAMEs
-
- 16 Nov, 2019 1 commit
-
-
Ian Hickson authored
-
- 28 Oct, 2019 1 commit
-
-
Albertus Angga Raharja authored
* Add structured errors in Animations, TabView, ChangeNotifier * Add structured error on MaterialPageRoute, BoxBorder, DecorationImagePainter, TextSpan * Add structured errors in Debug * Fix test errors * Add structured errors in Scaffold and Stepper * Add structured errors in part of Rendering Layer * Fix failing test due to FloatingPoint precision * Fix failing tests due to precision error and not using final * Fix failing test due to floating precision error with RegEx instead * Add structured error in CustomLayout and increase test coverage * Add structured error & its test in ListBody * Add structured error in ProxyBox and increase test coverage * Add structured error message in Viewport * Fix styles and add more assertions on ErrorHint and DiagnosticProperty * Add structured error in scheduler/binding and scheduler/ticker Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in AssetBundle and TextInput Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured errors in several widgets #1 Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove unused import Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add assertions on hint messages Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix catch spacing Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in several widgets part 2 and increase code coverage Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Add structured error in flutter_test/widget_tester * Fix floating precision accuracy by using RegExp Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove todo to add tests in Scaffold showBottomSheet Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix reviews by indenting lines and fixing the assertion orders Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Fix failing tests due to renaming class Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Try skipping the NetworkBundleTest Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com> * Remove leading space in material/debug error hint Signed-off-by:
Albertus Angga Raharja <albertusangga@google.com>
-
- 08 Oct, 2019 1 commit
-
-
Kate Lovett authored
-
- 28 Aug, 2019 2 commits
-
-
Jonah Williams authored
This reverts commit ddd31bce.
-
Ian Hickson authored
-
- 17 Jul, 2019 1 commit
-
-
Dan Field authored
-
- 08 Jun, 2019 1 commit
-
-
Gary Qian authored
-
- 07 Jun, 2019 2 commits
-
-
Gary Qian authored
Reland "Text inline widgets, TextSpan rework (#30069)" with improved backwards compatibility (#34051)
-
- 06 Jun, 2019 3 commits
- 05 Jun, 2019 1 commit
-
- 04 Jun, 2019 1 commit
-
-
Gary Qian authored
* Merge in changes for inline widgets * Make analyzer happy, fix tests * Fix analyzer * Add missing doc * Docs on RichText * Fix analyzer some more * Remove whitespace at end of line * Update goldens * Text fixes * Analyzer
-
- 10 Apr, 2019 1 commit
-
-
Jonah Williams authored
-
- 08 Nov, 2018 1 commit
-
-
Greg Spencer authored
This converts existing ## Sample code samples to {@tool sample}...{@end-tool} form. Also: 1. Fixed a minor bug in analyze-sample-code.dart 2. Made the snippet tool only insert descriptions if the description is non-empty. 3. Moved the Card diagram to before the code sample.
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* lint unnecessary_new on samples * fix tests
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 17 Nov, 2017 1 commit
-
-
Greg Spencer authored
I got tired of drive-by spelling fixes, so I figured I'd just take care of them all at once. This only corrects errors in the dartdocs, not regular comments, and I skipped any sample code in the dartdocs. It doesn't touch any identifiers in the dartdocs either. No code changes, just comments.
-
- 21 Sep, 2017 1 commit
-
-
Alexandre Ardhuin authored
-
- 11 Sep, 2017 1 commit
-
-
Jacob Richman authored
* Refactor SemanticsData and SemanticsNode to use Diagnosticable. * Switch toStringDeep to take named parameters.
-
- 29 Aug, 2017 1 commit
-
-
Ian Hickson authored
In some cases, the element tree is not clean but we are required to dump the tree anyway. To avoid crashing in those cases, we return an explicit null node.
-
- 03 Aug, 2017 1 commit
-
-
Jacob Richman authored
Add Diagnosticable base class and documentation
-
- 28 Jul, 2017 1 commit
-
-
Ian Hickson authored
-
- 27 Jul, 2017 1 commit
-
-
Ian Hickson authored
It was 8.0. It's now arbitrarily 18.0. Changing this required adjusting some tests. Adjusting the tests required debugging the tests. Debugging the tests required some tools to help debugging gesture recognizers and gesture arenas, so I added some. It also required updating some toString() methods which resulted in some changes to the tree diagnostics logic. Also I cleaned up some docs while I was at it.
-
- 25 Jul, 2017 1 commit
-
-
Jacob Richman authored
Refactor RenderObject.toStringDeep and Widget.toStringDeep code to use DiagnosticsNode.
-