- 19 Oct, 2023 5 commits
-
-
auto-submit[bot] authored
Reverts flutter/flutter#136773 Initiated by: itsjustkevin This change reverts the following previous change: Original Description: fixes https://github.com/flutter/flutter/issues/134854
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/d0d7b4d61265...28cb2508b8e0 2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 62acc1e162cc to 8cf64b0795af (2 revisions) (flutter/engine#47097) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/8d51b64e9440...d0d7b4d61265 2023-10-19 flar@google.com Revert "[web] Ensure handled key event is not propagated to IME" (flutter/engine#47086) 2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 2HSBpWikGWvPJlHOP... to Z2mOZ5cuPJWvKn22P... (flutter/engine#47094) 2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 64c5de6663a4 to 62acc1e162cc (1 revision) (flutter/engine#47093) 2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from eb3fb9a13e16 to 1b425a25a6dd (1 revision) (flutter/engine#47092) 2023-10-19 skia-flutter-autoroll@skia.org Roll Skia from 85971b25cf4b to 64c5de6663a4 (2 revisions) (flutter/engine#47091) 2023-10-19 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from PxJM5ivbnbYoVkqBg... to 0hLSNJ_DCTzRvTVJe... (flutter/engine#47090) 2023-10-19 skia-flutter-autoroll@skia.org Roll Dart SDK from d9b1e60fe442 to eb3fb9a13e16 (1 revision) (flutter/engine#47084) 2023-10-18 chinmaygarde@google.com Update buildroot to ab76ccba2ca4ce4. (flutter/engine#47078) 2023-10-18 fujino@google.com migrate const_finder to use the implementation from package:kernel (flutter/engine#47077) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d561b276b5d9 to 85971b25cf4b (1 revision) (flutter/engine#47076) 2023-10-18 jason-simmons@users.noreply.github.com [Impeller] Guard execution of ReactorGLES operations with a mutex (flutter/engine#47068) 2023-10-18 chinmaygarde@google.com [Impeller] Document ReactorGLES. (flutter/engine#47070) 2023-10-18 matej.knopp@gmail.com [web] Ensure handled key event is not propagated to IME (flutter/engine#46829) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 2HSBpWikGWvP to Z2mOZ5cuPJWv fuchsia/sdk/core/mac-amd64 from PxJM5ivbnbYo to 0hLSNJ_DCTzR If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#136771 Initiated by: gspencergoog This change reverts the following previous change: Original Description: ## Description This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/136758 ## Tests - Added regression test.
-
auto-submit[bot] authored
Reverts flutter/flutter#135249 Initiated by: zanderso This change reverts the following previous change: Original Description: Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests.
-
- 18 Oct, 2023 33 commits
-
-
Michael Goderbauer authored
Follow-up to https://github.com/flutter/packages/pull/5177
-
Greg Spencer authored
## Description This adds code to make sure that grandchildren are removed from the `focusedChild` of a scope when the child is detached. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/136758 ## Tests - Added regression test.
-
Harry Terkelsen authored
Changes golden tests on CanvasKit to use Layer.toImage instead of browser APIs for screenshots. This brings it more in line with other platforms and should also fix some async timing bugs with tests. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b67edb05d3f7...8d51b64e9440 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from d46a3697d3c5 to d561b276b5d9 (1 revision) (flutter/engine#47074) 2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from b423d5753fdc to d9b1e60fe442 (1 revision) (flutter/engine#47073) 2023-10-18 dkwingsmt@users.noreply.github.com Reland 2 (part 1): Enforce the rule of calling `FlutterView.Render` (flutter/engine#47062) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ef0e93524e7d to d46a3697d3c5 (2 revisions) (flutter/engine#47072) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6caee3236d37...b67edb05d3f7 2023-10-18 31859944+LongCatIsLooong@users.noreply.github.com [iOS TextInputPlugin] adjust the markedTextRange when replacing text. (flutter/engine#46603) 2023-10-18 zanderso@users.noreply.github.com Reland: Remove the frontend server wrapper (flutter/engine#47010) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 9880c4006735 to ef0e93524e7d (1 revision) (flutter/engine#47069) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 523f04f1a898 to 9880c4006735 (1 revision) (flutter/engine#47067) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from ccd07c6f5042 to 523f04f1a898 (1 revision) (flutter/engine#47065) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Sam Rawlins authored
The code with out the null assertion is legal as per the type signature, but will throw a runtime exception if the nullable value is null. To make this exception more explicit, the value must be null-checked before completing the completer with the value. The analyzer will soon enforce such checks. See https://github.com/dart-lang/sdk/issues/53253. Fixes https://github.com/flutter/flutter/issues/136775
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/ab86c53c19cd...6caee3236d37 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from b8c989df901a to ccd07c6f5042 (3 revisions) (flutter/engine#47063) 2023-10-18 matanlurey@users.noreply.github.com Add `--lint-all=<regex>` as an option for `clang_tidy`, refactor lint targets (flutter/engine#46522) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
auto-submit[bot] authored
Reverts flutter/flutter#136751 Initiated by: vashworth This change reverts the following previous change: Original Description: Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
-
Greg Spencer authored
## Description This converts the `MenuAnchor` class to use `OverlayPortal` instead of directly using the overlay. ## Related Issues - Fixes https://github.com/flutter/flutter/issues/124830 ## Tests - No tests yet (hence it is a draft)
-
Victoria Ashworth authored
Reland of https://github.com/flutter/flutter/pull/136562 with fixes.
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0eff5d191856...ab86c53c19cd 2023-10-18 skia-flutter-autoroll@skia.org Roll Dart SDK from da48c75b73b1 to b423d5753fdc (5 revisions) (flutter/engine#47061) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
chunhtai authored
fixes https://github.com/flutter/flutter/issues/134854
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/b778a07f8ae9...0eff5d191856 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 5857f5f05b35 to b8c989df901a (5 revisions) (flutter/engine#47060) 2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from OudOcFarQhQQzKDBx... to 2HSBpWikGWvPJlHOP... (flutter/engine#47059) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from a52d2a9e2b01 to 5857f5f05b35 (1 revision) (flutter/engine#47057) 2023-10-18 jiahaog@users.noreply.github.com Add missing source file (flutter/engine#47046) 2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from Kp2wNpzRlAtbME0R4... to PxJM5ivbnbYoVkqBg... (flutter/engine#47056) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 5172e904def7 to a52d2a9e2b01 (2 revisions) (flutter/engine#47055) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from OudOcFarQhQQ to 2HSBpWikGWvP fuchsia/sdk/core/mac-amd64 from Kp2wNpzRlAtb to PxJM5ivbnbYo If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Robert Ancell authored
Implement GApplication:shutdown so a Flutter developer knows where to put code that should occur on application shutdown. (#136780) This was added because the dispose method doesn't seem to be called - something must still have a reference to the application after shutdown. Solution for https://github.com/flutter/flutter/issues/136582
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/7f37c9b181af...b778a07f8ae9 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 8132e3356d63 to 5172e904def7 (4 revisions) (flutter/engine#47052) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Taha Tesser authored
Fix `Slider` `onChanged` callback order & never calls `onChangeStart` on `SliderInteraction.slideOnly` allowed interaction (#136720) fixes [Slider will call onChanged before onChangeStart when sliding.](https://github.com/flutter/flutter/issues/136707) This fixes a regression from https://github.com/flutter/flutter/pull/121483 ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return const MaterialApp( debugShowCheckedModeBanner: false, home: Example(), ); } } class Example extends StatefulWidget { const Example({super.key}); @override State<Example> createState() => _ExampleState(); } class _ExampleState extends State<Example> { double _sliderValue = 0.5; @override Widget build(BuildContext context) { return Scaffold( body: Center( child: Slider( // allowedInteraction: SliderInteraction.tapAndSlide, // allowedInteraction: SliderInteraction.tapOnly, // allowedInteraction: SliderInteraction.slideOnly // allowedInteraction: SliderInteraction.slideThumb, value: _sliderValue, onChangeStart: (newValue) { print("onChangeStart ......"); }, onChanged: (newValue) { print("onChanged ......"); setState(() { _sliderValue = newValue; }); }, onChangeEnd: (newValue) { print("onChangeEnd ......"); }, ), ), ); } } ``` </details>
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/78026b4003fe...7f37c9b181af 2023-10-18 zanderso@users.noreply.github.com Revert "Roll buildroot to pull in removal of //tools." (flutter/engine#47053) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Arash authored
Consider a scenario where the background color and indicator's background color are the same. Adding a stroke color to the value indicator would be a valuable for the following reasons: - **Visual Clarity:** It would allow developers to make the value indicator stand out more against the background, making it easier for users to notice. - **Customization:** It would provide more flexibility in customizing the appearance of the sliding widget, allowing developers to match the design requirements of their apps. - **Accessibility:** Improved visual distinction can enhance the accessibility of the sliding widget for users with various needs. *List which issues are fixed by this PR. You must list at least one issue.* Fixes #135984
-
Aakash Pamnani authored
Fixed empty rows at the last page in paginated data table BEFORE:  AFTER:  Issues resolves : #80421
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/46923fd39032...78026b4003fe 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from fed09695a0b9 to 8132e3356d63 (2 revisions) (flutter/engine#47050) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/packages/compare/d4390624a624...14aa69e2e54c 2023-10-17 engine-flutter-autoroll@skia.org Roll Flutter from afc39160 to 6eea6e27 (27 revisions) (flutter/packages#5165) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Daco Harkes authored
Closes: https://github.com/flutter/flutter/issues/136547
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/c9c9684e03a3...46923fd39032 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 212da8293790 to fed09695a0b9 (1 revision) (flutter/engine#47045) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/0c1c29271e8b...c9c9684e03a3 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 3d938d4b00ee to 212da8293790 (1 revision) (flutter/engine#47043) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/1de09d13e708...0c1c29271e8b 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 8796ee7d1c66 to 3d938d4b00ee (3 revisions) (flutter/engine#47042) 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from 13694b8c64aa to 8796ee7d1c66 (1 revision) (flutter/engine#47041) 2023-10-18 matej.knopp@gmail.com [macOS] Fix tests failing on Sonoma (flutter/engine#46461) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/6fc36e61a99a...1de09d13e708 2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from VtEx0R7lepGAvwAMU... to OudOcFarQhQQzKDBx... (flutter/engine#47039) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from VtEx0R7lepGA to OudOcFarQhQQ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/3f818efff3c5...6fc36e61a99a 2023-10-18 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from E0Ui7KmD3u5JSKEk5... to Kp2wNpzRlAtbME0R4... (flutter/engine#47037) Also rolling transitive DEPS: fuchsia/sdk/core/mac-amd64 from E0Ui7KmD3u5J to Kp2wNpzRlAtb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/2eef9b43cfb4...3f818efff3c5 2023-10-18 skia-flutter-autoroll@skia.org Roll Skia from f62b4dce5e55 to 13694b8c64aa (2 revisions) (flutter/engine#47033) 2023-10-18 chinmaygarde@google.com Roll buildroot to pull in removal of //tools. (flutter/engine#47032) 2023-10-18 jonahwilliams@google.com Disable threading test that fails on CI (flutter/engine#47034) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/5df7af34a718...2eef9b43cfb4 2023-10-17 chris@bracken.jp Move imgui from buildroot to flutter third_party (flutter/engine#47031) 2023-10-17 jonahwilliams@google.com [Impeller] Rework Vulkan GPUTracker to decorate existing cmd buffers. (flutter/engine#46963) 2023-10-17 chris@bracken.jp [fml][embedder] Improve thread-check logging (flutter/engine#47020) 2023-10-17 skia-flutter-autoroll@skia.org Roll Dart SDK from 99ce477503f8 to da48c75b73b1 (1 revision) (flutter/engine#47027) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Christopher Fujino authored
Fixes https://github.com/flutter/flutter/issues/130277 This PR does two things: 1. introduce a hidden `flutter build _preview` command, that will build a debug windows desktop app and copy it into the SDK's binary cache. This command is only intended to be run during packaging. 2. introduce a new device type, called `PreviewDevice`, which relies on the prebuilt desktop debug app from step 1, copies it into the target app's assets build folder, and then hot reloads their dart code into it.
-
Gildásio Filho authored
The documentation for using `findChildIndexCallback` recommends using `indexOf`, but that causes [this line](https://github.com/flutter/flutter/blob/05259ca938c9ea27aa551048b690d5a06371a6c0/packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart#L259) to throw in debug mode, and when using `SliverList`, it breaks the render. This PR changes the usage to check if the index is not negative before using it, and changes to return `null` instead if the child wasn't able to be found. There's the related issue #107123, but this doesn't actually fix it. ----- This PR has been updated to add the snippets that were used in the `findChildIndexCallback` comment as examples with proper tests, as well as updating the comment to reference the new examples.
-
pdblasi-google authored
* Added `performAction` to `SemanticsController` as well as specific methods for specific actions * Added a `scrollable` finder to `find.semantics` as a convenience method for `findAny(<all scrollable actions>)` * Updated `containsSemantics` and `matchSemantics` matchers to also work on `FinderBase<Semantics>` Closes #112413
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/e57b5bac4244...5df7af34a718 2023-10-17 chinmaygarde@google.com Roll buildroot to pull in //gpu removal. (flutter/engine#47014) 2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from b524e0af7d3a to f62b4dce5e55 (4 revisions) (flutter/engine#47029) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
- 17 Oct, 2023 2 commits
-
-
engine-flutter-autoroll authored
https://github.com/flutter/engine/compare/f9f937e51080...e57b5bac4244 2023-10-17 jason-simmons@users.noreply.github.com Workaround for a clang-tidy warning in CPUSpeedTracker (flutter/engine#47024) 2023-10-17 skia-flutter-autoroll@skia.org Roll Skia from a9caf3c19792 to b524e0af7d3a (1 revision) (flutter/engine#47017) 2023-10-17 jason-simmons@users.noreply.github.com Manual roll of Clang from 576b184d6e3b to 00396e6a1a0b (flutter/engine#46980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
-
Andrew Kolos authored
Fixes https://github.com/flutter/flutter/issues/134279. Changes: * Moves all tests of `--dart-define-from-file` behavior from `build_bundle_test.dart` and `assemble_test.dart` to `flutter_command_test.dart`. * Deletes a duplicate test of malformed JSON detection behavior. * Renames the `useDartDefineFromFileOption` method of `FlutterCommand` to `_usesDartDefineFromFileOption`. This 1) makes the name more consistent with the other `uses*Option` methods and 2) hides the method since it is not used outside of the file. * Renames several tests to better articulate what is under test and what the expected result is. * Adds a test for the case where a `.env` file with a malformed line is provided to `--dart-define-from-file`.
-
![auto-submit[bot]'s avatar](https://secure.gravatar.com/avatar/266ceac20512ae5366aafb5e5452ef8b?s=80&d=identicon "auto-submit[bot]")
