• Andrew Kolos's avatar
    clean up `--dart-define-from-file` option tests (#135980) · cdc40b52
    Andrew Kolos authored
    Fixes https://github.com/flutter/flutter/issues/134279.
    
    Changes:
    * Moves all tests of `--dart-define-from-file` behavior from `build_bundle_test.dart` and `assemble_test.dart` to `flutter_command_test.dart`.
    * Deletes a duplicate test of malformed JSON detection behavior.
    * Renames the `useDartDefineFromFileOption` method of `FlutterCommand` to `_usesDartDefineFromFileOption`. This 1) makes the name more consistent with the other `uses*Option` methods and 2) hides the method since it is not used outside of the file.
    * Renames several tests to better articulate what is under test and what the expected result is.
    * Adds a test for the case where a `.env` file with a malformed line is provided to `--dart-define-from-file`.
    cdc40b52
Name
Last commit
Last update
.github Loading commit data...
.vscode Loading commit data...
bin Loading commit data...
dev Loading commit data...
examples Loading commit data...
packages Loading commit data...
.ci.yaml Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
CODEOWNERS Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
PATENT_GRANT Loading commit data...
README.md Loading commit data...
TESTOWNERS Loading commit data...
analysis_options.yaml Loading commit data...
dartdoc_options.yaml Loading commit data...
flutter_console.bat Loading commit data...