- 13 Mar, 2024 1 commit
-
-
Matej Knopp authored
Fixes https://github.com/flutter/flutter/issues/144102 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [Features we expect every widget to implement]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat [Data Driven Fixes]: https://github.com/flutter/flutter/wiki/Data-driven-Fixes
-
- 26 Feb, 2024 1 commit
-
-
Nate authored
This pull request is part of the effort to solve issue #136139. The previous [`switch` expressions PR](https://github.com/flutter/flutter/pull/143496) was comprised of many simple changes throughout `flutter/lib/src/`, but due to some more in-depth refactoring in `flutter/lib/src/rendering/`, I decided to submit the changes to this directory as a separate pull request. There was really just one function that I changed significantly; I'll add a comment for explanation.
-
- 16 Feb, 2024 1 commit
-
-
Nate authored
This PR is the 8áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable. (previous pull requests: #139048, #139882, #141591, #142279, #142634, #142793, #143293) I did a pass through all of `packages/flutter/lib/src/` and found a whole bunch of `switch` statements to improve: most of them were really simple, but many involved some thorough refactoring. This pull request is just the complicated stuff. ð I'll make comments to describe the changes, and then in the future there will be another PR (and it'll be much easier to review than this one).
-
- 13 Oct, 2023 1 commit
-
-
Todd Volkert authored
Some render box subclasses have a specific layout contract that is tightly coupled with other render box subclasses (e.g. two private classes in a local project file). In these cases, it is also possible that they use a constraints object that is a subclass of `BoxConstraints`. To allow for this, this change makes the `constraints` argument to `RenderBox.computeDryLayout()` a covariant argument. For completeness' sake, this updates the other render objects in the rendering package to also use the covariant keyword for this argument.
-
- 28 Sep, 2023 1 commit
-
-
Kate Lovett authored
-
- 27 Sep, 2023 1 commit
-
-
Kate Lovett authored
-
- 20 Sep, 2023 1 commit
-
-
Greg Spencer authored
## Description This removes all of the comments that are of the form "so-and-so (must not be null|can ?not be null|must be non-null)" from the cases where those values are defines as non-nullable values. This PR removes them from the painting and rendering libraries. This was done by hand, since it really didn't lend itself to scripting, so it needs to be more than just spot-checked, I think. I was careful to leave any comment that referred to parameters that were nullable, but I may have missed some. In addition to being no longer relevant after null safety has been made the default, these comments were largely fragile, in that it was easy for them to get out of date, and not be accurate anymore anyhow. This did create a number of constructor comments which basically say "Creates a [Foo].", but I don't really know how to avoid that in a large scale change, since there's not much you can really say in a lot of cases. I think we might consider some leniency for constructors to the "Comment must be meaningful" style guidance (which we de facto have already, since there are a bunch of these). ## Related PRs - https://github.com/flutter/flutter/pull/134984 - https://github.com/flutter/flutter/pull/134991 - https://github.com/flutter/flutter/pull/134992 - https://github.com/flutter/flutter/pull/134994 ## Tests - Documentation only change.
-
- 23 Aug, 2023 1 commit
-
-
Michael Goderbauer authored
Blocking issue (https://github.com/dart-lang/linter/issues/453) for this lint has been resolved.
-
- 16 Jun, 2023 1 commit
-
-
Michael Goderbauer authored
It's time to say good bye to an old friend. It has outlived its usefulness. Farewell, AbstractNode! ð«¡
-
- 31 Mar, 2023 1 commit
-
-
Kate Lovett authored
Fix docs and error messages for scroll directions + sample code
-
- 23 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 22 Mar, 2023 1 commit
-
-
Michael Goderbauer authored
Remove 1745 decorative breaks
-
- 20 Mar, 2023 1 commit
-
-
Kate Lovett authored
Fix error message for unbounded viewports
-
- 21 Jan, 2023 1 commit
-
-
Michael Goderbauer authored
-
- 31 Oct, 2022 1 commit
-
-
Greg Spencer authored
-
- 27 Jul, 2022 1 commit
-
-
LongCatIsLooong authored
Suggest predicate-based formatter in [FilteringTextInputFormatter] docs for whole string matching (#107848)
-
- 24 Jun, 2022 1 commit
-
-
Alexandre Ardhuin authored
-
- 25 May, 2022 1 commit
-
-
Pierre-Louis authored
* Use `curly_braces_in_flow_control_structures` for `rendering` * fix comments * fix dangling
-
- 20 May, 2022 1 commit
-
-
Casey Hillers authored
-
- 19 May, 2022 2 commits
-
-
Jonah Williams authored
-
Dan Field authored
-
- 18 May, 2022 1 commit
-
-
gaaclarke authored
-
- 17 May, 2022 1 commit
-
-
Dan Field authored
-
- 14 Apr, 2022 1 commit
-
-
Michael Goderbauer authored
-
- 21 Mar, 2022 1 commit
-
-
Pierre-Louis authored
* fix deprecated_new_in_comment_reference for `material` library in a future version of the SDK, these will be flagged, fix them now * Update pubspec.yaml
-
- 12 Dec, 2021 1 commit
-
-
Dan Field authored
-
- 20 Oct, 2021 1 commit
-
-
Kate Lovett authored
-
- 01 Oct, 2021 1 commit
-
-
Kate Lovett authored
-
- 30 Aug, 2021 1 commit
-
-
chunhtai authored
Reland "Fixes listview shrinkwrap and hidden semantics node gets updated incorrectly. (#88814)" (#89184)
-
- 25 Aug, 2021 2 commits
-
-
chunhtai authored
- 03 Aug, 2021 1 commit
-
-
Jonah Williams authored
-
- 28 Jul, 2021 1 commit
-
-
Kate Lovett authored
-
- 25 Jun, 2021 1 commit
-
-
Dan Field authored
-
- 13 May, 2021 1 commit
-
-
Ian Hickson authored
-
- 03 Apr, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 31 Mar, 2021 1 commit
-
-
Alexandre Ardhuin authored
-
- 18 Mar, 2021 1 commit
-
-
Michael Goderbauer authored
-
- 18 Feb, 2021 1 commit
-
-
Ian Hickson authored
-
- 07 Jan, 2021 1 commit
-
-
Nathan Walker authored
-