1. 18 Jul, 2023 1 commit
  2. 17 Jul, 2023 3 commits
  3. 14 Jul, 2023 3 commits
  4. 13 Jul, 2023 7 commits
  5. 12 Jul, 2023 1 commit
  6. 10 Jul, 2023 2 commits
  7. 08 Jul, 2023 1 commit
  8. 07 Jul, 2023 3 commits
  9. 06 Jul, 2023 2 commits
  10. 05 Jul, 2023 2 commits
  11. 01 Jul, 2023 1 commit
  12. 30 Jun, 2023 1 commit
    • Nate Bosch's avatar
      Remove an unnecessary assert (#129796) · 34c092f2
      Nate Bosch authored
      The type variable `T`, when used as an expression, will always be a
      `Type`. The type test `T is! List` is always true (as is `T is Type`).
      
      This expression will become a warning in the analyzer in some upcoming
      release of the Dart SDK.
      
      This `assert` was added in a PR which reapplied an earlier PR, however
      the earlier PR did not include this assert. I do not see any discussion
      indicating the intent of this assert.
      
      The impact of testing this `T` in any way is low - this is a private
      class so we can see all the uses and know that the only type bound to
      `T` is `Uri`. Avoid the upcoming diagnostic and remove the assert
      entirely. This maintains existing behavior but ignores the potential
      intent for the check.
      34c092f2
  13. 29 Jun, 2023 3 commits
  14. 27 Jun, 2023 1 commit
    • Ben Konyi's avatar
      Reland "Fix issue where DevTools would not be immediately available when using... · 5ea2be69
      Ben Konyi authored
      Reland "Fix issue where DevTools would not be immediately available when using --start-paused (#126698)" (#129368)
      
      **Original Description:**
      
      > Service extensions are unable to handle requests when the isolate they
      were registered on is paused. The DevTools launcher logic was waiting
      for some service extension invocations to complete before advertising
      the already active DevTools instance, but when --start-paused was
      provided these requests would never complete, preventing users from
      using DevTools to resume the paused isolate.
      > 
      > Fixes https://github.com/flutter/flutter/issues/126691
      
      **Additional changes in this PR:**
      
      The failures listed in https://github.com/flutter/flutter/pull/128117
      appear to be related to a shutdown race. It's possible for the test to
      complete while the tool is in the process of starting and advertising
      DevTools, so we need to perform a check of `_shutdown` in
      `FlutterResidentDevtoolsHandler` before advertising DevTools.
      
      Before the original fix, this check was being performed immediately
      after invoking the service extensions, which creates an asynchronous gap
      in execution. With #126698, the callsite of the service extensions was
      moved and the `_shutdown` check wasn't, allowing for the tool to attempt
      to advertise DevTools after the DevTools server had been cleaned up.
      
      ---------
      Co-authored-by: 's avatarZachary Anderson <zanderso@users.noreply.github.com>
      5ea2be69
  15. 23 Jun, 2023 2 commits
    • Oleh Prypin's avatar
      Prepare for making `intl` `toBeginningOfSentenceCase` non-nullable (#127488) · 71228e02
      Oleh Prypin authored
      I intend to edit `toBeginningOfSentenceCase`'s return value to be non-nullable because it really is never null. That will mean that non-null asserts around it will become flagged as unnecessary, although right now they are necessary. So, apply a workaround - instead use a function that does a non-null assert without triggering any lints even after it becomes unnecessary.
      71228e02
    • David Iglesias's avatar
      [web] Hides that Flutter uses requireJS in debug. (#129032) · 34b42acf
      David Iglesias authored
      Flutter web uses requireJS in `debug` mode to assemble a DDC-compiled app from a bunch of small files ("modules").
      
      This caused that `canvaskit.js` (and all other modules that used a browserify-like loading header) didn't work because they attempted to use the `define` function provided by Flutter's instance of `requireJS` (which kept the defined modules private, rather than as globals on the page, as the users of the JS expected).
      
      A [fix](https://github.com/flutter/engine/pull/27342) was added to `flutter/engine` to trick loaders into *not* using the `requireJS` module loader, but a recent change in the fix's js-interop layer *subtly* changed its JS output on the page (objects went from `undefined` to `null`), causing this:
      
      * https://github.com/flutter/flutter/issues/126131 (and others)
      
      This PR hides a bit of code that is commonly used by module loaders to decide that they may use the `define` function provided by requireJS (so the engine workaround can be removed).
      
      ## Next steps
      
      * https://github.com/flutter/engine/pull/42941
      
      ## Issues
      
      Partially addresses: https://github.com/flutter/flutter/issues/126131 (and others)
      
      ## Tests
      
      * Added a unit test to ensure the `delete` stays
      * Manually tested with the Gallery app in `debug` mode with a bunch of user-supplied scripts that currently fail to load.
        * Also tested hot restart as suggested by @nshahan
      34b42acf
  16. 22 Jun, 2023 3 commits
  17. 21 Jun, 2023 2 commits
  18. 20 Jun, 2023 2 commits