- 03 Jul, 2018 4 commits
-
-
Mikkel Nygaard Ravn authored
-
Danny Tuppeny authored
* Include stdout/stderr in failure messages Sometimes some of these tests unexpectedly fail with a non-zero exit code. This ensures stdout/stderr is included in the test failure message when this happens so that we can track down the issue. * Remove redundant info about exit code * Remove unnecessary indenting The [markers] make it fairly clear so this just makes the test code noisy.
-
Danny Tuppeny authored
Fixes #18995.
-
Greg Price authored
This logic is described in the test as looking for a scroll ending very close to a new page, but in fact its behavior is more like "very close to a page to the right": if we're not very, very close to any page, it will pick the page to the left, not an old page. There's no reason this should be left-right asymmetrical. Instead, pick the nearest page. In practice, the case where this makes a difference never arises when the scroll runs undisturbed to completion; but when the user taps on the page to hold or drag, the scroll will be interrupted before it gets within tolerance of a particular page, and this case does arise. This fixes a glitch that is hard to trigger without time dilation, but is quite conspicuous with it: * Open a tab view with at least 4 tabs, e.g. the Buttons screen of the gallery (with "Animate Slowly" on.) * Starting at tab 0, tap tab 2. * When the animation is nearly complete, tap the page a couple of times, as if to drag it around to scroll. Then let the page view settle ballistically toward page 2. * Before it finishes, tap tab 3. * Suddenly page 1 fills the view, replacing page 2, before we scroll from there to page 3. With this fix, the animation in the last step moves smoothly from where we are when it starts onward to page 3.
-
- 02 Jul, 2018 7 commits
-
-
liyuqian authored
-
Michael Goderbauer authored
Also: * Export TextInputAction from `text_field.dart` to parallel `TextInputType`.
-
Andrew Davies authored
Before a severe log would be raised when timeout happens. Now that testing connections requires potentially running into a timeout, this will cause failures when there shouldn't be any.
-
-
Mikkel Nygaard Ravn authored
-
Mikkel Nygaard Ravn authored
-
matthew-carroll authored
* Support all keyboard actions. (#11344)
-
- 01 Jul, 2018 1 commit
-
-
Mark Fielbig authored
-
- 29 Jun, 2018 6 commits
-
-
Ian Hickson authored
-
sjindel-google authored
Fixes #18829
-
Mikkel Nygaard Ravn authored
-
Danny Tuppeny authored
-
Danny Tuppeny authored
Otherwise on Windows these will fail as an unsupported platform when things try to read defaultTargetPlatform in flutter apps.
-
Mikkel Nygaard Ravn authored
-
- 28 Jun, 2018 17 commits
-
-
liyuqian authored
This fixes #18727
-
liyuqian authored
Goldens for flutter/flutter#18729
-
liyuqian authored
Our first step towards https://github.com/flutter/flutter/issues/18727
-
Alexander Aprelev authored
-
Danny Tuppeny authored
This test was designed to ensure flutter_tester keeps running (previously it would quit immediately). However it's turned out ot be rather flaky and we have new tests on the way that supersede this by actually testing real things (debug stepping, reloading, expression evaluation).
-
Mikkel Nygaard Ravn authored
-
Danny Tuppeny authored
* Remove the 'app' domain from flutter daemon By default the daemon won't register the "app" domain, you need to opt-in (which the 'run' command does, as well as the tests for the app functionality). Fixes #6658. * Tweak text * Put restart/callServiceExtension/stop back into daemon mode * Add a comment about removing discoverApps
-
Danny Tuppeny authored
* Fix typo * Add emulator.create to Daemon API * Swap order of daemon changelog entries
-
Florian Loitsch authored
-
Sigurd Meldgaard authored
Add iOS module template This will enable integration of flutter-views into existing iOS project.
-
-
Sigurd Meldgaard authored
This reverts commit 8be198d8 that broke the build.
-
Danny Tuppeny authored
After landing the un-skip this test failed with a timeout. It then passed on the next build (!). I think it's too flaky to leave running until we can better diagnose what's happening.
-
Sigurd Meldgaard authored
Add iOS module template This will enable integration of flutter-views into existing iOS project.
-
Danny Tuppeny authored
* Add process output for flutter_tester test and unskip * Add a comment about this potential flake
-
Danny Tuppeny authored
* Add --create option to flutter emulators * Tweaks to error message * Simplify emulator search logic * Make name optional * Add a note about this option being used with --create * Tweaks to help information * Switch to processManager for easier testing * Don't crash on missing files or missing properties in Android Emulator * Move name suffixing into emulator manager This allows it to be tested in the EmulatorManager tests and also used by daemon later if desired. * Pass the context's android SDK through so it can be mocked by tests * Misc fixes * Add tests around emulator creation Process calls are mocked to avoid needing a real SDK (and to be fast). Full integration tests may be useful, but may require ensuring all build environments etc. are set up correctly. * Simplify avdManagerPath Previous changes were to emulatorPath! * Fix lint errors * Fix incorrect file exgtension for Windows * Fix an issue where no system images would crash reduce throws on an empty collection. * Fix "null" appearing in error messages The name we attempted to use will now always be returned, even in the case of failure. * Add additional info to missing-system-image failure message On Windows after installing Andriod Studio I didn't have any of these and got this message. Installing with sdkmanager fixed the issue. * Fix thrown errors runResult had a toString() but we moved to ProcessResult when switching to ProcessManager to this ended up throwing "Instance of ProcessResult". * Fix package import * Fix more package imports * Move mock implementation into Mock class There seemed to be issues using Lists in args with Mockito that I couldn't figure out (docs say to use typed() but I couldn't make this compile with these lists still).. * Rename method that's ambigious now we have create * Handle where there's no avd path * Add another toList() :( * Remove comment that was rewritten * Fix forbidden import * Make optional arg more obviously optional * Reformat doc * Note that we create a pixel device in help text * Make this a named arg
-
Jason Simmons authored
Fixes https://github.com/flutter/flutter/issues/18007
-
- 27 Jun, 2018 5 commits
-
-
Ian Hickson authored
This is an attempt to reland #18488 with less breakage on macOS.
-
Alexander Aprelev authored
This also improves diagnostic in case of internal compiler errors.
-
Danny Tuppeny authored
See #18879.
-
Danny Tuppeny authored
This reverts commit 5d8ea59d.
-
Danny Tuppeny authored
-