1. 19 Sep, 2018 1 commit
  2. 13 Sep, 2018 1 commit
  3. 12 Sep, 2018 1 commit
  4. 06 Sep, 2018 4 commits
    • Danny Tuppeny's avatar
      Remove flutter_tester test (#21493) · cc1766d4
      Danny Tuppeny authored
      I'm working on fixing up all tests that rely on fs.currentDirectory to allow us to run concurrently. This one proved to be really tricky because it calls a lot of code and spawns multiple processes that have a mix of absolute and relative paths passed to them. I managed to handle some of it with a ChrootFileSystem, but the paths passed to the external processes were wrong.
      
      The functionality here is covered by all of the integration tests that use flutter_tester that were added after this, including flutter_run_test.dart, lifetime_test.dart etc. in this same folder but because they're run through `flutter run` as a separate process they get to set their own working directories without affecting other tests if run concurrently.
      cc1766d4
    • Danny Tuppeny's avatar
      Add a detach command to detach without terminating (#21490) · 7fc9165e
      Danny Tuppeny authored
      * Add a detach command to detach without terminating (#21376)
      
      * Add a detach command to detach without terminating
      
      Fixes #21154.
      
      * Bump protocol version for app.detach
      
      * Tweak to detach/quit text
      
      * Change logPrefix to named param
      
      * Fix the text that the devicelab attach test looks for
      7fc9165e
    • Danny Tuppeny's avatar
      Rename test file to end with _test so it runs on the bots (#21438) · 7e3ebfc7
      Danny Tuppeny authored
      * Rename test file
      
      * Fix detection to work regardless of whether there are other devices
      
      On Windows we get one message, but on Mac we get another (because of the Simulator always being available).
      7e3ebfc7
    • Jonah Williams's avatar
  5. 05 Sep, 2018 4 commits
  6. 04 Sep, 2018 1 commit
  7. 31 Aug, 2018 1 commit
  8. 30 Aug, 2018 1 commit
  9. 29 Aug, 2018 1 commit
    • Danny Tuppeny's avatar
      Swap order of attach/stop in flutter_attach integration test (#21106) · a9275d21
      Danny Tuppeny authored
      This is a bit of a stab in the dark for a flake sometimes seen on bots (but I can't repro locally) #20822. Detaching from a Flutter app currently seems to terminate it, so it may be the cause of the "app not found" when trying to stop the app subsequently.
      
      This change means we stop the app from the main process first, before terminating the attach process.
      a9275d21
  10. 28 Aug, 2018 1 commit
    • Danny Tuppeny's avatar
      Don't time out if process terminates when told to stop (#21103) · 8b0227b4
      Danny Tuppeny authored
      * Don't time out if process terminates when told to stop but response was not processed
      
      While trying to reproduce #20822 I found a condition where the app may quit before the `app.stop` response is received but this code (which is called in integration test teardown) would sit around waiting and time out. With this change, the process exit is considered a valid response to the stop request.
      
      * Add process exit to log for better errors in failures
      
      This log can be turned on for debugging but is also dumped when a test fails (in certain conditions). With this in the log, it'll be clear if the timeout is because we're waiting for an event but the process quit.
      8b0227b4
  11. 27 Aug, 2018 1 commit
  12. 22 Aug, 2018 2 commits
  13. 21 Aug, 2018 1 commit
  14. 17 Aug, 2018 1 commit
    • Ian Hickson's avatar
      Clean up usage of temporary directories (#20682) · 3dec6a69
      Ian Hickson authored
      All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.
      
      I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.
      
      While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.
      
      Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
      3dec6a69
  15. 15 Aug, 2018 4 commits
    • Martin Kustermann's avatar
      Reland "Roll engine to version e3687f70c7ece72000b32ee1b3c02755ba5361ac (#20427)" (#20633) · 9299c02c
      Martin Kustermann authored
      * Reland "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)"
      
      This is a re-land with downgraded `package:flutter_gallery_assets`
      version.
      
      * Downgrade package:flutter_gallery_assets to 0.1.4
      
      * Change engine.version to 81baff97c29bb08cbf8453a3f9042c5813f84ad3 (which contains an additional fix)
      
      * Change engine.version to e3687f70c7ece72000b32ee1b3c02755ba5361ac (since mac tarballs are corrupted on earlier commit)
      9299c02c
    • Martin Kustermann's avatar
      Revert "Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427)" (#20631) · 515909ec
      Martin Kustermann authored
      Reason for revert: The package:flutter_gallery_assets has removed some images which are required for the examples/flutter_gallery, so the gallery build is failing (only discovered after landing, since gallery doesn't seem to get built during github PR presubmit checks)
      515909ec
    • Martin Kustermann's avatar
      Roll engine to version b148e628ec86b3a9a0382e0bcfae73f0390a8232 (#20427) · c7c493ea
      Martin Kustermann authored
      This CL
      
        * rolls `engine.version` to flutter/engine@b148e628 (which includes dart sdk 2.1.0-dev)
        * rolls `goldens.version` to flutter/goldens@6c45fafdf (which includes updates due to skia changes in engine)
        * changes `platform.dill` to `platform_strong.dill` in various places due to flutter/engine@a84b210b
        * adds explicit `environment: sdk: ">=2.0.0-dev.68 < 3.0.0"` constraints to `pubspec.yaml` and `pubspec.yaml.tmpl` files (since pub defaults to `<2.0.0` if omitted) 
        * upgrades to newer versions of various 3rd party packages (to ensure transitive dependencies have `<3.0.0` sdk constraint)
      c7c493ea
    • Ian Hickson's avatar
      Shim package:test to avoid matcher issues (#20602) · 686d8f8a
      Ian Hickson authored
      * Upgrade everything except matcher.
      * Roll matcher (and test)
      * Adjust tests that depend on flutter:test directly to depend on a shim
      * Require use of package:test shim and remove other references to package:test
      686d8f8a
  16. 02 Aug, 2018 1 commit
  17. 01 Aug, 2018 1 commit
    • Danny Tuppeny's avatar
      Skip tests that are expected to fail with timeouts (#20074) · 93705691
      Danny Tuppeny authored
      * Skip tests instead of expecting failure, because expected failure = timeout which is slow
      
      Some of these tests are known to fail and were coded to expect it; however because the failure is a timeout it's just dragging out test runs (shortening timeouts will make the tests flakier).
      
      * Make it easier to find skipped tests
      
      * Change SKIP to TODO
      93705691
  18. 31 Jul, 2018 1 commit
  19. 27 Jul, 2018 1 commit
  20. 25 Jul, 2018 5 commits
  21. 23 Jul, 2018 1 commit
  22. 20 Jul, 2018 1 commit
  23. 19 Jul, 2018 4 commits
    • Danny Tuppeny's avatar
      Fix copy/paste error in test (#19564) · d9ee971e
      Danny Tuppeny authored
      d9ee971e
    • amirh's avatar
      c1de12dd
    • Danny Tuppeny's avatar
      Add `--machine` support for `flutter attach` (#19077) · ed9afbbc
      Danny Tuppeny authored
      * Extract some of startApp into a reusable method
      
      * Get basic attach --machine working
      
      * Attach --machine tweaks
      
      Move validation to validate method and create daemon early so we get the startup event before trying to get a connection.
      
      * Bump daemon version so we know whether it's valid to flutter attach
      
      * Tweak output text
      
      * Swap package imports for relative
      
      * Review tweaks (naming, formatting, typedefs)
      
      * Separate arguments from process spawning
      
      This will make calling attach easier
      
      * Add a basic test for flutter attach --machine
      
      * Fix crash if port unforward modifies the list of forwarded ports
      
      * Add a no-op port forwarder for flutter-tester
      
      * Switch to using BasicProject instead of our own inline code
      
      * Fix expectation in test now we have a portForwarder
      
      * Remove stale TODO (this is done)
      
      * Tweak formatting
      
      * Change some Completers to void to fix Dart 2 issues
      ed9afbbc
    • Danny Tuppeny's avatar
      Make cleanup of flutter processes in tests more reliable (#19307) · 442fc3cf
      Danny Tuppeny authored
      * Make cleanup of flutter processes in tests more reliable
      
      * Fix quit signals
      
      I confused SigInt&SigTerm for SigTerm&SigKill when I first did this. SigTerm can be blocked and doesn't guarantee the process will be terminated.
      
      * Don't use deprecated constants
      
      * Fix typo
      
      * Add some additional info to debug buffer
      
      * Fix return types on Futures
      442fc3cf