Unverified Commit db7aa6a0 authored by Danny Tuppeny's avatar Danny Tuppeny Committed by GitHub

Unskip passing tests on Windows + add a new failing test with GH reference (#21351)

* Unskip integration tests on Windows that now pass

The referenced issue is closed and these tests pass for me locally on Windows now.

* Remove import that's no longer used

* Add another issue that is afffecting these tests on Windows

* Add a hot restart test and mark skip on Windows

Skipped due to https://github.com/flutter/flutter/issues/21348.
parent cd65903f
......@@ -110,5 +110,6 @@ void main() {
});
// TODO(dantup): Unskip after flutter-tester is fixed on Windows:
// https://github.com/flutter/flutter/issues/17833.
// https://github.com/flutter/flutter/issues/21348.
}, timeout: const Timeout.factor(6), skip: platform.isWindows);
}
......@@ -13,7 +13,7 @@ import 'test_data/basic_project.dart';
import 'test_driver.dart';
void main() {
group('hot reload', () {
group('hot', () {
Directory tempDir;
final BasicProject _project = new BasicProject();
FlutterTestDriver _flutter;
......@@ -29,12 +29,19 @@ void main() {
tryToDelete(tempDir);
});
test('works without error', () async {
test('reload works without error', () async {
await _flutter.run();
await _flutter.hotReload();
});
test('hits breakpoints with file:// prefixes after reload', () async {
test('restart works without error', () async {
await _flutter.run();
await _flutter.hotRestart();
// TODO(dantup): Unskip after flutter-tester restart issue is fixed on Windows:
// https://github.com/flutter/flutter/issues/21348.
}, skip: platform.isWindows);
test('reload hits breakpoints with file:// prefixes after reload', () async {
await _flutter.run(withDebugger: true);
// Hit breakpoint using a file:// URI.
......
......@@ -6,7 +6,6 @@ import 'dart:async';
import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/platform.dart';
import '../src/common.dart';
import 'test_data/basic_project.dart';
......@@ -45,7 +44,5 @@ void main() {
await new Future<void>.delayed(requiredLifespan);
expect(_flutter.hasExited, equals(false));
});
// TODO(dantup): Unskip after flutter-tester is fixed on Windows:
// https://github.com/flutter/flutter/issues/17833.
}, timeout: const Timeout.factor(6), skip: platform.isWindows);
}, timeout: const Timeout.factor(6));
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment