Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7dd82813
Unverified
Commit
7dd82813
authored
Sep 19, 2018
by
Danny Tuppeny
Committed by
GitHub
Sep 19, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove -j1 to run tools tests concurrently (#22038)
Fixes #21113.
parent
4108240a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
9 deletions
+3
-9
test.dart
dev/bots/test.dart
+0
-5
README.md
packages/flutter_tools/README.md
+1
-1
README.md
packages/flutter_tools/test/integration/README.md
+2
-3
No files found.
dev/bots/test.dart
View file @
7dd82813
...
...
@@ -144,7 +144,6 @@ Future<Null> _runToolTests() async {
await
_pubRunTest
(
path
.
join
(
flutterRoot
,
'packages'
,
'flutter_tools'
),
enableFlutterToolAsserts:
true
,
runConcurrently:
false
,
);
print
(
'
${bold}
DONE: All tests successful.
$reset
'
);
...
...
@@ -197,13 +196,9 @@ Future<Null> _runCoverage() async {
Future
<
Null
>
_pubRunTest
(
String
workingDirectory
,
{
String
testPath
,
bool
runConcurrently
=
true
,
bool
enableFlutterToolAsserts
=
false
})
{
final
List
<
String
>
args
=
<
String
>[
'run'
,
'test'
,
'-rcompact'
];
if
(!
runConcurrently
)
{
args
.
add
(
'-j1'
);
}
if
(!
hasColor
)
args
.
add
(
'--no-color'
);
if
(
testPath
!=
null
)
...
...
packages/flutter_tools/README.md
View file @
7dd82813
...
...
@@ -6,5 +6,5 @@ To run the tests, ensure that no devices are connected,
then navigate to
`flutter_tools`
and execute:
```
shell
../../bin/cache/dart-sdk/bin/pub run
test
-j1
../../bin/cache/dart-sdk/bin/pub run
test
```
packages/flutter_tools/test/integration/README.md
View file @
7dd82813
...
...
@@ -4,9 +4,8 @@ These tests are not hermetic, and use actual Flutter SDK.
While they don't require actual devices, they run
`flutter_tester`
to test
Dart VM and Flutter integration.
Some of these tests change the current directory for the process,
so only one test can be run at a time. Use this command to run:
Use this command to run:
```
shell
../../bin/cache/dart-sdk/bin/pub run
test
-j1
../../bin/cache/dart-sdk/bin/pub run
test
```
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment