Commits · aaaea51dd2237792cfb4e823feaf42234763a16d · abdullh.alsoleman / Front-End

05 Jul, 2023 4 commits

fix a bug when android uses CupertinoPageTransitionsBuilder... (#114303) · aaaea51d

ipcjs authored Jul 05, 2023

When android uses iOS style `PageTransitionsBuilder` and iOS uses android style `PageTransitionsBuilder`, on android, swipe from the left edge of the screen doesn't work. This PR solves that problem.

#99919 introduced a breaking change, the pr re-implemented it <del>without introducing a breaking change.**</del>

aaaea51d

Add .env file support for option `--dart-define-from-file` (#128668) · 168d8077

Piotr FLEURY authored Jul 05, 2023

# Proposal

I suggest to make possible to specify .env files to the --dart-define-from-file in addition to the Json format.

# Issue

Close #128667

168d8077

Improve documentation for `ColorSheme.fromImageProvider` (#129952) · 35085c39
Pierre-Louis authored Jul 05, 2023
```
Sample code is added, documentation condensed, and links to guidelines updated.

For b/258360306
```
35085c39

Roll Packages from a03b900efc0e to 704207985a21 (2 revisions) (#130013) · a2dbd1ec

engine-flutter-autoroll authored Jul 05, 2023

https://github.com/flutter/packages/compare/a03b900efc0e...704207985a21

2023-07-05 stuartmorgan@google.com [ci] Add a web version of Dart unit tests (flutter/packages#4352)
2023-07-04 engine-flutter-autoroll@skia.org Roll Flutter from aa5f4a28 to 590ef2d4 (5 revisions) (flutter/packages#4373)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a2dbd1ec

04 Jul, 2023 2 commits

Cleanup: stop accepting DiagnosticsNode as input from DevTools. (#129302) · 5b12b746
Polina Cherkasova authored Jul 04, 2023

5b12b746

Roll Packages from cdae854a59b9 to a03b900efc0e (1 revision) (#129957) · 590ef2d4

engine-flutter-autoroll authored Jul 04, 2023

https://github.com/flutter/packages/compare/cdae854a59b9...a03b900efc0e

2023-07-03 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes inspectable compile-time error and crash from equal `NSURL`s (flutter/packages#4340)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

590ef2d4

03 Jul, 2023 3 commits

Roll Packages from 53ed5a0aa9e4 to cdae854a59b9 (9 revisions) (#129918) · ddb16b7d

engine-flutter-autoroll authored Jul 03, 2023

https://github.com/flutter/packages/compare/53ed5a0aa9e4...cdae854a59b9

2023-07-01 engine-flutter-autoroll@skia.org Roll Flutter from ff838bca to aa5f4a28 (29 revisions) (flutter/packages#4363)
2023-07-01 stuartmorgan@google.com [tool] Add a flag to skip cleanup (flutter/packages#4357)
2023-07-01 stuartmorgan@google.com [file_selector] Endorse Android (flutter/packages#4329)
2023-07-01 stuartmorgan@google.com [google_sign_in] Convert Android to Pigeon (flutter/packages#4344)
2023-06-30 tarrinneal@gmail.com [Pigeon] readme updates (flutter/packages#3705)
2023-06-30 43054281+camsim99@users.noreply.github.com [camera_android] Support concurrently image capture and image streaming (flutter/packages#4332)
2023-06-30 kustermann.martin@gmail.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/packages#4342)
2023-06-30 tarrinneal@gmail.com [shared_preferences] Adds allowList to setPrefix method. (flutter/packages#3794)
2023-06-30 engine-flutter-autoroll@skia.org Roll Flutter from 51bef1b6 to ff838bca (12 revisions) (flutter/packages#4346)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ddb16b7d

Roll Flutter Engine from e6b8292705a8 to 987b621eac4e (1 revision) (#129863) · 1b51de9e

engine-flutter-autoroll authored Jul 03, 2023

https://github.com/flutter/engine/compare/e6b8292705a8...987b621eac4e

2023-07-01 skia-flutter-autoroll@skia.org Roll Skia from 2d05e3ec6b67 to ceaeef84b8a3 (1 revision) (flutter/engine#43355)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

1b51de9e

Add an example showing how to use textures (#122779) · 9760bb0c

Robert Ancell authored Jul 03, 2023

There didn't seem to be any examples on how to do this.

I've only shown the Linux implementation, others may want to follow this
PR up with support for other platforms.

9760bb0c

01 Jul, 2023 2 commits

Update links to old linter site to dart.dev (#129866) · 63a8298d

Parker Lougheed authored Jul 01, 2023

Removes the remaining links to the old linter site, to the guaranteed dart.dev/lints redirect.

Contributes to https://github.com/dart-lang/linter/issues/4460 and https://github.com/dart-lang/site-www/issues/4499

63a8298d

Enable no_wildcard_variable_uses lint (#129858) · aa5f4a28

Michael Goderbauer authored Jul 01, 2023

Wildcard parameters and local variables (e.g. underscore-only names like _, __, ___, etc.) will become non-binding in a future version of the Dart language. Any existing code that uses wildcard parameters or variables will break. In anticipation of this change, and to make adoption easier, this lint disallows wildcard and variable parameter uses.

We had no violations of this in the framework. Let's keep it that way!

aa5f4a28

30 Jun, 2023 20 commits

mark packages-autoroller bringup again (#129859) · 97fce9aa

Christopher Fujino authored Jun 30, 2023

Even after updating the account (and the cloudKMS GitHub token), when
the bot tries to push to
https://github.com/flutter-pub-roller-bot/flutter, it gets a 403, which
probably means authentication failed. I will have to investigate next
week.

```
Exception: GitException: Exception on command "push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1": Command "git push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1" failed in directory "/b/s/w/ir/x/w/flutter_conductor_checkouts/framework" to update the release branch with the commit. Git exited with error code 128.
stderr from git:
16:33:21.199510 exec-cmd.c:90           trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/bin/git
16:33:21.199587 exec-cmd.c:237          trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/bin
16:33:21.200155 git.c:460               trace: built-in: git push https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git packages-autoroller-branch-1:packages-autoroller-branch-1
16:33:21.200542 run-command.c:655       trace: run_command: GIT_DIR=.git git remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.201787 exec-cmd.c:90           trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/libexec/git-core/git
16:33:21.201845 exec-cmd.c:237          trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/libexec/git-core
16:33:21.202175 git.c:750               trace: exec: git-remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.202195 run-command.c:655       trace: run_command: git-remote-https https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git https://[GitHub TOKEN]@github.com/flutter-pub-roller-bot/flutter.git
16:33:21.203510 exec-cmd.c:90           trace: resolved executable path from procfs: /b/s/w/ir/cipd_bin_packages/libexec/git-core/git-remote-http
16:33:21.203567 exec-cmd.c:237          trace: resolved executable dir: /b/s/w/ir/cipd_bin_packages/libexec/git-core
remote: Permission to flutter-pub-roller-bot/flutter.git denied to flutter-pub-roller-bot.
fatal: unable to access 'https://github.com/flutter-pub-roller-bot/flutter.git/': The requested URL returned error: 403
```


https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20packages_autoroller/6031/overview

This is still being tracked in
https://github.com/flutter/flutter/issues/129744

97fce9aa

Update `SwitchTheme` tests for M2/M3 (#129811) · 9249dcc2
Qun Cheng authored Jun 30, 2023

9249dcc2

Change pub roller bot to push to flutter-pub-roller-bot/flutter.git (#129844) · 67b7aa22

Christopher Fujino authored Jun 30, 2023

Fixes https://github.com/flutter/flutter/issues/129744
Part of https://github.com/flutter/flutter/issues/129847

Migrate the packages_autoroller script to push to
flutter-pub-roller-bot/flutter.git, rather than
fluttergithubbot/flutter.git.

67b7aa22

Fix NetworkImage causing spurious warning in tests (#129537) · 1153371a

Greg Price authored Jun 30, 2023

Fixes #129532.

This ensures that when a test properly uses `debugNetworkImageHttpClientProvider` to tell `NetworkImage` to use a fake `HttpClient`, we don't go ahead and try to instantiate `HttpClient` anyway and generate a misleading warning.

1153371a

Roll Flutter Engine from 54b573e9c4e5 to e6b8292705a8 (4 revisions) (#129852) · 84068857

engine-flutter-autoroll authored Jun 30, 2023

https://github.com/flutter/engine/compare/54b573e9c4e5...e6b8292705a8

2023-06-30 jonahwilliams@google.com [Impeller] cache MSAA texture in swapchain for devices that do not support memoryless. (flutter/engine#43349)
2023-06-30 jonahwilliams@google.com [Impeller] Fix validation error in position color shader. (flutter/engine#43356)
2023-06-30 109111084+yaakovschectman@users.noreply.github.com Fix inverted boolean in Windows document selection changed a11y event (flutter/engine#43281)
2023-06-30 bdero@google.com Revert "Reland "add non-rendering operation culling to DisplayListBuilder" (#41463)" (flutter/engine#43358)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

84068857

Upgrade integration tests to use AGP 7.3/Gradle 7.4 (#129642) · d1eb1f0a

gmackall authored Jun 30, 2023

Upgrades tests under `dev/integration_tests` to use the latest values [in the templates](https://github.com/flutter/flutter/blob/944d6c8fef76b2db7a2c33eeb1653de2b8571fd8/dev/tools/bin/generate_gradle_lockfiles.dart#L135). Most of this PR was auto-generated, by running `find dev/integration_tests/ -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart` from the root of the flutter directory.

The pieces that were not are:
1. Upgrading the Gradle versions used in integration tests to be >=7.4, in places where it was currently lower.
2. Upgrading the mac, windows, and linux build_tests .ci.yaml configuration to use jdk 17 on all shards. It currently was using a mix of 17 and 11. This isn't desirable, because some of the tests require 17, and the distribution is [random across shards](https://github.com/flutter/flutter/blob/cef9a8c54b766fa5f66e6fbdf7df341176f8e29f/dev/bots/test.dart#L553) (so they were only passing because they were getting randomly placed on shards using jdk 17).
3. Adding a dependency on jdk 11 for the tests based on the `firebaselab/firebaselab` recipe. Previously they had no java dependency, and were therefore defaulting to java 1.8. The newer AGP versions necessitated an upgrade to 11 to run.

Note that it also ended up downgrading the AGP version in two places (in the [hybrid_android_views](https://github.com/flutter/flutter/pull/129642/files#diff-d7cfaa1c96d5c2383e7fc253ac8c9df062b544c24f7d80aa8a02290c01d17205L17) and [platform_interaction](https://github.com/flutter/flutter/pull/129642/files#diff-b2fba811efadd1cfb097bebd93be99fe4b6d6f17aefa863267290fc704290766L17) tests), because those had been manually edited to a newer version than the template.

Related to: https://github.com/flutter/flutter/issues/123636, https://github.com/flutter/flutter/pull/123910

d1eb1f0a

Roll Packages from d4752c40696e to 53ed5a0aa9e4 (5 revisions) (#129837) · b1aa0d9d

engine-flutter-autoroll authored Jun 30, 2023

https://github.com/flutter/packages/compare/d4752c40696e...53ed5a0aa9e4

2023-06-30 me@jxstxn.dev [google_maps_flutter_web] Add padding to newLatLngBounds implementation (flutter/packages#3452)
2023-06-29 stuartmorgan@google.com [various] Remove unused flutter_driver dependencies (flutter/packages#4347)
2023-06-29 stuartmorgan@google.com [ci] Add LUCI version of dart unit tests (flutter/packages#4265)
2023-06-29 49699333+dependabot[bot]@users.noreply.github.com [pigeon]: Bump org.jetbrains.kotlin:kotlin-gradle-plugin from 1.8.21 to 1.8.22 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#4189)
2023-06-29 tarrinneal@gmail.com [shared_preferences] Adds new clearWithParameters and getAllWithParameters methods to all platforms. (flutter/packages#4262)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b1aa0d9d

Updated correct tasks for test ownership fix (#129812) · 089b46ba

Ricardo Amador authored Jun 30, 2023

Update a few of the tasks that are mislabeled as this will cause failures if that change is merged first.

This PR is needed before: https://github.com/flutter/cocoon/pull/2898

*List which issues are fixed by this PR. You must list at least one issue.*
Part of https://github.com/flutter/flutter/issues/125328

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

089b46ba

Updated some golden image tests for M2/M3 (#129794) · 26ad4a4a

Hans Muller authored Jun 30, 2023

Updated some of the golden image tests that were temporarily changed in https://github.com/flutter/flutter/pull/128914 to have M2 and M3 versions.

Updated the linear_gradient_0 example to M3 (which will require updating its golden image as well).

More info in https://github.com/flutter/flutter/issues/127064

26ad4a4a

Remove an unnecessary assert (#129796) · 34c092f2

Nate Bosch authored Jun 30, 2023

The type variable `T`, when used as an expression, will always be a
`Type`. The type test `T is! List` is always true (as is `T is Type`).

This expression will become a warning in the analyzer in some upcoming
release of the Dart SDK.

This `assert` was added in a PR which reapplied an earlier PR, however
the earlier PR did not include this assert. I do not see any discussion
indicating the intent of this assert.

The impact of testing this `T` in any way is low - this is a private
class so we can see all the uses and know that the only type bound to
`T` is `Uri`. Avoid the upcoming diagnostic and remove the assert
entirely. This maintains existing behavior but ignores the potential
intent for the check.

34c092f2

Update `Radio` tests for M2/M3 (#129814) · 1ed54f8e

Qun Cheng authored Jun 30, 2023

Updated unit tests for `Radio` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

1ed54f8e

Update `Switch` tests for M2/M3 (#129810) · 0bb9409f

Qun Cheng authored Jun 30, 2023

Updated and reorganized unit tests for `Switch` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

0bb9409f

Roll Flutter Engine from 099a70ebbc60 to 54b573e9c4e5 (1 revision) (#129821) · 2fefe72c

engine-flutter-autoroll authored Jun 30, 2023

https://github.com/flutter/engine/compare/099a70ebbc60...54b573e9c4e5

2023-06-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from nboAFpQUzwtrESDVo... to iwgWLB4KaXslnaGwK... (flutter/engine#43357)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from nboAFpQUzwtr to iwgWLB4KaXsl

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

2fefe72c

Update `SwitchListTile` tests for M2/M3 (#129809) · 2e4122cc

Qun Cheng authored Jun 30, 2023

Updated and reorganized unit tests for `SwitchListTile` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

2e4122cc

Fix `NavigationDrawer` selected item has wrong icon color (#129625) · 7cef9661

Taha Tesser authored Jun 30, 2023

fixes [NavigationDrawer selected item has wrong icon color [Material3 spec]](https://github.com/flutter/flutter/issues/129572)

### Description
This PR fixes a mistake in the `NavigationDrawer` defaults, where generated token value returns a `null`. 
This issue can be detected when you want to customize the selected icon color for `NavigationDrawerDestination` using a custom color scheme.

### Code sample

<details> 
<summary>expanded to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      themeMode: ThemeMode.light,
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(seedColor: Colors.blue).copyWith(
          onSecondaryContainer: Colors.red,
        ),
        useMaterial3: true,
      ),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('NavigationDrawer Sample'),
      ),
      drawer: const NavigationDrawer(
        children: <Widget>[
          NavigationDrawerDestination(
            icon: Icon(Icons.favorite_outline_rounded),
            label: Text('Favorite'),
            selectedIcon: Icon(Icons.favorite_rounded),
          ),
          NavigationDrawerDestination(
            icon: Icon(Icons.favorite_outline_rounded),
            label: Text('Favorite'),
          ),
        ],
      ),
    );
  }
}
``` 
	
</details>

### Before
 
<img width="1053" alt="Screenshot 2023-06-27 at 13 24 38" src="https://github.com/flutter/flutter/assets/48603081/18c13a73-688f-4586-bb60-bddef45d173f">

### After

<img width="1053" alt="Screenshot 2023-06-27 at 13 24 25" src="https://github.com/flutter/flutter/assets/48603081/8a1427c6-517f-424a-b0bd-24bad7c5fbb0">

7cef9661

Update basic_test.dart for M3 compliance (#129714) · 3a6d6615

Bruno Leroux authored Jun 30, 2023

## Description

This PR fixes two test failures in `basic_test.dart` which surfaced when switching to M3 (see https://github.com/flutter/flutter/pull/127501)

Those failures are related to M3 typography which sets line height to 1.43.

Forcing line height to 1.0 seems reasonable for these particular tests. With this change these two test are successful for both M2 and M3.

## Related Issue

fixes https://github.com/flutter/flutter/issues/129713

## Tests

Updates 2 tests.

3a6d6615

Roll Flutter Engine from d33343430f18 to 099a70ebbc60 (7 revisions) (#129818) · 7b859562

engine-flutter-autoroll authored Jun 30, 2023

https://github.com/flutter/engine/compare/d33343430f18...099a70ebbc60

2023-06-30 ditman@gmail.com [web] Add nonce configuration. (flutter/engine#42829)
2023-06-30 bdero@google.com [Impeller] Unwrap optional procs in EntityPass (flutter/engine#43352)
2023-06-30 bdero@google.com [Impeller] Assign missing user to TODO. (flutter/engine#43351)
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from a1ae27969207 to 2d05e3ec6b67 (1 revision) (flutter/engine#43350)
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from ecc2440be198 to 2d98d9e27dae (1 revision) (flutter/engine#43347)
2023-06-29 jonahwilliams@google.com [Impeller] Check for lazy memory support. (flutter/engine#43339)
2023-06-29 bdero@google.com [Impeller] Remove all double empties (flutter/engine#43345)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7b859562

Roll Flutter Engine from 68cc1a7971d5 to d33343430f18 (2 revisions) (#129801) · d605e874

engine-flutter-autoroll authored Jun 30, 2023

https://github.com/flutter/engine/compare/68cc1a7971d5...d33343430f18

2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from c83f8ba23a80 to
a1ae27969207 (8 revisions) (flutter/engine#43343)
2023-06-29 tamird@google.com Remove unused constants
(flutter/engine#43344)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d605e874

Revert no-response to fork. (#129775) · 732429e3

godofredoc authored Jun 30, 2023

The core action is not scaling well for the # of Prs and bugs of the flutter project.

Bug: https://github.com/flutter/flutter/issues/129771

732429e3

Make `DropdownMenu` be able to scroll to the highlighted item when searching. (#129740) · 91cb2618

Qun Cheng authored Jun 30, 2023

Fixes #120349

This PR enables `DropdownMenu` to automatically scroll to the first matching item when `enableSearch` is true.

<details><summary>video example</summary>

https://github.com/flutter/flutter/assets/36861262/1a7a956c-c186-44ca-9a52-d94dc21cac8a

</details>

91cb2618

29 Jun, 2023 9 commits

Roll Flutter Engine from cd9ce66db14a to 68cc1a7971d5 (10 revisions) (#129799) · a2dc0ed8

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/cd9ce66db14a...68cc1a7971d5

2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from a4d0373cd414 to c83f8ba23a80 (3 revisions) (flutter/engine#43340)
2023-06-29 mdebbar@google.com [web] Move web-only initialization APIs to `dart:ui_web` (flutter/engine#43111)
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 8ada2c4b2947 to a4d0373cd414 (14 revisions) (flutter/engine#43338)
2023-06-29 skia-flutter-autoroll@skia.org Roll Dart SDK from 656201921b30 to ecc2440be198 (1 revision) (flutter/engine#43333)
2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 0c320b3d5b64 to 8ada2c4b2947 (1 revision) (flutter/engine#43332)
2023-06-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fxCNy4QivAngZXkvM... to nboAFpQUzwtrESDVo... (flutter/engine#43334)
2023-06-29 kustermann@google.com Prepare for utf8.encode() to return more precise Uint8List type (flutter/engine#43335)
2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Ensure that the auto-release pool is available when the GoldenPlaygroundTestImpl is destructed (flutter/engine#43322)
2023-06-29 uysalere@gmail.com [fuchsia] Remove strict equality check for SkMatrix comparison for Flâ¦ (flutter/engine#43309)
2023-06-29 jason-simmons@users.noreply.github.com [Impeller] Add an autorelease pool to the GoldenTests fixture (flutter/engine#43323)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fxCNy4QivAng to nboAFpQUzwtr

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a2dc0ed8

Bump actions/labeler from 4.1.0 to 4.2.0 (#129797) · 15513f2c

dependabot[bot] authored Jun 29, 2023

Bumps [actions/labeler](https://github.com/actions/labeler) from 4.1.0 to 4.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p>
<blockquote>
<h2>v4.2.0</h2>
<h2>What's Changed</h2>
<p>In the scope of this release, the following outputs were added by <a href="https://github.com/danielsht86"><code>@âdanielsht86</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/60">#60</a>:</p>
<ul>
<li><code>new-labels</code> - a comma-separated string that contains all newly added labels.</li>
<li><code>all-labels</code> - a comma-separated string that contains all labels currently assigned to the PR.</li>
</ul>
<p>For detailed information, please refer to our <a href="https://github.com/actions/labeler/tree/0967ca812e7fdc8f5f71402a1b486d5bd061fe20#outputs">updated documentation</a>.</p>
<p>The issue of encountering an <code>HttpError: Server Error</code> when adding more than 50 labels has been successfully resolved by <a href="https://github.com/markmssd"><code>@âmarkmssd</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/497">#497</a>. However, it's important to note that the GitHub API imposes a limit of 100 labels. To ensure smooth operation, a warning message that will alert you if the number of labels exceeds this limit was implemented. From this point forward, if more than 100 labels are specified, only the first 100 will be assigned.</p>
<p>The error handling for the <code>Resource not accessible by integration</code> error was added by <a href="https://github.com/jsoref"><code>@âjsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/issues/405">#405</a>. Now, if the workflow is misconfigured, the labeler provides a clear warning and guidance for correction.</p>
<p>This release also includes the following changes:</p>
<ul>
<li>Warn about the limitations of GitHub tokens by <a href="https://github.com/dfandrich"><code>@âdfandrich</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/491">actions/labeler#491</a></li>
<li>Improve readme by <a href="https://github.com/jsoref"><code>@âjsoref</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/589">actions/labeler#589</a></li>
<li>Bump eslint-plugin-jest from 27.2.1 to 27.2.2 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/591">actions/labeler#591</a></li>
<li>Bump eslint from 8.42.0 to 8.43.0 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/592">actions/labeler#592</a></li>
<li>Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/598">actions/labeler#598</a></li>
<li>Bump <code>@âtypescript-eslint/parser</code> from 5.60.0 to 5.60.1 by <a href="https://github.com/dependabot"><code>@âdependabot</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/597">actions/labeler#597</a></li>
<li>Bump <code>@âoctokit/plugin-retry</code> from 5.0.2 to 5.0.4 by <a href="https://github.com/MaksimZhukov"><code>@âMaksimZhukov</code></a> in <a href="https://redirect.github.com/actions/labeler/pull/599">actions/labeler#599</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/dfandrich"><code>@âdfandrich</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/491">actions/labeler#491</a></li>
<li><a href="https://github.com/markmssd"><code>@âmarkmssd</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/497">actions/labeler#497</a></li>
<li><a href="https://github.com/danielsht86"><code>@âdanielsht86</code></a> made their first contribution in <a href="https://redirect.github.com/actions/labeler/pull/60">actions/labeler#60</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/labeler/compare/v4...v4.2.0">https://github.com/actions/labeler/compare/v4...v4.2.0</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/actions/labeler/commit/0967ca812e7fdc8f5f71402a1b486d5bd061fe20"><code>0967ca8</code></a> Added output (<a href="https://redirect.github.com/actions/labeler/issues/60">#60</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/375538a703ac861e63020440563422fc04246dfb"><code>375538a</code></a> Bump <code>@âoctokit/plugin-retry</code> from 5.0.2 to 5.0.4 (<a href="https://redirect.github.com/actions/labeler/issues/599">#599</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/8d17e8ac4c7d8434ccc0ad5c3fdfe2f56f2b2ab3"><code>8d17e8a</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.60.0 to 5.60.1 (<a href="https://redirect.github.com/actions/labeler/issues/597">#597</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/9d45a7438fdc8606099442185bbcf343459eb96f"><code>9d45a74</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.60.0 to 5.60.1 (<a href="https://redirect.github.com/actions/labeler/issues/598">#598</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/130636aba50d83a269b855d2501e05254de1eb5f"><code>130636a</code></a> Bump eslint from 8.42.0 to 8.43.0 (<a href="https://redirect.github.com/actions/labeler/issues/592">#592</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/54aeabf7b5842651b41d9cd2ad20e0caa73563f2"><code>54aeabf</code></a> Bump <code>@âtypescript-eslint/parser</code> from 5.59.11 to 5.60.0 (<a href="https://redirect.github.com/actions/labeler/issues/593">#593</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/899595ff0140593e7e4bfd1d60fb2a54fc949d2c"><code>899595f</code></a> Bump eslint-plugin-jest from 27.2.1 to 27.2.2 (<a href="https://redirect.github.com/actions/labeler/issues/591">#591</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/8056174ee026aec2d0d5596b25946162cd4b1c58"><code>8056174</code></a> Bump <code>@âtypescript-eslint/eslint-plugin</code> from 5.59.11 to 5.60.0 (<a href="https://redirect.github.com/actions/labeler/issues/594">#594</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/7a202e642846429da2c5219d2c934cbbf46a5d94"><code>7a202e6</code></a> fix: Limit number of labels added to 100 (<a href="https://redirect.github.com/actions/labeler/issues/497">#497</a>)</li>
<li><a href="https://github.com/actions/labeler/commit/b5ff161cf08995cdc0c16c4d30f62b6471eb2db2"><code>b5ff161</code></a> Explain misconfigured workflow (<a href="https://redirect.github.com/actions/labeler/issues/405">#405</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/actions/labeler/compare/9fcb2c2f5584144ca754f8bfe8c6f81e77753375...0967ca812e7fdc8f5f71402a1b486d5bd061fe20">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/labeler&package-manager=github_actions&previous-version=4.1.0&new-version=4.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

15513f2c

Roll Flutter Engine from eabb22900b44 to cd9ce66db14a (1 revision) (#129756) · afcf6742

engine-flutter-autoroll authored Jun 29, 2023

https://github.com/flutter/engine/compare/eabb22900b44...cd9ce66db14a

2023-06-29 skia-flutter-autoroll@skia.org Roll Skia from 2b30565d0173 to 0c320b3d5b64 (2 revisions) (flutter/engine#43331)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

afcf6742

Remove `@NonNull` to avoid warning (#129472) · 92969ba8

fzyzcjy authored Jun 29, 2023

Otherwise android studio complains:

> Do not use @NonNull in Kotlin; the nullability is already implied by the Kotlin type MethodCall not ending with ?

![image](https://github.com/flutter/flutter/assets/5236035/0cc2e838-dbf9-409f-8fd8-d4e006f58be6)

92969ba8

Remove use of any (#129793) · bda64b54

Ricardo Amador authored Jun 29, 2023

Remove use of any. This reverts to a previous change. Without any and the newest version this put us back to before the version change.

Restores to this change: https://github.com/flutter/flutter/commit/2be476d4015db8f6c442eefa3e9a897975407d4c
Apparently any is the cause.

I will make a separate issue to track updating of the labeler documentation.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

bda64b54

Prepare for utf8.encode() to return more precise Uint8List type (#129769) · 7068a208

Martin Kustermann authored Jun 29, 2023

To avoid analyzer warnings when utf8.encode() will return the more
precise Uint8List type, we use const Utf8Encoder().convert() which
already returns Uint8List

See https://github.com/dart-lang/sdk/issues/52801

7068a208

Deletes files that should be ignored (#127984) · 7cab354d

lsaudon authored Jun 29, 2023

Some files are supposed to ignore, but don't.

- **/windows/flutter/generated_plugins.cmake
- **/linux/flutter/generated_plugin_registrant.cc
- **/linux/flutter/generated_plugin_registrant.h
- **/linux/flutter/generated_plugins.cmake
- **/windows/flutter/generated_plugin_registrant.cc
- **/windows/flutter/generated_plugin_registrant.h
- **/ios/Runner/GeneratedPluginRegistrant.h
- **/ios/Runner/GeneratedPluginRegistrant.m

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

7cab354d

Fix flutter_plugins by rolling revision (#129781) · 8b54878d

Christopher Fujino authored Jun 29, 2023

Fixes https://github.com/flutter/flutter/issues/129782

Linux flutter_plugins is currently broken
https://ci.chromium.org/p/flutter/builders/prod/Linux%20flutter_plugins/12884

On an analysis error that was ignored upstream in
https://github.com/flutter/packages/commit/5d6e48c3e099fa6c24f45b778f5b7cab82a7e1e8

8b54878d

Add locale-specific DateTime formatting syntax (#129573) · ff838bca

Tae Hyung Kim authored Jun 29, 2023

Based on the [message format
syntax](https://unicode-org.github.io/icu/userguide/format_parse/messages/#examples)
for
[ICU4J](https://unicode-org.github.io/icu-docs/apidoc/released/icu4j/com/ibm/icu/text/MessageFormat.html).
This adds new syntax to the current Flutter messageFormat parser which
should allow developers to add locale-specific date formatting.

## Usage example
```
  "datetimeTest": "Today is {today, date, ::yMd}",
  "@datetimeTest": {
    "placeholders": {
      "today": {
        "description": "The date placeholder",
        "type": "DateTime"
      }
    }
  }
```
compiles to
```
  String datetimeTest(DateTime today) {
    String _temp0 = intl.DateFormat.yMd(localeName).format(today);
    return 'Today is $_temp0';
  }
```

Fixes https://github.com/flutter/flutter/issues/127304.

ff838bca