Commits · a3257ca533205671c90b5c17c6b8cfc3bffce837 · abdullh.alsoleman / Front-End

10 May, 2023 7 commits

Roll Flutter Engine from 10ac36c52f08 to 406b3546a2ac (13 revisions) (#126468) · a3257ca5

engine-flutter-autoroll authored May 10, 2023

https://github.com/flutter/engine/compare/10ac36c52f08...406b3546a2ac

2023-05-10 mdebbar@google.com [web] Re-enable history tests on Safari
(flutter/engine#41901)
2023-05-10 flar@google.com switch from MockCanvas to DisplayListBuilder
in layer unit tests (flutter/engine#41889)
2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a3257ca5

Manual roll Flutter Engine from 10ac36c52f08 to 892f88d2513f (11 revisions) (#126455) · ce3b4f88

engine-flutter-autoroll authored May 10, 2023

Manual roll requested by aaclarke@google.com

Cannot build log URL because revision "892f88d2513f" is invalid: Luci
builds of "Linux Fuchsia FEMU" for
892f88d2513f4a60ebd6d1496c4ac272e53c55ba was STARTED

2023-05-10 zanderso@users.noreply.github.com Revert "Move linux fuchsia
engine v2 build to prod." (flutter/engine#41902)
2023-05-10 godofredoc@google.com Migrate mac host clang tidy to engine
v2. (flutter/engine#41824)
2023-05-10 jonahwilliams@google.com [Impeller] delete special handling
of RRect. (flutter/engine#41872)
2023-05-10 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
JiOACcaGrDphuHIql... to a3rrULFaXlwS8mfjW... (flutter/engine#41898)
2023-05-10 109111084+yaakovschectman@users.noreply.github.com Only
register top level window message listener upon registering service
binding (flutter/engine#41733)
2023-05-10 skia-flutter-autoroll@skia.org Roll Skia from 8c936fb9ba8e to
32f4cfc2460b (27 revisions) (flutter/engine#41891)
2023-05-10 yjbanov@google.com [web] dialog a11y fixes
(flutter/engine#41681)
2023-05-10 skia-flutter-autoroll@skia.org Roll Dart SDK from
2cf089614e1c to 7ad028c26344 (2 revisions) (flutter/engine#41882)
2023-05-10 jonahwilliams@google.com [Impeller] Increase minimum size of
alpha glyph atlas. (flutter/engine#41880)
2023-05-10 jonahwilliams@google.com [Impeller] Use separate atlases and
shaders for color and alpha (flutter/engine#41780)
2023-05-10 godofredoc@google.com Move linux fuchsia engine v2 build to
prod. (flutter/engine#41865)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from JiOACcaGrDph to a3rrULFaXlwS

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce3b4f88

tool/web: correctly log all options to web wasm compile (#126379) · 1b831a2c
Kevin Moore authored May 10, 2023
```
Filtering on 'true' omitted non-bool values
```
1b831a2c

Manual roll Flutter Engine from 78f41a8f2f06 to 10ac36c52f08 (6 revisions) (#126445) · 01ac99aa

engine-flutter-autoroll authored May 10, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/78f41a8f2f06...10ac36c52f08

2023-05-09 jacksongardner@google.com Implement text rendering in Skwasm
(flutter/engine#41832)
2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
leCRDVJ8szOS2LsPV... to lf8VcONMWlne4oa3H... (flutter/engine#41876)
2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller]
started cleaning up pools when devices are deleted
(flutter/engine#41857)
2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
c4JvQUEOBHgtRdNPc... to JiOACcaGrDphuHIql... (flutter/engine#41874)
2023-05-09 godofredoc@google.com Move linux_license to engine v2.
(flutter/engine#41863)
2023-05-09 godofredoc@google.com Replace Windows Unopt with the engine
v2 version. (flutter/engine#41861)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from leCRDVJ8szOS to lf8VcONMWlne
  fuchsia/sdk/core/mac-amd64 from c4JvQUEOBHgt to JiOACcaGrDph

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

01ac99aa

Manual roll Flutter Engine from 8ca16cba8c38 to 78f41a8f2f06 (2 revisions) (#126392) · a76dbe44

engine-flutter-autoroll authored May 10, 2023

Manual roll requested by zra@google.com

https://github.com/flutter/engine/compare/8ca16cba8c38...78f41a8f2f06

2023-05-09 skia-flutter-autoroll@skia.org Roll Dart SDK from
4b4c0325fd5b to 2cf089614e1c (3 revisions) (flutter/engine#41866)
2023-05-09 lhkbob@gmail.com Remove staging flag (flutter/engine#41843)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a76dbe44

Roll flutter/packages to 0167d834e937 (#126427) · df789c9e
stuartmorgan authored May 10, 2023
```
Manual package roll to fix tree.

Fixes https://github.com/flutter/flutter/issues/126393
```
df789c9e
Migrate gallery ios tests to build+test (#111164) · 8ab782d0
keyonghan authored May 10, 2023
```
Part of https://github.com/flutter/flutter/issues/103542
```
8ab782d0

09 May, 2023 9 commits

Roll Flutter Engine from 824cd09b8c62 to 8ca16cba8c38 (5 revisions) (#126360) · b269eb52

engine-flutter-autoroll authored May 09, 2023

https://github.com/flutter/engine/compare/824cd09b8c62...8ca16cba8c38

2023-05-09 jonahwilliams@google.com [Impeller] track path convexity and
use it to simplify fill tessellation. (flutter/engine#41834)
2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 9ba374e0b0f0 to
8c936fb9ba8e (7 revisions) (flutter/engine#41854)
2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 485cd3d0f9ca to
9ba374e0b0f0 (3 revisions) (flutter/engine#41849)
2023-05-09 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
oGF4h14qc40l5ANL3... to c4JvQUEOBHgtRdNPc... (flutter/engine#41848)
2023-05-09 skia-flutter-autoroll@skia.org Roll Dart SDK from
498cfa57165b to 4b4c0325fd5b (2 revisions) (flutter/engine#41847)

Also rolling transitive DEPS:
  fuchsia/sdk/core/mac-amd64 from oGF4h14qc40l to c4JvQUEOBHgt

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b269eb52

Revert "Provide default constraints for M3 dialogs" (#126355) · a153d6da
Kevin Chisholm authored May 09, 2023
```
Reverts flutter/flutter#120082

Causing breakages: b/281181985
```
a153d6da

Roll Packages from 4800d6512ebb to 1f917101d486 (8 revisions) (#126352) · ce579326

engine-flutter-autoroll authored May 09, 2023

https://github.com/flutter/packages/compare/4800d6512ebb...1f917101d486

2023-05-09 43054281+camsim99@users.noreply.github.com [camerax] Update README with plugin overview (flutter/packages#3891)
2023-05-09 jmccandless@google.com Fix nullability in docs (flutter/packages#3876)
2023-05-08 stuartmorgan@google.com [tools] Check version ranges when pathifying deps (flutter/packages#3943)
2023-05-08 stuartmorgan@google.com [quick_actions] Update minimum iOS version to 11 (flutter/packages#3946)
2023-05-08 stuartmorgan@google.com [shared_preferences] Update minimum iOS version to 11 (flutter/packages#3945)
2023-05-08 stuartmorgan@google.com [path_provider] Update minimum iOS version to 11 (flutter/packages#3944)
2023-05-08 34871572+gmackall@users.noreply.github.com Adding setup for TestInstanceManagerHostApi in zoom and exposure tests (flutter/packages#3947)
2023-05-08 engine-flutter-autoroll@skia.org Roll Flutter from 43ac23b4 to 4ed1c923 (16 revisions) (flutter/packages#3942)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ce579326

[github] Add labeler action (#126012) · bf88f605

Casey Hillers authored May 09, 2023

Part of https://github.com/flutter/flutter/issues/126002

Migrate the [Cocoon logic for labelling](https://cs.opensource.google/flutter/cocoon/+/main:app_dart/lib/src/request_handlers/github/webhook_subscription.dart;l=352) directly into the repo under test

bf88f605

Fix platformLocation path and search dropping (#126232) · cab29b20

Severin authored May 09, 2023

This PR fixes the dropping of both the `path` and `search` fields from the platform location in the URL when using Flutter Web and brings it in par with similar technologies (e.g. React Router).
It allows developers to keep the original path and/or search parameters in the URL, which are perfectly valid even while fragment routing is present.

**Example use case:**
Call a Flutter Web app with initial config parameters in the URL: 
`http://my-flutter.app/?skipIntro=true`

**Example:**
Before initial routing:
`http://localhost:45389/?foo=bar`
After routing:
`http://localhost:45389/#/menu`
After routing (with fix):
`http://localhost:45389/?foo=bar#menu`

Fixes #116415

cab29b20

Roll Flutter Engine from 8d3a8162b3ab to 824cd09b8c62 (10 revisions) (#126309) · 8a7ded7b

engine-flutter-autoroll authored May 09, 2023

https://github.com/flutter/engine/compare/8d3a8162b3ab...824cd09b8c62

2023-05-09 godofredoc@google.com Increase timeout of orchestrator. (flutter/engine#41839)
2023-05-09 ianloic@google.com [fuchsia] Stop calling FIDL from Dart in Flutter integration tests (flutter/engine#41669)
2023-05-09 wez@google.com [tests] Remove unused fuchsia.sys protocol reference (flutter/engine#41826)
2023-05-09 skia-flutter-autoroll@skia.org Roll Skia from 7736fbaf84f0 to 485cd3d0f9ca (6 revisions) (flutter/engine#41840)
2023-05-09 30870216+gaaclarke@users.noreply.github.com [Impeller] introduces DeviceHolder to avoid accessing a dead Device (flutter/engine#41748)
2023-05-08 jacksongardner@google.com Get rid of "outrageous" default text styles for HTML renderer. (flutter/engine#41822)
2023-05-08 flar@google.com Adjust DL filter bounds tests to not rely on exact Skia results (flutter/engine#41792)
2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from a8b6687327d6 to 498cfa57165b (1 revision) (flutter/engine#41823)
2023-05-08 JonathanPeterCole@gmail.com [Android] Fix incorrect viewInsets during keyboard animation with EdgeToEdge (flutter/engine#39391)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 951eb9653163 to 7736fbaf84f0 (1 revision) (flutter/engine#41821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8a7ded7b

Update FocusNode documentation (#126331) · a800edff

Bruno Leroux authored May 09, 2023

## Description

This PR adds some details in FocusNode documentation to explain more precisely when listeners are notified.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/126149

## Tests

Documentation only.

a800edff

Remove dead code (#126266) · 58454e9e

Michael Goderbauer authored May 09, 2023

Dead code was flagged by `unreachable_from_main` lint, which is still experimental and not ready to be enabled yet.

58454e9e

fix AppBar's docs for backgroundColor (#126194) · 5b87e4fb
Viren Khatri authored May 09, 2023

5b87e4fb

08 May, 2023 18 commits

tool/web: tiniest tweak to wasm help content (#126284) · 8c5a1ea7
Kevin Moore authored May 08, 2023
```
Missing "tick"
```
8c5a1ea7

Roll Flutter Engine from d9184ce4ffa0 to 8d3a8162b3ab (7 revisions) (#126288) · 8ceec452

engine-flutter-autoroll authored May 08, 2023

https://github.com/flutter/engine/compare/d9184ce4ffa0...8d3a8162b3ab

2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 30a368d502bf to 951eb9653163 (4 revisions) (flutter/engine#41820)
2023-05-08 jacksongardner@google.com Reland "Skwasm Font Loading (flutter/engine#41756)
2023-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from KZrdNPIOcs5m2MqV_... to oGF4h14qc40l5ANL3... (flutter/engine#41819)
2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from 855e2764c295 to a8b6687327d6 (1 revision) (flutter/engine#41817)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 64ba57381c94 to 30a368d502bf (1 revision) (flutter/engine#41816)
2023-05-08 godofredoc@google.com Add linux license engine v2 build. (flutter/engine#41797)
2023-05-08 godofredoc@google.com Windows unopt configuration. (flutter/engine#41785)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from KZrdNPIOcs5m to oGF4h14qc40l

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8ceec452

Fix that `flutter test` does not understand `concurrency` (#125942) · 2a9530f3

fzyzcjy authored May 08, 2023

Close https://github.com/flutter/flutter/issues/125940

I will add tests if this PR looks roughly OK :)

The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument.

p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.

2a9530f3

Fix that `flutter test` does not understand `concurrency` (#125942) · 742a1b49

fzyzcjy authored May 08, 2023

Close https://github.com/flutter/flutter/issues/125940

I will add tests if this PR looks roughly OK :)

The fix mainly mimics https://github.com/flutter/flutter/pull/115160 - just remove the default argument.

p.s. I ran into this bug when wanting to set concurrency in my dart_test.yaml for one set of my tests which I need to be executed without parallalization.

742a1b49

Improve the format in `asset_bundle.dart` (#126229) · 6b756ab5

Alex Li authored May 08, 2023

Just found these extra intents and the very long line which might be improved.

Related git blame: https://github.com/flutter/flutter/blame/master/packages/flutter/lib/src/services/asset_bundle.dart#L337.

6b756ab5

Tiny cleanup for Navigator code (without introducing dependency) (#125628) · 431dfc83

fzyzcjy authored May 08, 2023

Close https://github.com/flutter/flutter/issues/125724

> The `navigator.dart` has ~10 repeats of things like:
> 
> ```dart
>     final _RouteEntry? currentRouteEntry = _navigator!._history.cast<_RouteEntry?>().lastWhere(
>       (_RouteEntry? e) => e != null && _RouteEntry.isPresentPredicate(e),
>       orElse: () => null,
>     );
> ```
> 
> while it can be greatly simplified as:
> 
> ```dart
>     final _RouteEntry? currentRouteEntry = _navigator!._history.lastWhereOrNull(_RouteEntry.isPresentPredicate);
> ```
> 
> Thus, it seems that we can beautify the code a little bit.

Same as https://github.com/flutter/flutter/pull/125099, but without external dependency

For more detailed explanation why it does not introduce external dependency: https://github.com/flutter/flutter/pull/125099#discussion_r1174230502

431dfc83

[Refactor] Fix style in example (#126191) · e11a2213

Yu authored May 08, 2023

Replaces #125616

I just fixed "IMAGES" to "images" in examples/image_list.
Currently, "PREFER uses the lower case of the constant name ".

e11a2213

Roll Flutter Engine from a8e9ac63fd95 to d9184ce4ffa0 (2 revisions) (#126279) · bbe6ed2d

engine-flutter-autoroll authored May 08, 2023

https://github.com/flutter/engine/compare/a8e9ac63fd95...d9184ce4ffa0

2023-05-08 godofredoc@google.com Linux fuchsia engine v2 config. (flutter/engine#41759)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 5f7e572995b1 to 64ba57381c94 (1 revision) (flutter/engine#41814)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bbe6ed2d

[Tool] Output help on 'flutter pub' (#126211) · 472a0ab3

Loïc Sharma authored May 08, 2023

This change makes `flutter pub` show the help usage:

```
PS > flutter pub
Commands for managing Flutter packages.

Global options:
-h, --help                  Print this usage information.
-v, --verbose               Noisy logging, including all shell commands executed.
                            If used with "--help", shows hidden options. If used with "flutter
                            doctor", shows additional diagnostic information. (Use "-vv" to force
                            verbose logging in those cases.)
-d, --device-id             Target device id or name (prefixes allowed).
    --version               Reports the version of this tool.
    --suppress-analytics    Suppress analytics reporting for the current CLI invocation.
    --disable-telemetry     Disable telemetry reporting when this command runs.

Usage: flutter pub <subcommand> [arguments]
-h, --help    Print this usage information.

Available subcommands:
  add         Add a dependency to pubspec.yaml.
  cache       Work with the Pub system cache.
  deps        Print package dependencies.
  downgrade   Downgrade packages in a Flutter project.
  get         Get the current package's dependencies.
  global      Work with Pub global packages.
  login       Log into pub.dev.
  logout      Log out of pub.dev.
  outdated    Analyze dependencies to find which ones can be upgraded.
  pub         Pass the remaining arguments to Dart's "pub" tool.
  publish     Publish the current package to pub.dartlang.org.
  remove      Removes a dependency from the current package.
  run         Run an executable from a package.
  test        Run the "test" package.
  token       Manage authentication tokens for hosted pub repositories.
  upgrade     Upgrade the current package's dependencies to latest versions.
  uploader    Manage uploaders for a package on pub.dev.
  version     Print Pub version.

Run "flutter help" to see global options.
```

Previously it showed an error message:

```
PS > flutter pub
Missing subcommand for "flutter pub".

Run 'flutter -h' (or 'flutter <command> -h') for available flutter commands and options.
```

Addresses https://github.com/flutter/flutter/issues/110025

472a0ab3

Always use `--concurrency=1` for web tests. (#126179) · 4439fd41

Jackson Gardner authored May 08, 2023

This should fix https://github.com/flutter/flutter/issues/126178

When we don't pass a `--concurrency` flag to the test package, it uses a default based on the number of cores that are on the machine. However, the web test platform itself serializes all these requests anyway, which can lead to the test package timing out. This is because from the test package's perspective, it has already started the loading process on a number of suites which are simply waiting for other test suites to compile and run. The ones that wait the longest can run up against the test packages 12 minute timeout for loading a given suite, even though they haven't actually started to try to load.

Instead, we should always pass `--concurrency=1` to the test package so that it doesn't attempt to start loads concurrently in the first place.

4439fd41

Add `--verbose` flags for flakey tests (#126162) · 38cac910

Elias Yishak authored May 08, 2023

Related to:
- https://github.com/flutter/flutter/issues/125512

Adding verbose flags to get printed out on error to help debug the cause of the flakey test

38cac910

Roll Packages from a0f8fd89af1a to 4800d6512ebb (2 revisions) (#126269) · c6f61ef3

engine-flutter-autoroll authored May 08, 2023

https://github.com/flutter/packages/compare/a0f8fd89af1a...4800d6512ebb

2023-05-08 102626803+drewroengoogle@users.noreply.github.com Update .cirrus.yml (flutter/packages#3916)
2023-05-06 engine-flutter-autoroll@skia.org Manual roll Flutter from 0b657236 to 43ac23b4 (30 revisions) (flutter/packages#3922)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c6f61ef3

Test AGP 8.0 using java 17 (#125323) · 0fdddd67

Reid Baker authored May 08, 2023

- Update Gradle/AGP version and add namespace plus dependencies. 

https://github.com/flutter/flutter/issues/125181

0fdddd67

Roll Flutter Engine from c42dd23e29f6 to a8e9ac63fd95 (1 revision) (#126265) · 4ed1c923

engine-flutter-autoroll authored May 08, 2023

https://github.com/flutter/engine/compare/c42dd23e29f6...a8e9ac63fd95

2023-05-08 skia-flutter-autoroll@skia.org Roll Dart SDK from ab64c4a56e2c to 855e2764c295 (1 revision) (flutter/engine#41813)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ed1c923

Clearer text about what happens with `--disable-telemetry` + enable-telemetry command (#125995) · 0d587527

Elias Yishak authored May 08, 2023

Fixes:
- https://github.com/flutter/flutter/issues/124411

This PR is cleaning up the `--disable-telemetry` help message to make it clear that opting out will opt out of all telemetry collection for flutter and dart commands. It is also adding the opposite flag `--enable-telemetry` which will enable telemetry collection

0d587527

Roll Flutter Engine from 23f730efbff7 to c42dd23e29f6 (13 revisions) (#126262) · 6db4162a

engine-flutter-autoroll authored May 08, 2023

https://github.com/flutter/engine/compare/23f730efbff7...c42dd23e29f6

2023-05-08 goderbauer@google.com Fix doc to fix engine roll (flutter/engine#41812)
2023-05-08 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.3.2 to 2.3.3 (flutter/engine#41811)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 802eb7f66fc5 to 5f7e572995b1 (1 revision) (flutter/engine#41809)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from f9bef8f7bdb5 to 802eb7f66fc5 (1 revision) (flutter/engine#41807)
2023-05-08 skia-flutter-autoroll@skia.org Roll Skia from 148ebc0596b7 to f9bef8f7bdb5 (1 revision) (flutter/engine#41806)
2023-05-08 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from VD0zJZ-ezOAfA9O1s... to KZrdNPIOcs5m2MqV_... (flutter/engine#41805)
2023-05-07 skia-flutter-autoroll@skia.org Roll Skia from 642ba306e140 to 148ebc0596b7 (1 revision) (flutter/engine#41804)
2023-05-07 skia-flutter-autoroll@skia.org Roll Skia from 8a93b289c2ed to 642ba306e140 (1 revision) (flutter/engine#41802)
2023-05-07 skia-flutter-autoroll@skia.org Roll ICU from d8daa943f64c to a2961dc659b4 (2 revisions) (flutter/engine#41801)
2023-05-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from k4NzlntuagXZIlCJg... to VD0zJZ-ezOAfA9O1s... (flutter/engine#41800)
2023-05-07 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from FFOWihz4lzOeDHmNj... to k4NzlntuagXZIlCJg... (flutter/engine#41799)
2023-05-06 skia-flutter-autoroll@skia.org Roll Dart SDK from d04e8b571819 to ab64c4a56e2c (1 revision) (flutter/engine#41798)
2023-05-06 dnfield@google.com Add a `Display` API to dart:ui that reports the physical size, DPR, and refresh rate of the main display (flutter/engine#41685)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from FFOWihz4lzOe to KZrdNPIOcs5m

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6db4162a

Fix leaks (#126144) · 9b230d23

Michael Goderbauer authored May 08, 2023

Fixes https://github.com/flutter/flutter/issues/126096.
Fixes https://github.com/flutter/flutter/issues/126097.
Fixes https://github.com/flutter/flutter/issues/126102.
Fixes https://github.com/flutter/flutter/issues/126098.
Fixes https://github.com/flutter/flutter/issues/126147.
Work towards https://github.com/flutter/flutter/issues/126100.

Does not fix the OverlyEntry/ModalRoute leak (https://github.com/flutter/flutter/issues/126100).

9b230d23

Update packages (#126140) · 65dfb555
Pierre-Louis authored May 08, 2023
```
In particular, update pin for `material_color_utilities` to `0.5.0`.
```
65dfb555

06 May, 2023 6 commits

[ExpansionPanelList] add materialGapSize property in ExpansionPanelList Widget (#123971) · 835b892d

Tirth authored May 06, 2023

Adds `materialGapSize` property to `ExpansionPanelList` widget.

| `materialGapSize: 0` | `materialGapSize: 16` (default) | `materialGapSize: 30` |
| --- | --- | --- |
| ![screenshot_1680450783](https://user-images.githubusercontent.com/13456345/229366131-8dd105cd-6371-4852-b57b-5900e3dbd203.png) | ![screenshot_1680453525](https://user-images.githubusercontent.com/13456345/229366640-e2ae5f95-0cd6-4694-b8ff-0de7fb7c8554.png) | ![screenshot_1680450910](https://user-images.githubusercontent.com/13456345/229366742-3121331b-b22e-46a1-bdfa-20b5663cbe2b.png) |
| ![screenshot_1680450785](https://user-images.githubusercontent.com/13456345/229366133-bf345914-9d74-4dcc-afc4-a6a9ccca13ab.png) | ![screenshot_1680453527](https://user-images.githubusercontent.com/13456345/229366644-bfff8e4f-8a66-4419-90b8-6a16442b7157.png) | ![screenshot_1680450912](https://user-images.githubusercontent.com/13456345/229366745-364b1a1e-ed2c-4463-a74d-d8e94bf509b9.png) |
| ![screenshot_1680450787](https://user-images.githubusercontent.com/13456345/229366138-3f6280f0-e58a-4621-aced-c7eee2077ef8.png) | ![screenshot_1680453530](https://user-images.githubusercontent.com/13456345/229366648-3805db23-29b0-46a3-82ce-92688e65f0fd.png) | ![screenshot_1680450914](https://user-images.githubusercontent.com/13456345/229366747-73d46f9c-3edc-4197-8f02-651ff8499323.png) |
| ![screenshot_1680450789](https://user-images.githubusercontent.com/13456345/229366140-4ff8572c-8d06-4985-a697-3af0ce0e5743.png) | ![screenshot_1680453532](https://user-images.githubusercontent.com/13456345/229366651-88af37ac-7503-4abc-b6a6-d8556a583871.png) | ![screenshot_1680450916](https://user-images.githubusercontent.com/13456345/229366749-0db156b0-6b53-4ef2-9699-0d3e8704433b.png) |

Fixes: #118167

835b892d

Roll Flutter Engine from eedcee66a710 to 23f730efbff7 (1 revision) (#126199) · 61cdb08a

engine-flutter-autoroll authored May 06, 2023

https://github.com/flutter/engine/compare/eedcee66a710...23f730efbff7

2023-05-06 skia-flutter-autoroll@skia.org Roll Skia from e7de10e25736 to 8a93b289c2ed (1 revision) (flutter/engine#41796)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61cdb08a

Roll Flutter Engine from 393b5649e7b4 to eedcee66a710 (1 revision) (#126198) · 4ca3cafd

engine-flutter-autoroll authored May 06, 2023

https://github.com/flutter/engine/compare/393b5649e7b4...eedcee66a710

2023-05-06 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from S3gPFEsS1wP40ivwV... to FFOWihz4lzOeDHmNj... (flutter/engine#41795)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from S3gPFEsS1wP4 to FFOWihz4lzOe

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4ca3cafd

Roll Flutter Engine from 876968833e46 to 393b5649e7b4 (1 revision) (#126195) · 43fa2c01

engine-flutter-autoroll authored May 06, 2023

https://github.com/flutter/engine/compare/876968833e46...393b5649e7b4

2023-05-06 skia-flutter-autoroll@skia.org Roll Dart SDK from 8695bed2bc58 to d04e8b571819 (1 revision) (flutter/engine#41793)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

43fa2c01

[ios] fix hold and drag spacebar does not move cursor when obscureTex… (#122383) · 7c356d04
林洵锋 authored May 06, 2023
```
Fixes #122139 with engine pr [flutter/engine#40216](https://github.com/flutter/engine/pull/40216)
```
7c356d04

Roll Flutter Engine from d9116d94a111 to 876968833e46 (1 revision) (#126192) · 3bf4acb0

engine-flutter-autoroll authored May 06, 2023

https://github.com/flutter/engine/compare/d9116d94a111...876968833e46

2023-05-06 skia-flutter-autoroll@skia.org Roll Skia from 2e622658996c to e7de10e25736 (1 revision) (flutter/engine#41791)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3bf4acb0