Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
1b831a2c
Unverified
Commit
1b831a2c
authored
May 10, 2023
by
Kevin Moore
Committed by
GitHub
May 10, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
tool/web: correctly log all options to web wasm compile (#126379)
Filtering on 'true' omitted non-bool values
parent
01ac99aa
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
16 additions
and
9 deletions
+16
-9
compiler_config.dart
packages/flutter_tools/lib/src/web/compiler_config.dart
+1
-5
compile_web_test.dart
...lutter_tools/test/general.shard/web/compile_web_test.dart
+15
-4
No files found.
packages/flutter_tools/lib/src/web/compiler_config.dart
View file @
1b831a2c
...
...
@@ -179,11 +179,7 @@ class WasmCompilerConfig extends WebCompilerConfig {
@override
Map
<
String
,
Object
>
get
buildEventAnalyticsValues
=>
<
String
,
Object
>{
...
super
.
buildEventAnalyticsValues
,
for
(
MapEntry
<
String
,
String
>
entry
in
toBuildSystemEnvironment
()
.
entries
.
where
(
(
MapEntry
<
String
,
String
>
element
)
=>
element
.
value
==
'true'
))
entry
.
key
:
entry
.
value
,
...
toBuildSystemEnvironment
(),
};
}
...
...
packages/flutter_tools/test/general.shard/web/compile_web_test.dart
View file @
1b831a2c
...
...
@@ -80,17 +80,28 @@ void main() {
expect
(
logger
.
statusText
,
contains
(
'Compiling target for the Web...'
));
expect
(
logger
.
errorText
,
isEmpty
);
// Runs ScrubGeneratedPluginRegistrant migrator.
expect
(
logger
.
traceText
,
contains
(
'generated_plugin_registrant.dart not found. Skipping.'
));
expect
(
logger
.
traceText
,
contains
(
'generated_plugin_registrant.dart not found. Skipping.'
),
);
// Sends build config event
expect
(
testUsage
.
events
,
unorderedEquals
(<
TestUsageEvent
>[
expect
(
testUsage
.
events
,
unorderedEquals
(
<
TestUsageEvent
>[
const
TestUsageEvent
(
'build'
,
'web'
,
label:
'web-compile'
,
parameters:
CustomDimensions
(
buildEventSettings:
'wasm-compile: true; web-renderer: auto;'
)
parameters:
CustomDimensions
(
buildEventSettings:
'RunWasmOpt: none; WasmOmitTypeChecks: false; wasm-compile: true; web-renderer: auto;'
,
),
),
],
),
])
);
);
// Sends timing event.
final
TestTimingEvent
timingEvent
=
testUsage
.
timings
.
single
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment