Unverified Commit 1b831a2c authored by Kevin Moore's avatar Kevin Moore Committed by GitHub

tool/web: correctly log all options to web wasm compile (#126379)

Filtering on 'true' omitted non-bool values
parent 01ac99aa
......@@ -179,11 +179,7 @@ class WasmCompilerConfig extends WebCompilerConfig {
@override
Map<String, Object> get buildEventAnalyticsValues => <String, Object>{
...super.buildEventAnalyticsValues,
for (MapEntry<String, String> entry in toBuildSystemEnvironment()
.entries
.where(
(MapEntry<String, String> element) => element.value == 'true'))
entry.key: entry.value,
...toBuildSystemEnvironment(),
};
}
......
......@@ -80,17 +80,28 @@ void main() {
expect(logger.statusText, contains('Compiling target for the Web...'));
expect(logger.errorText, isEmpty);
// Runs ScrubGeneratedPluginRegistrant migrator.
expect(logger.traceText, contains('generated_plugin_registrant.dart not found. Skipping.'));
expect(
logger.traceText,
contains('generated_plugin_registrant.dart not found. Skipping.'),
);
// Sends build config event
expect(testUsage.events, unorderedEquals(<TestUsageEvent>[
expect(
testUsage.events,
unorderedEquals(
<TestUsageEvent>[
const TestUsageEvent(
'build',
'web',
label: 'web-compile',
parameters: CustomDimensions(buildEventSettings: 'wasm-compile: true; web-renderer: auto;')
parameters: CustomDimensions(
buildEventSettings:
'RunWasmOpt: none; WasmOmitTypeChecks: false; wasm-compile: true; web-renderer: auto;',
),
),
],
),
]));
);
// Sends timing event.
final TestTimingEvent timingEvent = testUsage.timings.single;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment