1. 03 Jul, 2018 2 commits
    • Danny Tuppeny's avatar
      Fix type for Dart 2 (#18998) · 9cb3cd4c
      Danny Tuppeny authored
      Fixes #18995.
      9cb3cd4c
    • Greg Price's avatar
      Round properly to nearest page in TabBarView. (#16868) · 84f5b1cb
      Greg Price authored
      This logic is described in the test as looking for a scroll ending
      very close to a new page, but in fact its behavior is more like
      "very close to a page to the right": if we're not very, very close
      to any page, it will pick the page to the left, not an old page.
      
      There's no reason this should be left-right asymmetrical.
      Instead, pick the nearest page.
      
      In practice, the case where this makes a difference never arises when
      the scroll runs undisturbed to completion; but when the user taps on
      the page to hold or drag, the scroll will be interrupted before it
      gets within tolerance of a particular page, and this case does arise.
      
      This fixes a glitch that is hard to trigger without time dilation,
      but is quite conspicuous with it:
      
       * Open a tab view with at least 4 tabs, e.g. the Buttons screen
         of the gallery (with "Animate Slowly" on.)
       * Starting at tab 0, tap tab 2.
       * When the animation is nearly complete, tap the page a couple
         of times, as if to drag it around to scroll.  Then let the
         page view settle ballistically toward page 2.
       * Before it finishes, tap tab 3.
       * Suddenly page 1 fills the view, replacing page 2, before we
         scroll from there to page 3.
      
      With this fix, the animation in the last step moves smoothly from
      where we are when it starts onward to page 3.
      84f5b1cb
  2. 02 Jul, 2018 7 commits
  3. 01 Jul, 2018 1 commit
  4. 29 Jun, 2018 6 commits
  5. 28 Jun, 2018 17 commits
  6. 27 Jun, 2018 7 commits
    • Ian Hickson's avatar
      Remove race conditions involving finding available ports (#18698) · 35ad2a78
      Ian Hickson authored
      This is an attempt to reland #18488 with less breakage on macOS.
      35ad2a78
    • Alexander Aprelev's avatar
      Fix library-scope expression evaluation. (#18851) · ed2376a7
      Alexander Aprelev authored
      This also improves diagnostic in case of internal compiler errors.
      ed2376a7
    • Danny Tuppeny's avatar
      Mark flutter_gallery_instrumentation_test as flaky (#18887) · e87b83bf
      Danny Tuppeny authored
      See #18879.
      e87b83bf
    • Danny Tuppeny's avatar
      cfd26d32
    • Danny Tuppeny's avatar
    • Danny Tuppeny's avatar
      Improve update checking (#18193) · e616c6ce
      Danny Tuppeny authored
      * Improve update checking
      
      This change emables pinging the server to check for updates regardless of whether the local version is "out of date". The server code already has a 7-day cache so the result is that we can now ping the server once every 7 days instead of waiting for the local install to be 4 weeks out of date before pinging.
      
      The original 4 week period is still used for when we'll start warning the user they're out of date if we could not confirm with the server whether there's a new version.
      
      * Improve message when we know there's a new version available
      
      * Fix bnullable bool checks
      
      * Switch nullable bool to enum
      
      * Fix casing of enum values
      
      * Remove stale comment
      
      The names are now descriptive so doesn't need additional explanation.
      
      * Improve name of function
      
      * Remove note:
      
      * Rename kPauseToLetUserReadTheMessage -> timeToPauseToLetUserReadTheMessage
      
      * Change kVersionAgeConsideredUpToDate to 5 weeks from 4
      
      * Inline the isNewerFrameworkVersionAvailable check
      
      * Fix indenting (?)
      
      * Fix more indenting
      
      * Rename function to be clearer it's getting the commit date
      
      * Formating tweaks
      
      * Update stamp when connection failed, and reduce time before we'll try again
      
      Previously we would hit the server on every command if we thought we might be out of date and we never successfully connected (eg. if you're offline). This makes the stamp update even when there's a conneciton failure so that this won't happen, but reduces the time till we check again from 7 days to 3 days to compensate a little in case it was a one-off.
      
      https://github.com/flutter/flutter/pull/18193#issuecomment-399222269
      
      * Fix comment
      
      * Don't perform update checks if not on an official channel
      e616c6ce
    • Danny Tuppeny's avatar
      Mark flutter-tester-runs-forever test as skip (#18867) · 0fb20972
      Danny Tuppeny authored
      This test is failing on mac_bot (but passing elsewhere) because flutter-tester is apparently quitting earlier than expected. Locally it fails with an even weirder error and almost all tests are failing with "Compilation failed" (this isn't happening on the builds, so something is bad on my MacBook). Marking as skip to fix build while investigating; there's no real impact of this test not running; it's testing a tool that its itself used for testing (and not currently in any way that should be affected by this failure).
      0fb20972