Commits · 9160c6e7f1125c0ff4584c47770a0a6192591fde · abdullh.alsoleman / Front-End

03 May, 2023 11 commits

Adding printOnFailure for result of process (#125910) · 9160c6e7

Elias Yishak authored May 03, 2023

Adding a `printOnFailure` call into the flakey test to help debug the cause for future failures.

- Reference issue: https://github.com/flutter/flutter/issues/125512

9160c6e7

Roll Flutter Engine from bc8f14001d7a to b71728bee873 (1 revision) (#125972) · c4d6c8c6

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/bc8f14001d7a...b71728bee873

2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 4d084f5b8f91 to 342dff83c38e (2 revisions) (flutter/engine#41692)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c4d6c8c6

Roll Flutter Engine from 99e5184c7aa8 to bc8f14001d7a (2 revisions) (#125969) · c4ad07dc

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/99e5184c7aa8...bc8f14001d7a

2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from ubfKertFqqUj0WD8I... to WAfNudyWPOGyWSpZD... (flutter/engine#41691)
2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from b58340991480 to 887e58fff02f (2 revisions) (flutter/engine#41690)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from ubfKertFqqUj to WAfNudyWPOGy

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c4ad07dc

Roll Flutter Engine from 0407a16a9b5e to 99e5184c7aa8 (3 revisions) (#125954) · bea17cc9

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/0407a16a9b5e...99e5184c7aa8

2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 3c1ecab42cd4 to b58340991480 (1 revision) (flutter/engine#41689)
2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 7781dda8104f to 3c1ecab42cd4 (2 revisions) (flutter/engine#41688)
2023-05-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 7c061d8c9dc0 to 4d084f5b8f91 (1 revision) (flutter/engine#41686)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bea17cc9

`ModalBarrier`'s gesture recognizer does not call `invokeCallback` (#125386) · 4d38f94e

fzyzcjy authored May 03, 2023

Close #125385 - please see explanations there :)

If you think this PR looks OK, I will polish it (e.g. copy-and-paste-and-modify the tests shown in #125385 into here and make CI pass)

4d38f94e

Roll Flutter Engine from 228da31894f7 to 0407a16a9b5e (1 revision) (#125941) · 110fe75b

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/228da31894f7...0407a16a9b5e

2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 54c32e41eced to 7781dda8104f (1 revision) (flutter/engine#41684)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

110fe75b

Allow .xcworkspace and .xcodeproj to be renamed from default name 'Runner' (#124533) · c9b132d0

LouiseHsu authored May 03, 2023

Adds the ability to rename Runner.xcodeproj and Runner.xcworkspace - fixes https://github.com/flutter/flutter/issues/9767.

To rename a project:
1. Open Runner.xcodeproj in Xcode
2. In the left panel, left click "Show File Inspector" 
<img width="441" alt="Screenshot 2023-04-17 at 11 41 07 PM" src="https://user-images.githubusercontent.com/36148254/232692957-8743742d-c3ef-42e5-833f-dff31aeb2b6a.png">
3. In the right panel, the name of the project, "Runner", should be visible under "Identity and Type". Change the name and press enter.
<img width="299" alt="Screenshot 2023-04-17 at 11 40 43 PM" src="https://user-images.githubusercontent.com/36148254/232693315-b6a71165-f5e3-4a0f-8954-2f3eee5b67cf.png">
4. A wizard should pop up. Click Rename.
<img width="573" alt="Screenshot 2023-04-17 at 11 44 01 PM" src="https://user-images.githubusercontent.com/36148254/232693381-bb9cf026-2a75-4844-b42d-ae0036ae9fdd.png">
To rename the workspace:

1. Make sure Xcode is closed.
2. Rename the .xcworkspace to your new name.

If you also renamed the project

&nbsp; 3. Reopen the .xcworkspace in Xcode. If the selected project is the old name and in red, update it to match the new project name.

Tests for schemeFor were changed as with Xcode 14, in some cases the scheme will be renamed along with the project. Thus we will get the best match scheme for either the project name, or the default name Runner. However if a flavor is present, the scheme should always match the flavor.

c9b132d0

Report total_ui_gc_time to SkiaPerf (#125919) · aef7929f
Zachary Anderson authored May 03, 2023
```
Not sure why this wasn't already being reported.
```
aef7929f

Roll Flutter Engine from fb3002443fcc to 228da31894f7 (1 revision) (#125936) · 707261fa

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/fb3002443fcc...228da31894f7

2023-05-03 skia-flutter-autoroll@skia.org Roll Skia from 089b9cca26fe to 54c32e41eced (3 revisions) (flutter/engine#41683)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

707261fa

Roll Flutter Engine from 7e77d838df3a to fb3002443fcc (3 revisions) (#125934) · b2e01939

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/7e77d838df3a...fb3002443fcc

2023-05-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from g_6rn9e-GBQGQGwgt... to 9T4mGpfsJZO0KPtfp... (flutter/engine#41679)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from ea1fce8e0aa7 to 7c061d8c9dc0 (1 revision) (flutter/engine#41677)
2023-05-02 ianloic@google.com [fuchsia] fix run_integration_test.sh (flutter/engine#41668)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from g_6rn9e-GBQG to 9T4mGpfsJZO0

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b2e01939

Roll Flutter Engine from c4a2712e8f4d to 7e77d838df3a (2 revisions) (#125925) · 0a77373f

engine-flutter-autoroll authored May 03, 2023

https://github.com/flutter/engine/compare/c4a2712e8f4d...7e77d838df3a

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from 644e199b6832 to 089b9cca26fe (14 revisions) (flutter/engine#41675)
2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from moQlKaNgpc0WD3sjC... to ubfKertFqqUj0WD8I... (flutter/engine#41674)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from moQlKaNgpc0W to ubfKertFqqUj

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

0a77373f

02 May, 2023 23 commits

Roll Flutter Engine from cd989fbc80bf to c4a2712e8f4d (3 revisions) (#125909) · 68cf636d

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/cd989fbc80bf...c4a2712e8f4d

2023-05-02 leroux_bruno@yahoo.fr Web - Fix selection jump on Chrome for Android (flutter/engine#41202)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 84f3080c3165 to ea1fce8e0aa7 (1 revision) (flutter/engine#41672)
2023-05-02 magder@google.com Stop specifiying Macmini8,1 in ci builders, use inherited mac_model dimension (flutter/engine#41223)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

68cf636d

Update xcode to 14e222b (#125716) · 9fcb42d0
Chris Yang authored May 02, 2023
```
Framework part of https://github.com/flutter/flutter/issues/125814
```
9fcb42d0

Clarify Visual Studio isn't strictly necessary for Windows development (#125837) · f94112e5

Loïc Sharma authored May 02, 2023

Update `flutter doctor` to clarify that Visual Studio is needed only if creating Windows apps. Windows users targeting Android do not need to install Visual Studio.

f94112e5

Mark microbenchmarks_ios unflaky (#125332) · cc9a3d9d
Jenn Magder authored May 02, 2023
```
This hasn't flaked for > 50 commits which is our threshhold.  Marking as unflaky.
```
cc9a3d9d

Roll Flutter Engine from 6fe3f5079792 to cd989fbc80bf (1 revision) (#125894) · c5183601

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/6fe3f5079792...cd989fbc80bf

2023-05-02 godofredoc@google.com Migrate Linux Android AOT Engine to engine V2. (flutter/engine#41638)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c5183601

Mark build_test builds as bringup. (#125898) · d0069bec

godofredoc authored May 02, 2023

They require an additional dimension to be passed as part of the
.ci.yaml configuration.

Bug: https://github.com/flutter/flutter/issues/125897

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

d0069bec

Align the Popup Menu under its child (#125534) · 00cd3eda

Valentin Vignal authored May 02, 2023

Align the `PopupMenu` under its child.

Before:

![image](https://user-images.githubusercontent.com/32538273/234468262-beddb257-5f5a-422f-a678-c26efc52dc07.png)

After:

![image](https://user-images.githubusercontent.com/32538273/234468233-3ea4d741-b04c-4012-bdd7-a36ecedc029c.png)

*List which issues are fixed by this PR. You must list at least one issue.*

Fixes https://github.com/flutter/flutter/issues/125474

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

00cd3eda

Roll Flutter Engine from 53c192f41f96 to 6fe3f5079792 (2 revisions) (#125888) · 25bbe5c5

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/53c192f41f96...6fe3f5079792

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from c574ba686a93 to 644e199b6832 (1 revision) (flutter/engine#41666)
2023-05-02 jason-simmons@users.noreply.github.com Clone the parent Android engine's asset provider into a spawned engine (flutter/engine#41642)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

25bbe5c5

Clean up in memory_allocations_test.dart. (#125777) · 209865ae
Polina Cherkasova authored May 02, 2023

209865ae

[framework] delete physical model layer. (#125719) · 12b3023e

Jonah Williams authored May 02, 2023

Engine PR: https://github.com/flutter/engine/pull/41593

This must land first

We should remove these, as they've been deprecated for a while. On the engine side of things, the physical model layer is the only one which requires the device pixel ratio, so deleting it will allow us to simplify the layer tree code in https://github.com/flutter/engine/pull/41559

12b3023e

Roll Packages from de6131dbe4f7 to f163786731b8 (6 revisions) (#125884) · e51b6167

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/packages/compare/de6131dbe4f7...f163786731b8

2023-05-01 43054281+camsim99@users.noreply.github.com [camerax] Retrieve exposure and zoom camera information (flutter/packages#3798)
2023-05-01 engine-flutter-autoroll@skia.org Manual roll Flutter from 66fa4c5d to 828a0404 (79 revisions) (flutter/packages#3874)
2023-05-01 vashworth@google.com [video_player, google_sign_in] Updates functions without a prototype to avoid deprecation warning (flutter/packages#3873)
2023-05-01 reidbaker@google.com [various] Speed up build-examples (flutter/packages#3849)
2023-05-01 stuartmorgan@google.com [file_selector] Remove uses of `macUTIs` (flutter/packages#3859)
2023-05-01 stuartmorgan@google.com [file_selector] Add getDirectoryPaths implementation for macOS (flutter/packages#3703)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e51b6167

Add debugPrintKeyboardEvents flag (#125629) · e435b1ae

Bruno Leroux authored May 02, 2023

## Description

This PR adds a new debug flag named `debugPrintKeyboardEvents` to help debugging keyboard issues.

Keyboard code has some useful asserts but sometimes an assertion failure is related to the handling of previous key events. This debug flag will help understanding the flow of key events which leads to an assertion failure.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/125627

## Tests

Adds 1 test.

e435b1ae

Roll Flutter Engine from 44376e8cd3de to 53c192f41f96 (2 revisions) (#125880) · 794c2e0a

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/44376e8cd3de...53c192f41f96

2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 0c4f93a82e0b to 84f3080c3165 (1 revision) (flutter/engine#41665)
2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from e71bd40af2bb to c574ba686a93 (1 revision) (flutter/engine#41664)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

794c2e0a

Roll Flutter Engine from 46d5ce4784b8 to 44376e8cd3de (1 revision) (#125876) · db6074ad

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/46d5ce4784b8...44376e8cd3de

2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ur2ymZJCZSj64s6Q2... to g_6rn9e-GBQGQGwgt... (flutter/engine#41663)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from ur2ymZJCZSj6 to g_6rn9e-GBQG

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

db6074ad

Roll Flutter Engine from a687d62ff631 to 46d5ce4784b8 (1 revision) (#125874) · 61c8291f

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/a687d62ff631...46d5ce4784b8

2023-05-02 zhongwuzw@qq.com [macOS] Add lookupKeyForAsset to FlutterPluginRegistrar (flutter/engine#37421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

61c8291f

Roll Flutter Engine from d0ed35b7bf67 to a687d62ff631 (1 revision) (#125871) · 005ad93d

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/d0ed35b7bf67...a687d62ff631

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from d2c85cb8aa2f to e71bd40af2bb (1 revision) (flutter/engine#41662)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

005ad93d

Roll Flutter Engine from c0d68c36c376 to d0ed35b7bf67 (1 revision) (#125870) · d82e6974

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/c0d68c36c376...d0ed35b7bf67

2023-05-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from u7iIoiSX4y8WV6Of1... to moQlKaNgpc0WD3sjC... (flutter/engine#41661)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from u7iIoiSX4y8W to moQlKaNgpc0W

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d82e6974

Roll Flutter Engine from a9e38dd0510d to c0d68c36c376 (1 revision) (#125868) · 55061e46

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/a9e38dd0510d...c0d68c36c376

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from e18b7415188c to d2c85cb8aa2f (2 revisions) (flutter/engine#41660)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

55061e46

Roll Flutter Engine from 024bf946232d to a9e38dd0510d (2 revisions) (#125866) · 59653136

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/024bf946232d...a9e38dd0510d

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from c9e0992be00b to e18b7415188c (1 revision) (flutter/engine#41659)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 25c29435f73e to 0c4f93a82e0b (2 revisions) (flutter/engine#41657)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

59653136

Make `future` and `stream` required arguments in their respective builder widgets (#125838) · 4d86f5d0

Casey Rogers authored May 02, 2023

cc'ing existing conversation participants: @domesticmouse @srawlins
cc'ing to request review: @goderbauer

This PR makes the following constructor arguments required:
1. `FutureBuilder.future`
2. `StreamBuilderBase.stream`
3. `StreamBuilder.stream`

This fixes:
https://github.com/flutter/flutter/issues/83081
https://github.com/flutter/flutter/issues/125188 (dupe of 83081)

This obviates:
https://github.com/dart-lang/linter/issues/4309
(I suggest we skip straight to merging this PR as this should be a low impact breaking change-assuming few to no devs are intentionally using the builders without their relevant arguments, however we could always merge 4309 first and then this)
https://github.com/flutter/flutter/pull/83101
(The above PR required that at least one of future and initial data be non-null, this is undesirable as there are plenty of valid reasons to have both arguments be null)

See above issues for a deeper dive, but here is a summary:
It is very easy for a developer to forget to specify `future` or `stream` when using the respective `*Builder` widgets. This produces a non-obvious failure where the UI sits in a "no data yet received" state. It is easy for a dev to misinterpret this as the async work backing the future/stream hanging and they thus waste a lot of time trying to debug the async work.
As such, we should require these two constructor arguments to make it impossible/much harder for devs to make this time-wasting mistake.

This is a breaking change. However, it should break only a small number of active projects given that using a builder without specifying `future` or `stream` seems highly niche.
The only place I've found non-accidental examples of this is in widget tests where you're calling `pumpWidget` with and without these arguments to test `*Builder.didUpdateWidget`'s behavior. In this and similar cases, it is a trivial fix to add `future: null`/`stream: null`.

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

4d86f5d0

Roll Flutter Engine from 7d87410a51d5 to 024bf946232d (6 revisions) (#125858) · 7907f931

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/7d87410a51d5...024bf946232d

2023-05-02 skia-flutter-autoroll@skia.org Roll Skia from 38e56b6da8f9 to c9e0992be00b (3 revisions) (flutter/engine#41655)
2023-05-02 skia-flutter-autoroll@skia.org Roll Dart SDK from dc4a048e3cf7 to 25c29435f73e (1 revision) (flutter/engine#41654)
2023-05-01 flar@google.com [Impeller] take advantage of DisplayList culling (flutter/engine#41606)
2023-05-01 godofredoc@google.com Use os_dimension in framework tests. (flutter/engine#41649)
2023-05-01 58529443+srujzs@users.noreply.github.com Turn @staticInterop tear-off into closure (flutter/engine#41643)
2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SJOgKviZ-kwWd1Z1u... to ur2ymZJCZSj64s6Q2... (flutter/engine#41648)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from SJOgKviZ-kwW to ur2ymZJCZSj6

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7907f931

Roll Flutter Engine from 3fa6084dfb36 to 7d87410a51d5 (4 revisions) (#125845) · d304545d

engine-flutter-autoroll authored May 02, 2023

https://github.com/flutter/engine/compare/3fa6084dfb36...7d87410a51d5

2023-05-01 ychris@google.com Update xcode to 14e222b (flutter/engine#41640)
2023-05-01 aam@google.com Run flutter license script with dart `--intrepret_irregexp` runtime option (flutter/engine#41646)
2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 82d1ef7a833e to 38e56b6da8f9 (8 revisions) (flutter/engine#41645)
2023-05-01 ychris@google.com Move scenario app to use iPhone Se 3rd gen iOS 16.2, un-skip test `TwoPlatformViewsWithOtherBackDropFilterTests` (flutter/engine#41532)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d304545d

Migrate Xcode projects last version checks to Xcode 14.3 (#125827) · 1861ac47

Jenn Magder authored May 02, 2023

1. Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent `Update to recommended settings` warning.
2. Update iOS and macOS templates to same.
3. Update iOS template to set `BuildIndependentTargetsInParallel` to YES as suggested. I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration.
4. Run all example/integration test project to see migrator work.
5. Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside `SHARD=build_tests`.

Fixes https://github.com/flutter/flutter/issues/125817
See https://github.com/flutter/flutter/pull/90304 for Xcode 13 example.

1861ac47

01 May, 2023 6 commits

Roll Flutter Engine from 58cc54197a54 to 3fa6084dfb36 (1 revision) (#125839) · 635337ca

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/58cc54197a54...3fa6084dfb36

2023-05-01 timmaffett@gmail.com Fixes font-subset to not drop GSUB/GPOS/GDEF tables for variable fonts where they are needed Fixes #125704 (flutter/engine#41592)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

635337ca

Roll Flutter Engine from 687f4c761db1 to 58cc54197a54 (6 revisions) (#125833) · 050e4ade

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/687f4c761db1...58cc54197a54

2023-05-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from NBgD7NzOpwnAULR_g... to u7iIoiSX4y8WV6Of1... (flutter/engine#41641)
2023-05-01 godofredoc@google.com Add the verify exported symbols to linux builds. (flutter/engine#41635)
2023-05-01 30870216+gaaclarke@users.noreply.github.com [Impeller] Turns on the Metal validator for impeller_unittests. (flutter/engine#40998)
2023-05-01 dnfield@google.com [Impeller] Remove duplicate component in path.h (flutter/engine#41639)
2023-05-01 whesse@google.com Forward fix for roll of Dart SDK to version with new checked-in SDK (flutter/engine#41634)
2023-05-01 skia-flutter-autoroll@skia.org Roll Skia from 1a6a1e905518 to 82d1ef7a833e (5 revisions) (flutter/engine#41637)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from NBgD7NzOpwnA to u7iIoiSX4y8W

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

050e4ade

Roll Flutter Engine from 666bc34c61aa to 687f4c761db1 (2 revisions) (#125818) · 828a0404

engine-flutter-autoroll authored May 01, 2023

https://github.com/flutter/engine/compare/666bc34c61aa...687f4c761db1

2023-05-01 skia-flutter-autoroll@skia.org Roll Dart SDK from a433ca08e7e2 to dc4a048e3cf7 (1 revision) (flutter/engine#41636)
2023-05-01 xilaizhang@google.com [flutter roll] Revert "Determine lifecycle by looking at window focus also" (flutter/engine#41626)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

828a0404

Revert "Add migrator to upgrade gradle version when conflict with And… (#125813) · db7196c5
gmackall authored May 01, 2023
```
â¦roid Studio bundled Java version is detected (#124085)"

This reverts commit eba2a520.
```
db7196c5
Roll pub packages (#125801) · b2f22321
Flutter GitHub Bot authored May 01, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
b2f22321
[tools] fix `expect` calls in `FakeCommand` (#125783) · a27cb145
Andrew Kolos authored May 01, 2023
```
Fixes #125782.

Would be nice to figure out a way to put this under test.
```
a27cb145