- 23 Oct, 2018 2 commits
-
-
Jacob Richman authored
Ensure that cached dill files for builds with --track-widget-creation always have .track. in the file name to avoid mixing transformed and untransformed kernel files.
-
Jason Simmons authored
Also includes * Updates to affected tests * Change flutter_tools to pass package URIs to the Dart front end instead of filesystem paths
-
- 05 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 01 Oct, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 12 Sep, 2018 1 commit
-
-
Alexandre Ardhuin authored
* enable lint unnecessary_new * fix tests * fix tests * fix tests
-
- 07 Sep, 2018 1 commit
-
-
Jason Simmons authored
Fixes https://github.com/flutter/flutter/issues/21215
-
- 04 Sep, 2018 2 commits
-
-
Chris Bracken authored
-
Chris Bracken authored
This patch eliminates the --preview-dart-2/--no-preview-dart-2 flag, hardcoding all uses to true. It also defaults all previewDart2 method parameters to true, where they hadn't yet been. A series of subsequent patches will eliminate all previewDart2 parameters and the associated code from within the codebase.
-
- 30 Jul, 2018 1 commit
-
-
Ian Hickson authored
Disallow calling stop() or cancel() multiple times. This means that when you use startProgress you have to more carefully think about what exactly is going on. Properly cancel startProgress in non-ANSI situations, so that back-to-back startProgress calls all render to the console.
-
- 26 Jul, 2018 2 commits
-
-
Jonah Williams authored
This reverts commit 0636c6fe.
-
Ian Hickson authored
Disallow calling stop() or cancel() multiple times. This means that when you use startProgress you have to more carefully think about what exactly is going on. Properly cancel startProgress in non-ANSI situations, so that back-to-back startProgress calls all render to the console.
-
- 12 Jul, 2018 3 commits
-
-
Alexander Aprelev authored
Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295)" (#19322) This reverts commit cc122f16.
-
Alexander Aprelev authored
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) again (#19277)" (#19295) This reverts commit 700cb767 as it breaks Windows tests.
-
Alexander Aprelev authored
* Revert "Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276)" This reverts commit cf932490 as it also includes fix for type error that broke tests. * Add type cast for dart2 type checks. * Move up to latest goldens * Make inDirectory() type-parameterized. * Add typecasting to transitions_perf_test.dart and microbenchmarks. * Add boolean flag initialization in save_catalog_screenshots.dart * Add type conversion to gallery transition test
-
- 11 Jul, 2018 2 commits
-
-
Alexander Aprelev authored
Revert "Roll engine to fed2ea458ed49088d33eddabc546ba56d600c717 (includes dart roll) (#19044)" (#19276) This reverts commit f4a038da as it breaks microbenchmark tests.
-
Alexander Aprelev authored
* Roll engine to rolled dart Add connectionTimeout property to class that extends HttpOverrides. Upgrade packages. Add more type fixes. Update goldens hash. Add more type fixes. Upgrade packages. Fix tests. Remove strong-mode from analysis options yaml file. Increase dev/devicelab timeout from 2 to 10 seconds. Added getVM to waitForViews. Fix type errors in compileExpression. * Pick up engine revision with fix for microbenchmarks regression. Increase default timeout from 20/30 to 60s.
-
- 25 Jun, 2018 1 commit
-
-
Alexander Aprelev authored
Fixes https://github.com/flutter/flutter/issues/18200.
-
- 13 Jun, 2018 1 commit
-
-
Chris Bracken authored
fuchsia_tester.dart still assumes Dart 1. Previously, it ran tests directly from source, flutter_platform.dart automatically runs a kernel compile when operating in Dart 2 mode, but this assumes a functional Dart SDK is available in the artifacts directly, and fuchsia_tester.dart mocks out the artifacts directory with an empty temp dir. Remaining work is: 1. Get the frontend server building as a dependency on Fuchsia. 2. Patch fuchsia_tester.dart to use a valid Dart SDK and frontend server. This also reverts migration to Dart 2 typedef syntax. This reverts commit 6c56bb24. (#18362) This reverts commit 3daebd05. (#18316)
-
- 08 Jun, 2018 3 commits
-
-
Chris Bracken authored
* It's time to #deleteDart1 (#18293) Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1 benchmarks. All commands now run in Dart 1 mode only. Eliminates --preview-dart-2 / --no-preview-dart-2 support. * Fix indentation, remove no longer necessary .toList() * Only push udpated kernel if >0 invalidated srcs
-
Chris Bracken authored
Several benchmarks started failing during kernel compile: 1. Timeouts: * commands_test * hot_mode_dev_cycle__benchmark * run_machine_concurrent_hot_reload * service_extensions_test 2. Kernel compiler crash: * hot_mode_dev_cycle_linux__benchmark * routing_test 3. Unexpected termination: * hot_mode_dev_cycle_win__benchmark This reverts commit ed63e708.
-
Chris Bracken authored
Eliminates support for Dart 1 in flutter_tools, and drops our Dart 1 benchmarks. All commands now run in Dart 1 mode only. Eliminates --preview-dart-2 / --no-preview-dart-2 support.
-
- 05 Jun, 2018 1 commit
-
-
Alexandre Ardhuin authored
-
- 09 May, 2018 1 commit
-
-
Chris Bracken authored
This replaces the --prefer-shared-library flag, which falls back to regular (non-shared-lib) compile if the NDK is not found, with the --build-shared-library flag, which exits with an error message if the NDK is not found. This simplifies the set of allowed code paths through AOT compile, resulting in better testability and easier-to-follow logic. It also results in more predictable behaviour for continuous integration and other scenarios.
-
- 07 May, 2018 1 commit
-
-
Chris Bracken authored
This change adds support for armv7, arm64, and universal iOS apps. This change eliminates iOS target architecture hardcoding (previously arm64 only) and uses the target architecture(s) specified in Xcode's ARCHS setting ('Architectures' in Xcode Build Settings). For universal binaries, set ARCHS to its default value, $(ARCHS_STANDARD). Note that after changing the architecture in Xcode, developers should run 'pod install' from the ios subdirectory of their project. A separate change (that will land before this one) will add support for automatically detecting project file and Podfile changes and re-running pod install if necessary. This change also adds an --ios-arch option to flutter build aot. In iOS AOT builds (in profile and release mode), this dictates which architectures are built into App.framework. This flag should generally be unnecessary to set manually since flutter build aot is typically only invoked internally by flutter itself.
-
- 01 May, 2018 1 commit
-
-
Chris Bracken authored
There's very little code-sharing between the two, and what little there is is concentrated in the GenSnapshotClass and the fingerprint reading/writing utility methods.
-
- 29 Apr, 2018 1 commit
-
-
Chris Bracken authored
Moves the kernel compile step to the beginning of the AOT build in a separate method. This is pre-factoring for iOS universal builds where the kernel build happens once, but we then snapshot twice: once for armv7 and once for arm64. This also writes dependencies to build/kernel_compile.d rather than build/aot/snapshot.d, since that is immediately overwritten by gen_snapshot.
-
- 27 Apr, 2018 4 commits
-
-
Chris Bracken authored
This isn't user-specifiable through a flag, so no need to pass it as a parameter.
-
Chris Bracken authored
Fixes a bug introduced in 82f969ff where the depfile used for AOT snapshotting, useful in particular for skipping gen_snapshot when inputs/outputs haven't changed since the last build.
-
Chris Bracken authored
Inlines the buildAotSnapshot function, which simply passes through its arguments to Snapshotter.buildAotSnapshot.
-
Chris Bracken authored
This is required for iOS debug builds, but unused otherwise. In theory, Android debug builds could be run in this mode, but this is historically untested and adds unnecessary complexity to the code. If ad-hoc testing is required, it can be patched in when necessary. This re-lands 8c4f0c0d with a fix to xcode_backend.sh to eliminate the use of --interpreter.
-
- 26 Apr, 2018 8 commits
-
-
Chris Bracken authored
Requires a fix to xcode_backend.sh. Will followup momentarily with that fix. This reverts commit 8c4f0c0d.
-
Chris Bracken authored
This is required for iOS debug builds, but unused otherwise. In theory, Android debug builds could be run in this mode, but this is historically untested and adds unnecessary complexity to the code. If ad-hoc testing is required, it can be patched in when necessary.
-
Chris Bracken authored
This moves AOT snapshotting out of build_aot.dart and into the Snapshotter class. It also adds unit tests for iOS debug, profile, and release builds.
-
Chris Bracken authored
This fixes and re-lands 4bb7496b, which was reverted in ceade39c due to test failures caused by a bad rebase.
-
Todd Volkert authored
This reverts commit 4bb7496b.
-
Chris Bracken authored
Allows for better mockability when tests are added.
-
Chris Bracken authored
This allows for testing with MemoryFileSystem, when tests are added.
-
Chris Bracken authored
Makes for easier mocking, particularly for testing AOT snapshot build.
-
- 24 Apr, 2018 1 commit
-
-
Chris Bracken authored
Wraps the compile function in a class injected via the global context, which makes it easier to mock in unit tests -- specifically tests for AOT snapshotting, which already require pretty significant amounts of mock inputs.
-
- 23 Apr, 2018 1 commit
-
-
Chris Bracken authored
This replaces the existing manual invocation with the GenSnapshot class, which allows for better configuration and testability.
-