Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
ac8b906c
Unverified
Commit
ac8b906c
authored
Sep 04, 2018
by
Chris Bracken
Committed by
GitHub
Sep 04, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Eliminate support for Dart 1 in AOT snapshotter (#21388)
parent
ed0b8be0
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
23 deletions
+5
-23
build.dart
packages/flutter_tools/lib/src/base/build.dart
+5
-9
build_aot.dart
packages/flutter_tools/lib/src/commands/build_aot.dart
+0
-2
build_test.dart
packages/flutter_tools/test/base/build_test.dart
+0
-12
No files found.
packages/flutter_tools/lib/src/base/build.dart
View file @
ac8b906c
...
...
@@ -75,7 +75,6 @@ class AOTSnapshotter {
@required
String
mainPath
,
@required
String
packagesPath
,
@required
String
outputPath
,
@required
bool
previewDart2
,
@required
bool
buildSharedLibrary
,
IOSArch
iosArch
,
List
<
String
>
extraGenSnapshotOptions
=
const
<
String
>[],
...
...
@@ -130,13 +129,11 @@ class AOTSnapshotter {
'--embedder_entry_points_manifest=
$vmEntryPoints
'
,
'--embedder_entry_points_manifest=
$ioEntryPoints
'
,
];
if
(
previewDart2
)
{
genSnapshotArgs
.
addAll
(<
String
>[
'--reify-generic-functions'
,
'--strong'
,
'--sync-async'
,
]);
}
genSnapshotArgs
.
addAll
(<
String
>[
'--reify-generic-functions'
,
'--strong'
,
'--sync-async'
,
]);
if
(
extraGenSnapshotOptions
!=
null
&&
extraGenSnapshotOptions
.
isNotEmpty
)
{
printTrace
(
'Extra gen_snapshot options:
$extraGenSnapshotOptions
'
);
genSnapshotArgs
.
addAll
(
extraGenSnapshotOptions
);
...
...
@@ -191,7 +188,6 @@ class AOTSnapshotter {
'buildMode'
:
buildMode
.
toString
(),
'targetPlatform'
:
platform
.
toString
(),
'entryPoint'
:
mainPath
,
'dart2'
:
previewDart2
.
toString
(),
'sharedLib'
:
buildSharedLibrary
.
toString
(),
'extraGenSnapshotOptions'
:
extraGenSnapshotOptions
.
join
(
' '
),
},
...
...
packages/flutter_tools/lib/src/commands/build_aot.dart
View file @
ac8b906c
...
...
@@ -110,7 +110,6 @@ class BuildAotCommand extends BuildSubCommand {
mainPath:
mainPath
,
packagesPath:
PackageMap
.
globalPackagesPath
,
outputPath:
outputPath
,
previewDart2:
true
,
buildSharedLibrary:
false
,
extraGenSnapshotOptions:
argResults
[
FlutterOptions
.
kExtraGenSnapshotOptions
],
).
then
((
int
buildExitCode
)
{
...
...
@@ -141,7 +140,6 @@ class BuildAotCommand extends BuildSubCommand {
mainPath:
mainPath
,
packagesPath:
PackageMap
.
globalPackagesPath
,
outputPath:
outputPath
,
previewDart2:
true
,
buildSharedLibrary:
argResults
[
'build-shared-library'
],
extraGenSnapshotOptions:
argResults
[
FlutterOptions
.
kExtraGenSnapshotOptions
],
);
...
...
packages/flutter_tools/test/base/build_test.dart
View file @
ac8b906c
...
...
@@ -146,7 +146,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
),
isNot
(
equals
(
0
)));
},
overrides:
contextOverrides
);
...
...
@@ -159,7 +158,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
),
isNot
(
0
));
},
overrides:
contextOverrides
);
...
...
@@ -172,7 +170,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
),
isNot
(
0
));
},
overrides:
contextOverrides
);
...
...
@@ -198,7 +195,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
iosArch:
IOSArch
.
armv7
,
);
...
...
@@ -245,7 +241,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
iosArch:
IOSArch
.
arm64
,
);
...
...
@@ -293,7 +288,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
);
expect
(
genSnapshotExitCode
,
0
);
...
...
@@ -345,7 +339,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
);
expect
(
genSnapshotExitCode
,
0
);
...
...
@@ -392,7 +385,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
iosArch:
IOSArch
.
armv7
,
);
...
...
@@ -439,7 +431,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
iosArch:
IOSArch
.
arm64
,
);
...
...
@@ -474,7 +465,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
true
,
previewDart2:
true
,
);
expect
(
genSnapshotExitCode
,
isNot
(
0
));
...
...
@@ -506,7 +496,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
);
expect
(
genSnapshotExitCode
,
0
);
...
...
@@ -558,7 +547,6 @@ void main() {
packagesPath:
'.packages'
,
outputPath:
outputPath
,
buildSharedLibrary:
false
,
previewDart2:
true
,
);
expect
(
genSnapshotExitCode
,
0
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment